Received: by 10.192.165.148 with SMTP id m20csp4358992imm; Tue, 24 Apr 2018 01:05:47 -0700 (PDT) X-Google-Smtp-Source: AIpwx48KhOb//bb4UZUxuh5SCeEJikih6A+mHkxKCCuOQO/FfzHUy6WjfIZjjTg9glrBS+pD5Ys4 X-Received: by 10.99.120.195 with SMTP id t186mr11589548pgc.97.1524557147728; Tue, 24 Apr 2018 01:05:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524557147; cv=none; d=google.com; s=arc-20160816; b=JtSUjS4B+YnvjXiUMaplaDhGs8XFrAMmll7nSCcl81/Ye4SpSdfIn1oC3pvvwEn/Hz xh6qTWtuC6Z9YjLqoYUiBy/AxKY/Ptul8Z0X6uMh02aTss8gUb+aBZ2d6wFhOb85iNPA gZnJDwrubpXhchjONHWCYaBqCapWFSp6PEFAcihHiJ5qk2qWA/4hHRVvPABdv5nCNzNl JBrAOe459JALLEgOQ2+9Z6wOSBZXCl2FVUZ/qBiAVLL/KRnnezDyqQbZ4vu3S03tSp9Q bMSEJTKkWizjnMHyz6X8/9EgnHsIbjSWtncbqkIKM+y5r1NdHyRNyHDHBX07dUIUswhB oOmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=Th8ZSDHqzoPR+JMst1A3t+bwrxnwTvaNvcvxWmLLQM0=; b=cjIC56D8xupUyHni/iCztbwc+KnP2agyJibaJhjCF2ehGpFK0mQNaNDfc7sz81QJtP ReF8be/6c1IFj05WlR+WMt8/ySg8GBCAENYZHQB3SC905FOTo8SZkEuJMLfIdgymzMWG 5MPhzdWm4fGOBWhORGpXX2qya01L3RBuxFP68cWMlm2upN1W1lnTbmYKXn7wqEdt16sL tScc30GYyhKivNyaZs2N6gCBtVy+u1e2Pkro2rPX2Dkwqndj//zdn1iksAIfLllkSWFQ vaG69Jgp4/a8CY7HqfYwZr9q0drqP4vZ7MpE3dhfzRdkYFuHTCXP4PixGd9TugztK5y1 Nv6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MrXndC9u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f35-v6si11183859plh.193.2018.04.24.01.05.33; Tue, 24 Apr 2018 01:05:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MrXndC9u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756367AbeDXIDr (ORCPT + 99 others); Tue, 24 Apr 2018 04:03:47 -0400 Received: from mail-ot0-f193.google.com ([74.125.82.193]:33012 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755992AbeDXIDl (ORCPT ); Tue, 24 Apr 2018 04:03:41 -0400 Received: by mail-ot0-f193.google.com with SMTP id l22-v6so9719875otj.0 for ; Tue, 24 Apr 2018 01:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Th8ZSDHqzoPR+JMst1A3t+bwrxnwTvaNvcvxWmLLQM0=; b=MrXndC9u1QE45GKi5sCP3vvTO5lfXRQPubw7sjs1nLNEopZQowPpFcC8EHCznBfu2V 7toaGOx0hDMs44HjzbFXx0+38tRdFmOCb62MfG2S6kJNJVbnj80mJbjNHaTnEkO6EaCn DT9znlWUm8f10KWSA5tzbzlJNmaoUaVpURsyOWlUwJVEhn1MGgFhTHFd9rgH0JQL6Efd I+U25InohlYfT6hxIeM/l0+u+2q77n3zujJLIJJFUwI/2P+yiT8HXjfMvbIIGSedvGbd lBNVLBkjm5zbw1pflJMvV67w+rioxgag0Uzs0DttcZR6L7Zu3r9aq+k9rPD0dVWoc1w+ FdGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Th8ZSDHqzoPR+JMst1A3t+bwrxnwTvaNvcvxWmLLQM0=; b=ExYIZwyC0UqyZgzdBK/A2SMxy0se/HyqrozuTEZtnR8XnRejCy16G9yBLor3sS3zi8 bybnQfY7vPQdBNAvQmKX0NVpbZEErr/DE0phQbTUI25MkNpZ/LOSz6bsnMniD+BS15Z2 6Mkjju47T7ic2xqz1IlBuV/Km72UV5H9hSfj0OtBGYofy6vBjBgezwsGGB2tEDSaNilR iiuKwThVPIdd6rlcAF/iQICXMdGh5pwITccuRFWD318WIapRtT2VucTcr0bXE6qFA2w/ 9ivj9G4SSFzc4+POBd+QdeOIalzH6Ytfc+Rs4gSDBSoCDbOZUg36jAFMCe4gFb+rjwIq NuSw== X-Gm-Message-State: ALQs6tAqYF8kb8biUj8n1n6Veq91YwhOjiGB6LbPGSq1yVkrVe6Gi1Wx jcSo0L/dszDl89DQlKF1LreUmCzU1eE9Q/clGpM= X-Received: by 2002:a9d:2d83:: with SMTP id g3-v6mr14717879otb.259.1524557020856; Tue, 24 Apr 2018 01:03:40 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:1e8a:0:0:0:0:0 with HTTP; Tue, 24 Apr 2018 01:03:40 -0700 (PDT) In-Reply-To: <20180420170327.31569-3-jorge.sanjuan@codethink.co.uk> References: <20180420170327.31569-1-jorge.sanjuan@codethink.co.uk> <20180420170327.31569-3-jorge.sanjuan@codethink.co.uk> From: Ruslan Bilovol Date: Tue, 24 Apr 2018 11:03:40 +0300 Message-ID: Subject: Re: [alsa-devel] [PATCH 2/4] ALSA: usb-audio: ADC3: Fix channel mapping conversion for ADC3. To: Jorge Sanjuan Cc: Takashi Iwai , Greg Kroah-Hartman , alsa-devel@alsa-project.org, Michael Drake , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 20, 2018 at 8:03 PM, Jorge Sanjuan wrote: > From: Michael Drake > > The channel mapping is defined by bChRelationship, not bChPurpose. > > Signed-off-by: Michael Drake > --- > sound/usb/stream.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/stream.c b/sound/usb/stream.c > index 6a8f5843334e..956be9f7c72a 100644 > --- a/sound/usb/stream.c > +++ b/sound/usb/stream.c > @@ -349,7 +349,7 @@ snd_pcm_chmap_elem *convert_chmap_v3(struct uac3_cluster_header_descriptor > * TODO: this conversion is not complete, update it > * after adding UAC3 values to asound.h > */ > - switch (is->bChPurpose) { > + switch (is->bChRelationship) { Good catch! Somehow I overlooked this, so in my case of Generic Audio it is always mono. Reviewed-by: Ruslan Bilovol > case UAC3_CH_MONO: > map = SNDRV_CHMAP_MONO; > break; > -- > 2.11.0 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel