Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        "Jani Nikula" <jani.nikula@linux.intel.com>,
        "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
        "Rodrigo Vivi" <rodrigo.vivi@intel.com>,
        "David Airlie" <airlied@linux.ie>
From:   Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <09f02909-90cb-60f0-e362-7d5314dd8964@embeddedor.com>
Cc:     intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20180424131545.GA4053@embeddedor.com>
 <152457614368.12387.9348969127399551440@mail.alporthouse.com>
 <09f02909-90cb-60f0-e362-7d5314dd8964@embeddedor.com>
Message-ID: <152457701306.12387.8661221098982971725@mail.alporthouse.com>
User-Agent: alot/0.3.6
Subject: Re: [PATCH] drm/i915/selftests: Fix uninitialized variable
Date:   Tue, 24 Apr 2018 14:36:53 +0100
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Gustavo A. R. Silva (2018-04-24 14:30:58)
> 
> 
> On 04/24/2018 08:22 AM, Chris Wilson wrote:
> > Quoting Gustavo A. R. Silva (2018-04-24 14:15:45)
> >> There is a potential execution path in which variable err is
> >> returned without being properly initialized previously.
> >>
> >> Fix this by initializing variable err to 0.
> > 
> > err is only returned along an error path, returning 0 would not be
> > useful. Which path? All the error paths look correct to me.
> > -Chris
> > 
> 
> If the following two conditions take the false branch then the function 
> returns err with a random stack value:


It would help if I read the right function. Ok,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris