Received: by 10.192.165.148 with SMTP id m20csp4671039imm; Tue, 24 Apr 2018 06:40:47 -0700 (PDT) X-Google-Smtp-Source: AIpwx48FQDAjSbRJuHYh/h48hMI4r+bPb1zEUtoq6t845PsLZchSh19cj6nBdVyJvfKO7bdDoiro X-Received: by 10.98.213.8 with SMTP id d8mr19058173pfg.234.1524577247626; Tue, 24 Apr 2018 06:40:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524577247; cv=none; d=google.com; s=arc-20160816; b=cpsDG7SdJDaUxt1lI83qNaeFXDoN+zpZtyxfqMB4UAzXC20w8xTtR4sFjQBJNdBheD FYaoAcnmoLgZDi5kozjU/Eng/VcMnENAaUQFjFaxb3Z768qnUgMSOOKmhaTmVtvGLtJ/ wKp1UQemgMA0UCCGlIsK2Wq3IThpbmyJWm50Zw8aZ1+F2S89/TdGiur6R7KwJW2xaOLC R1tjpo9abH3sZkAof8Lhp9nHNHGPnJvfWAd6yf4VCPjMZEUayWwhUyuzBi4egPGzJaoN D76rQy61OLFyuwsAzagZO8IZwguW00bdhJQ21T7G++7SfbD+wvzGDqB0rTzk3Vex5vUY q18Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature:dkim-filter :arc-authentication-results; bh=h7JLCWdMXkenbo+bTtG7Y8apDIBaUW2Yxhg80MfyVVw=; b=S4K3Q4gdLCNz4wHrlumVbZnc29HdxqucZ2YuNvOUHLTyUraQpQJ0Hn6K/ewS3D8ACw 1y9ObVdp874fnofHvDCIb5zOsZ/+E5Mou9Ac+cS++QfwU4QQ06woHYe3ch2AbgxMknY1 zUxPEl3cVnr7sGw6DZlXahtlBumuFs+Bayzp+E6/LsazK/kraY4zqcsCW/9ujArDG8qF ++G6L+i8Vxqr+T3tsZqmp39SJXBkZ6NlOdtDaERX1YwgeNJwB/gF89LR3nWGrRNiou3X I4t4L/prLE7BuaUcHPzzTIb/Jjv0RBp3gizr68T1dLUTLmgbynJCeHPlGv1fTQeLFpJg liQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@perex.cz header.s=default header.b=XaVnsTe+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z63si11456943pgb.28.2018.04.24.06.40.32; Tue, 24 Apr 2018 06:40:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@perex.cz header.s=default header.b=XaVnsTe+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934685AbeDXNhw (ORCPT + 99 others); Tue, 24 Apr 2018 09:37:52 -0400 Received: from mail1.perex.cz ([77.48.224.245]:36282 "EHLO mail1.perex.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933338AbeDXNht (ORCPT ); Tue, 24 Apr 2018 09:37:49 -0400 X-Greylist: delayed 481 seconds by postgrey-1.27 at vger.kernel.org; Tue, 24 Apr 2018 09:37:49 EDT Received: from mail1.perex.cz (localhost [127.0.0.1]) by smtp1.perex.cz (Perex's E-mail Delivery System) with ESMTP id E7B6FA0040; Tue, 24 Apr 2018 15:29:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.perex.cz E7B6FA0040 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perex.cz; s=default; t=1524576585; bh=h7JLCWdMXkenbo+bTtG7Y8apDIBaUW2Yxhg80MfyVVw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=XaVnsTe+5dkuzYXrn0aGy95ZyA63cPNw29yt5st6Mwjgez2jlj2u6ycerVkqlgEvu RFgiJLi8GodL60uv4p2VfrPsD6aC+Z/52zlWpUOM1892zqK93OGLWrUVHIlhVSDIQj YRAOdZZt0Lqh0cR2NFCDdtGLuGNYItMvSe6cf7tc= Received: from p50.perex-int.cz (unknown [192.168.100.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: perex) by mail1.perex.cz (Perex's E-mail Delivery System) with ESMTPSA; Tue, 24 Apr 2018 15:29:24 +0200 (CEST) Subject: Re: [PATCH 0/8] Fix year 2038 issue for sound subsystem To: Baolin Wang , tiwai@suse.com, arnd@arndb.de Cc: lgirdwood@gmail.com, broonie@kernel.org, o-takashi@sakamocchi.jp, mingo@kernel.org, elfring@users.sourceforge.net, dan.carpenter@oracle.com, jeeja.kp@intel.com, vinod.koul@intel.com, guneshwor.o.singh@intel.com, subhransu.s.prusty@intel.com, bhumirks@gmail.com, gudishax.kranthikumar@intel.com, naveen.m@intel.com, hardik.t.shah@intel.com, arvind.yadav.cs@gmail.com, fabf@skynet.be, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: From: Jaroslav Kysela Message-ID: <66b26dc6-9139-80cc-0b49-28ff68169b5c@perex.cz> Date: Tue, 24 Apr 2018 15:29:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 24.4.2018 v 14:06 Baolin Wang napsal(a): > Since many structures will use timespec type variables to record time stamp > in uapi/asound.h, which are not year 2038 safe on 32bit system. This patchset > tries to introduce new structures removing timespec type to compatible native > mode and compat mode. > > Moreover this patchset also converts the internal structrures to use timespec64 > type and related APIs. Thanks for your patchset. A few comments: It might be more nice to reuse the existing structures and put timespec64 to the reserved field and duplicate information (with the 32-bit wrapping for the old fields). It means that we do not need new ioctls and old libraries will be fine. It may make sense to define private snd_timespec32 and snd_timespec64 with s32/s64 types instead separate sec/usec fields. Jaroslav -- Jaroslav Kysela Linux Sound Maintainer; ALSA Project; Red Hat, Inc.