Received: by 10.192.165.148 with SMTP id m20csp4672095imm; Tue, 24 Apr 2018 06:41:48 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/5uptAAY4N6eqyEz/zhQa6KBTDdM95H2fQVoNjnCREi7tTwWKe1RryaUB4LB0KX69TrLFF X-Received: by 2002:a17:902:144:: with SMTP id 62-v6mr25029494plb.202.1524577308748; Tue, 24 Apr 2018 06:41:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524577308; cv=none; d=google.com; s=arc-20160816; b=zHC8a8O7bHImHLHbvMQLz58w3UDQaXZXNf2EnpAB5cLZQPaAdFnwgrFhDD73uB7NnA /IdLTIgJHOa34orXZ+hFfOO1fFWkXNtqiAqqii2i5kxVSaxZcOBAiB73AEjDyJnlR20v /KBZA6CRhH+ZZNXLOCAxxqmlGIiJOgdauDbQmdvV1/gii4Lyu8t36Q0vm5WVeMAvlqTs dZJyG7EB6TGg7C+fUMUK9tg9ldc7oV70Frw4Zpw5i4QrcZaI8l87+7gfzyGID1jLUUxc 4sODelqP64n6GP07qpql+RzMNPVNQJ4k8NPjzlgcc0vWC/BBG13ihQRtCGj5K1W3gaDw 8kAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=KBKXIwkSW8hG4QgcPJOc+ywNnsPaCGw492SQ8YyybKI=; b=h+wCwn1mAmd3SrUzRXoktW3xUrMxp7NbOX1xvmVSHOQMKlRTDFnrb1XrIe2BqRP4HY oKIL0tWslxQzni27PeV1DjmvjrIpjuZydVjF1ZK26u+/2jYLekWpDo9TsOTMs0Vr7f3q uKYy0VMJNDFHOM5RPygHat2ZHW0u1R23nFzos7XX6CSHRYu+4egpN5lQoQ59VPfFi1Bx iR6tgN+RFN/lYiZLPYYgDPcCSOqmfV2Ykkh7t/zkfKQcvM/Z5QXv5E0jKSACEJ3ZmToF NKCjJFkILpxBkZ9YYgFDkT6R47pRHw33SL3iOQjk/wPUgC28RLrnR1SEuNBZKd+Bi/OH fxDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gtqJM43A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k12si11866444pgc.182.2018.04.24.06.41.33; Tue, 24 Apr 2018 06:41:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gtqJM43A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933879AbeDXNR3 (ORCPT + 99 others); Tue, 24 Apr 2018 09:17:29 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:39714 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933374AbeDXNRT (ORCPT ); Tue, 24 Apr 2018 09:17:19 -0400 Received: by mail-wm0-f67.google.com with SMTP id b21so807193wme.4; Tue, 24 Apr 2018 06:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=KBKXIwkSW8hG4QgcPJOc+ywNnsPaCGw492SQ8YyybKI=; b=gtqJM43AZac7qknCSv30L0xX4hwhDsy5PYQ6p1zRF8VcpVF0f4634XVEbiwNyo3AEK 0Cu/kaRFLvhzaW85Tg9RzLIV8jRweV1ijM+qHDAmNi1WgoZ8qrZS1wYTiNevps1SeUg2 FV3u+f0cCh7x1YXy2vgUC8O6ENXwI8jRuQMMrK+JtujRDkHVd29nemYkfwuI4BgHfnOR fJIk8oLSNTUZrAda2io48q1potYNG463WBCwOLqN2W+QtftmrjsHdxteDSIFG+jC1jYI ok/2QUs396yDoel1BVMQd1fGicpP3snXJwexTgZhuYmS1URpXGi6TW0pV7ftF60pBUmr SoKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=KBKXIwkSW8hG4QgcPJOc+ywNnsPaCGw492SQ8YyybKI=; b=B53+6OY0hH2ROo1TPwa+ocp4xfWoLB00DKHMQrhVasmcaZerBdz6pUDLs2JnE2MLab kFqRwHADrsOD6VKeM3NUk80SnZsM4gT73LZgw7IUioU63f3z3BvieuVlZD1tBacyrzmY f+glPFOQ/vNhlW4nakQjehyr32eHGtqrXSGwU6znKKn1KEOJBpAg7myuAiYoRFEkMBT4 dKMrmBrjcOIYaBHBlM3QFwFhxj0UQ4GTqdXFWmS3ZkEjlGzM6N2HuOLT+2/hKDrkGtjp uxCglZJ7SSk8JavEYNr85SfC68P7hND/pY+3i13UaVqi3kPd+4+P78ISQSr6oAYRPagi khDg== X-Gm-Message-State: ALQs6tBBpr+ZcrvZE7VAymElNmIhCgpalVHHVBCK3QWcGbHq2fCGJ0ZF q9A+ggJ7MlxaH1GhVzUXBI58dxrLyY8= X-Received: by 10.80.142.207 with SMTP id x15mr33759684edx.128.1524575837872; Tue, 24 Apr 2018 06:17:17 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id 4sm9483939edt.95.2018.04.24.06.17.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:17:17 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , Timur Tabi , netdev@vger.kernel.org Subject: [PATCH] net: qcom/emac: fix emac_start_xmit()'s return type Date: Tue, 24 Apr 2018 15:17:16 +0200 Message-Id: <20180424131716.4308-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/qualcomm/emac/emac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c index 13235baf4..ed64bafc2 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac.c +++ b/drivers/net/ethernet/qualcomm/emac/emac.c @@ -123,7 +123,7 @@ static int emac_napi_rtx(struct napi_struct *napi, int budget) } /* Transmit the packet */ -static int emac_start_xmit(struct sk_buff *skb, struct net_device *netdev) +static netdev_tx_t emac_start_xmit(struct sk_buff *skb, struct net_device *netdev) { struct emac_adapter *adpt = netdev_priv(netdev); -- 2.17.0