Received: by 10.192.165.148 with SMTP id m20csp4673742imm; Tue, 24 Apr 2018 06:43:20 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+9ULz2OUiIUbYHetyHs73xKebRPR2kd6389e2pt/ZgeXASRefXeCCjjVmKiZwjxUxzIB+b X-Received: by 10.98.8.12 with SMTP id c12mr24132377pfd.77.1524577400103; Tue, 24 Apr 2018 06:43:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524577400; cv=none; d=google.com; s=arc-20160816; b=bdRBDoDOiMfO3PjZA8u7az4+B0Wv1zJWBAio9gDV7IBLwHXp2i2VoOULyU9jRVeF/T YyMBA4PIiRLdh3MGmYs27cuNXAWdBoq0eXq4IyrdQZTvAOLupEQEvuDbkKklTqNnEBv+ ZREKBRMaWJjs+XC/uI9QnR+80tP5v/Q2kCigWijtJuX+5cctDK4M1j4OWHd9YkAL9wqw E6+HCoQkQXKZ8yMyp6IMTQwBcPMxlFz8qgHgUCKlJqnuq0XsJzFA3WQ8wBkzZRSUcbqR jJ774nSeXoVNd0NNSEmV/Ps/H/A/J3VVlnbCdnQqmPe9tOXfN1WMbXIZ2jpBIryogx89 v3+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=HdwE4rM3RDkdhJ30wuh00uhkkLmD1YDod7o5lvJzeu0=; b=TOuzTQ3jPiF6BAVNiSXVWvDrwAM+g03lNA6fSEHJ1iwDx11fKYf4jFuMcv9uyyUKyV m8fLPvwl+9TYpo8k6jiC8WaRjc6Or3GvovFJplmGgcNolebvOaAo3AveQIt8uPbiV/H+ iBhMJPzTdvdNegFG7mJe14yndYJBO/WWaYRMRNZUcoIymec+89ySfbY5H+LqFIjf6qum quYyIyLyZdtoYDuDIhYLNYm1/umteIYRkqOqT5Ccd2hspkX17e6cQ9pWzTEN+C44mmTQ wz2O40ZI70ZIo5qJ/lT+lIAnqIQUVTGicZ6+vMPSdGH1gCyapkFzTGpkWb7W8RR99PwW I5ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=I7Qdexe6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n30si11870416pgc.231.2018.04.24.06.43.05; Tue, 24 Apr 2018 06:43:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=I7Qdexe6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934465AbeDXNlY (ORCPT + 99 others); Tue, 24 Apr 2018 09:41:24 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35916 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933793AbeDXNRD (ORCPT ); Tue, 24 Apr 2018 09:17:03 -0400 Received: by mail-wm0-f68.google.com with SMTP id n10so799581wmc.1; Tue, 24 Apr 2018 06:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=HdwE4rM3RDkdhJ30wuh00uhkkLmD1YDod7o5lvJzeu0=; b=I7Qdexe6lCwqjgjtHs/tc5hewZDmSD8xxdvEskBilBCCldUzMoq4bdOO7j+NC9ADJl q/54XFpc7oybL0z2B19oE4bCfjvrzUOz2voLEUFh309TAnKceEvuPcON+sZtvdNWrlXF IHt4uB05p5TK9RM0xmQBgWGEmisEU9EGKL16xn1TbvjRCmfHEGc37KvHXnPNF40Zqp9c sgBZJgp12czxiIbqwE8kTLNtGX/y4crjriWIunYl1HXoWZIypyuI5u3mpGprm9jMpMs2 YV2rSoHPVHQrwN9OEMY0E2zFSBI8IdamzsiZwR7PABzL4t8iLdSJbftXehWLgHfPjPmb aA7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HdwE4rM3RDkdhJ30wuh00uhkkLmD1YDod7o5lvJzeu0=; b=VIPVSXnNNxZvLCG0MXKMmmqjEuiyGgEU1QuWpdjUeSY8ZbcLA0AikCEJSSy6kZjLuo 7qqzN3ng2bVTXh3V4Mz0Qhf3rfU45WHwuKNrumabbIcLc3+9HQgEaClJssFcNV9WeunV 6QvtMlRFhi7CErchhf4HZeN5SH+Sr2Tc9OXM4gumqAp13wX+8qERmlyRWI+Q9/J2qk49 2ZS3oJBUSPjDE1WookoFoSsr2+CPAKxEVTr8uwvlIBeO2HFpAw8P4iiU3dpKN/oAZwmf 6BXRLP7PBZ1uyQvMQ0s1bh4rxyfzQEYkcf87i3dgoV3VYP+tJYL48l8ec8AomeAz5QWK iLeg== X-Gm-Message-State: ALQs6tBrM3L8s+md3uIpnBPtFivWjnBz/9iMsIAja0jCW2asyfNbBKN4 dznNyRK0x2mBwuKn3osMPROn/uPYIi0= X-Received: by 10.80.230.9 with SMTP id y9mr32643648edm.26.1524575821932; Tue, 24 Apr 2018 06:17:01 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id e14sm8792148edk.29.2018.04.24.06.17.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:17:01 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , "David S. Miller" , Kees Cook , Alexander Monakov , Allen Pais , netdev@vger.kernel.org Subject: [PATCH] net: pxa168: fix pxa168_eth_start_xmit()'s return type Date: Tue, 24 Apr 2018 15:16:58 +0200 Message-Id: <20180424131700.4104-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/marvell/pxa168_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index 3a9730612..d8745b503 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -1260,7 +1260,7 @@ static int pxa168_rx_poll(struct napi_struct *napi, int budget) return work_done; } -static int pxa168_eth_start_xmit(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t pxa168_eth_start_xmit(struct sk_buff *skb, struct net_device *dev) { struct pxa168_eth_private *pep = netdev_priv(dev); struct net_device_stats *stats = &dev->stats; -- 2.17.0