Received: by 10.192.165.148 with SMTP id m20csp4677682imm; Tue, 24 Apr 2018 06:47:02 -0700 (PDT) X-Google-Smtp-Source: AIpwx49I5LYLbjMphyL6wycZnIqz8m0osUiMuFS0IkUgtwyIBICVos17+HYQD7cw5B9AI2qdKd/p X-Received: by 10.98.99.4 with SMTP id x4mr23830664pfb.179.1524577622770; Tue, 24 Apr 2018 06:47:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524577622; cv=none; d=google.com; s=arc-20160816; b=Pmun7WiXCpPEvFliSc+FMavRtTjFa4dE6motYEzKhv2867MxdnQ5tlPF3Ud6HEwF13 yE2y18/Gyh6Olzz2eWbNp6BlxjaD8V92SU/tguNR16zM/80iL5Zb1vtARkv6+I3F+maO OE0B+m3ZedM2Vt7ZsLdvLqzTNucxCFtWCRrLPXFRojvS5x0FICvtJu6jxRz0/OKEdlKb +xn3NxfZGA4EmS5bIXfS5SQZ+9mowyztzm4DoofPSjVHKPHscZEx+T4zmINJe5TsPW+G yU+8rB3JlqsAC2VpSTnhVfHvgr5o0L/yZm0dXKj5eEq/rPYq7JEOYNyVG14Rd7bv156c hk9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=08AAGlRnv2k2kRy6Fg9oKlibpXoDQEExSJgjoqSw/H8=; b=LyyQ8i/TW7nJme9cFNRIoSF+uoBMB+H6rCP3W5B8ZdCYUeQNDDqJJr/sPVvOplYgWC Xt1UhNBDu2Rw0kAERfYAgvLOkAZ7kvLeqlTWvH04jiaUEliffmvn6ezLqqx2WoCFUE/b 0hIh4nrpKnAA/1ggyLM/0djBQPwE8S9OxzUnxIK3aKrn4HHNqgTsGaUFBYEyyz46XVlP YWlF6Mgm1fQr0q5cer4YqPiRkm+aOEhUP+J3w2gdRN5i4UcY7m/vuAFHs5Urd5EzDnuw DVtyRmw8UyfNIpGvREe91pPUE1+stRilsrcO9rPnvwCC5Z4IAAN993zWK/q/idxXpLzF qxMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SczBW6F7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2-v6si13401073plr.320.2018.04.24.06.46.48; Tue, 24 Apr 2018 06:47:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SczBW6F7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934513AbeDXNo5 (ORCPT + 99 others); Tue, 24 Apr 2018 09:44:57 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34691 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933613AbeDXNQb (ORCPT ); Tue, 24 Apr 2018 09:16:31 -0400 Received: by mail-wm0-f67.google.com with SMTP id w2so509458wmw.1; Tue, 24 Apr 2018 06:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=08AAGlRnv2k2kRy6Fg9oKlibpXoDQEExSJgjoqSw/H8=; b=SczBW6F77I8O4wbbX7Qe7hdcX7p8S5CQvi9FJ3B37FOBrczjyBqRqhay743gQsYgLL TafP5hMcqbSfyZZldoxfI+a3fAl1GEsQaPsEuHbxNOPOLcWE0PrIxlmPIpIU/FawFpnx fwPN3/aSVt/YhB0jbUG6/BuaK6up1lbiuc7QMHWDQFiNh31QMUrzLZXX4TkR2ERlINPt OSNc65C3w9pnQH5/0DIp3ZPz9sxI9JCIfYS/lgo4r+JiLYF61HMvQeKECAQvJeLHyaq3 nt7qyyFeP7/cO3risSyla7pn20M8CClyXnrT01YYUufzDKdlBWB4TfPQxreHawC5L7YM vBig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=08AAGlRnv2k2kRy6Fg9oKlibpXoDQEExSJgjoqSw/H8=; b=EI46tNP6itulQzxgc/xQWO4lSpuvrSdh9RFRauU4YpkbMYDxA7Atz1qFuyNoFe3SgX i5dwFRIYn2Srp1kMcmcj37lZMywGsjSMNh4lLKUocUxFH2uU6MUpGu4SbQFYwqfvGsZj fwU+f0wD1NAH2K33Fp3zT4oqmoct0YOZM+XZ5pckTGhr1VbGH4VTzJiKWWk9967AXIhu yihgZq5XkeyGjGPrbVxH0GgVNl1xB+XtO7zmo4BFXox4V1RMa9XKDCvqJ6iUXWDVCpYn ARIv9ku1rrFkOQc+H13vfqtV/Xi0y6uwuwWq5NniWEX+N5MIbkG6XnoYm2w9Ep5z5aBZ A34A== X-Gm-Message-State: ALQs6tDMlifpgwsn4Ib4Qb3IjWMN+PXDbKOv0GNpSaWU1WxZm4BYpkuV pAg6ZCt9dm0yQ6Y6zft3isA3XDnIFYc= X-Received: by 10.80.217.130 with SMTP id w2mr32349899edj.95.1524575789563; Tue, 24 Apr 2018 06:16:29 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id n3sm8962861edl.27.2018.04.24.06.16.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:16:29 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , "David S. Miller" , Alexander Kochetkov , Romain Perier , netdev@vger.kernel.org Subject: [PATCH] net: arc_emac: fix arc_emac_tx()'s return type Date: Tue, 24 Apr 2018 15:16:25 +0200 Message-Id: <20180424131628.3556-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/arc/emac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c index bd277b0dc..87f395eea 100644 --- a/drivers/net/ethernet/arc/emac_main.c +++ b/drivers/net/ethernet/arc/emac_main.c @@ -676,7 +676,7 @@ static struct net_device_stats *arc_emac_stats(struct net_device *ndev) * * This function is invoked from upper layers to initiate transmission. */ -static int arc_emac_tx(struct sk_buff *skb, struct net_device *ndev) +static netdev_tx_t arc_emac_tx(struct sk_buff *skb, struct net_device *ndev) { struct arc_emac_priv *priv = netdev_priv(ndev); unsigned int len, *txbd_curr = &priv->txbd_curr; -- 2.17.0