Received: by 10.192.165.148 with SMTP id m20csp4685872imm; Tue, 24 Apr 2018 06:55:01 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/MoJ5QQbja/kj1R0vZ6YvrA7ebJoCmuQwyxZOANZr5hafnS80koqFlPqRNc5+UdQx25Se/ X-Received: by 2002:a17:902:d205:: with SMTP id t5-v6mr18622813ply.234.1524578101265; Tue, 24 Apr 2018 06:55:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524578101; cv=none; d=google.com; s=arc-20160816; b=Hx17hLdPM3ATlhasjXKcOoh94KJATUykouC0KtA6OGAdZXShZ6113691ujCLCzCGxu khcDta6a61+OEiboU1EE50NWzGaL+bdDXetBXCo800bMFXIl381NRLy7cDoC9QYyaOno qSMkcXETIZvQ99ZcwkWLNLmieYMdX3iwPivDnj//sPE3GJeJVUyPvpdjnaXfYtDGMDqz 8PMX7xuQFM+YNW5Mhz0mt/Cdv+O1O4TJfR0bUwu+qp7yvvDZTKMxj9kdPaqNtYFxNPmN HKtXkptfM50zuUQUaIpJdEhlPiSbOJbV9+50ETlko58NwcdYhMZbFrs5U8jOAyZUpMgS aWlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=hx0Vtr+KgC++KXlx+1ztrQwK3xG6ALj2+RNZFkZQD2M=; b=bhaimyP2jzOKSMpXCcmro1Vzg7w0NrlbytbfIcsJAtCqxGR3Fs2kNRv8zgOtbB9Zv1 iODRb9GJ+x2gTT6k3iBevGhAH23n6b4OBNS4QgfuoYjdygjZgu1foTd37ybhrFAVMefm bqKVm6EsTDLCDFLyFJHZfVfNR0iYiCnJP4S8EdX5l6waKd5hLLpgrgk7VJOBhksDKorN 10ezZ2GGJ99DL/fqw+DEcqC97dhOKqr7Ib8PJ0pLJS7MHHhKNFkIlfQIeMl9lsj1DIQW QEQK9YfwCLMW1X/6PkHXbtKQMlkm0DAJa0012PvGSCqZxOH3nJjfyqywcXVpdJXf+tCg 0bEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 68-v6si14112546pla.531.2018.04.24.06.54.46; Tue, 24 Apr 2018 06:55:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933575AbeDXNPz (ORCPT + 99 others); Tue, 24 Apr 2018 09:15:55 -0400 Received: from gateway22.websitewelcome.com ([192.185.47.65]:41538 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933220AbeDXNPr (ORCPT ); Tue, 24 Apr 2018 09:15:47 -0400 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway22.websitewelcome.com (Postfix) with ESMTP id C1C34139E4 for ; Tue, 24 Apr 2018 08:15:46 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id AxnOfqCZiA3CSAxnOfw8YV; Tue, 24 Apr 2018 08:15:46 -0500 X-Authority-Reason: nr=8 Received: from [189.145.48.65] (port=55476 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.89_1) (envelope-from ) id 1fAxnO-002UtM-5V; Tue, 24 Apr 2018 08:15:46 -0500 Date: Tue, 24 Apr 2018 08:15:45 -0500 From: "Gustavo A. R. Silva" To: Chris Wilson , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] drm/i915/selftests: Fix uninitialized variable Message-ID: <20180424131545.GA4053@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.48.65 X-Source-L: No X-Exim-ID: 1fAxnO-002UtM-5V X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.145.48.65]:55476 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 8 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a potential execution path in which variable err is returned without being properly initialized previously. Fix this by initializing variable err to 0. Addresses-Coverity-ID: 1468362 ("Uninitialized scalar variable") Fixes: f4ecfbfc32ed ("drm/i915: Check whitelist registers across resets") Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/i915/selftests/intel_workarounds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/intel_workarounds.c b/drivers/gpu/drm/i915/selftests/intel_workarounds.c index 5455b26..17444a3 100644 --- a/drivers/gpu/drm/i915/selftests/intel_workarounds.c +++ b/drivers/gpu/drm/i915/selftests/intel_workarounds.c @@ -239,7 +239,7 @@ static int live_reset_whitelist(void *arg) struct intel_engine_cs *engine = i915->engine[RCS]; struct i915_gpu_error *error = &i915->gpu_error; struct whitelist w; - int err; + int err = 0; /* If we reset the gpu, we should not lose the RING_NONPRIV */ -- 2.7.4