Received: by 10.192.165.148 with SMTP id m20csp4687009imm; Tue, 24 Apr 2018 06:56:03 -0700 (PDT) X-Google-Smtp-Source: AIpwx4++2JRtIeCgMVv0FerAJNaxGFyBowHRvpRzIsKM8tliTQbbj6FRXuvRs5s7CF1b9soWe5Vu X-Received: by 2002:a17:902:5ac1:: with SMTP id g1-v6mr12656076plm.43.1524578163786; Tue, 24 Apr 2018 06:56:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524578163; cv=none; d=google.com; s=arc-20160816; b=A+QQ9LJa/ioI3YRR7BV3OHr3FriuNe9S4NPNFwH7uVNlH1Aou5GHKkLnhWpRKzOWFk RujTqEfq/E5vj7scoJjAFMcVYZvXBtxwD49MKSSkY7H6nveCRYyWl5TA4/VDyJc9+tHV mrSwQFwuyjpYpgaYE0nDFATqshJ0hmbuz03BEfrJDzbJgAbbymwobuBFlpVIEkQU9eV/ SQlQwRGDZ3sRGwC8oS4H7bnCHOB5+VUlOMLqxrx5o0Mir5ljf5NnqlI99E9JxN6LJQIL ktzr9DF7iOxdhdBUtzqBf8ctnDvOXhXe9emPMGzYwcI7nii1FWtEgWTiVKO7e/4fw39g Ie/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=lGXmnWsnNhHEgfHBz9ELnhXZmD93itZwj2M3JIB8xdM=; b=brnJmdicVeIkLccg+f+5nHtkTWPVI9xJEEXSmPXnMEvvQHp/Vtugpuvg6rIT2i9jr+ E+7R8W5zvn0klvcNDQdlaXHyzZ1B6d81thPw1mJIaFteHjOq/6w0q23Kjzgxw34bg6vu 2aJWglkBwKuK51ucXVXtpErs329W5uO37dUfUqo2Tzava/TBiuF5SJgL0UesgNAN20se JkgTrk63+dc+iDEQnpOXbagltTkpBLefNMdsaqxDVflRjbeseqKoxdAUYhzXaH7RS9Ms 6RZndwxNVGFqYhcwLCMv5PzizpDcj2os4IFfL+nrg5rdDr+hYVq6ZQgQ9kAAOsRrDLC3 o6ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=A5lLoAur; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g14si6921156pgu.363.2018.04.24.06.55.49; Tue, 24 Apr 2018 06:56:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=A5lLoAur; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758059AbeDXNx7 (ORCPT + 99 others); Tue, 24 Apr 2018 09:53:59 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35605 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933520AbeDXNPl (ORCPT ); Tue, 24 Apr 2018 09:15:41 -0400 Received: by mail-wm0-f67.google.com with SMTP id o78so794113wmg.0 for ; Tue, 24 Apr 2018 06:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=lGXmnWsnNhHEgfHBz9ELnhXZmD93itZwj2M3JIB8xdM=; b=A5lLoAur+ng8pJJ0nYVYq0qIxetgMHgy4lPqRX9za2K6rT0vl4q9WykJv3TNs1iP8m oTndyfsJ27KKRSrvB6cmdCYwRuXFSK5TnRZbevITsLQXgoJVle42TKDywKFrqmshc6nC YfaCWiU16iFfluOzb61GcCGykElKQZdX5wpIsK3m5VQ9eAXFFoOsEsNHaANgk1pk0sm9 Yh5EYe07Rf2Cux5h7A+Ai1BAo443e4P0diFq4+KHVn7qlnkKA4fSZtNZsI4n3jD0MyVq uvJ0lH7y0ijT0rALJLCRGRrcXXdlWbgZEH/US5aFKGIluFR0iKWOt6ad4jUxDX4+oi+C 6JtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=lGXmnWsnNhHEgfHBz9ELnhXZmD93itZwj2M3JIB8xdM=; b=sF/cCQJypO2J26xRuDfDlNs8DUZIFuEyoth/cey2RM29mBs8/h8/kL6DI8qnDSylm5 G6u7hqy3GlGH/dRx2N0Ld8jfmc9F+bxS48mJ6m80SfXTrUtadulPMI7nAxXwm/6RvqCv j935vgktbStiBXfHYVhFkh796Blz+7J93Pj3ltjUihykhBpP4E83FbOpRtCEy4vw845a iFfWV89EDYjvIwyFr2+nqpZ218MsM6Qbr+6vxxftmyPig03eJshYkb1gElJgsUvnL31q VlhSpTQIN+nLI4W+C7XKvCy2QAIgOlILL7bPYA99+zK3+Ngx7/NqrYEJjuIZHDo4BSjb dwDA== X-Gm-Message-State: ALQs6tBiKj94D31IY/IM8NPusTrdHunHwlB6zGEY0RhFYBcFdS0xo9Nv UzOwj0w4EZqNKvloorUWK7izi+CGNc0= X-Received: by 10.80.245.205 with SMTP id x13mr32740805edm.132.1524575740239; Tue, 24 Apr 2018 06:15:40 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id j30sm8970527edc.38.2018.04.24.06.15.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:15:39 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , Ben Skeggs , David Airlie , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Subject: [PATCH] drm/nouveau: fix nouveau_dsm_get_client_id()'s return type Date: Tue, 24 Apr 2018 15:15:38 +0200 Message-Id: <20180424131539.2662-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method struct vga_switcheroo_handler::get_client_id() is defined as returning an 'enum vga_switcheroo_client_id' but the implementation in this driver, nouveau_dsm_get_client_id(), returns an 'int'. Fix this by returning 'enum vga_switcheroo_client_id' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/gpu/drm/nouveau/nouveau_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_acpi.c b/drivers/gpu/drm/nouveau/nouveau_acpi.c index 5ffcb6683..ffb195850 100644 --- a/drivers/gpu/drm/nouveau/nouveau_acpi.c +++ b/drivers/gpu/drm/nouveau/nouveau_acpi.c @@ -193,7 +193,7 @@ static int nouveau_dsm_power_state(enum vga_switcheroo_client_id id, return nouveau_dsm_set_discrete_state(nouveau_dsm_priv.dhandle, state); } -static int nouveau_dsm_get_client_id(struct pci_dev *pdev) +static enum vga_switcheroo_client_id nouveau_dsm_get_client_id(struct pci_dev *pdev) { /* easy option one - intel vendor ID means Integrated */ if (pdev->vendor == PCI_VENDOR_ID_INTEL) -- 2.17.0