Received: by 10.192.165.148 with SMTP id m20csp4724993imm; Tue, 24 Apr 2018 07:28:47 -0700 (PDT) X-Google-Smtp-Source: AIpwx49RYx1CP3bh78NybZEB4ZIyw9dVqDW1vCR0uQjpQe2K4Sj9UQyJr+BxMNq8Z2EpsjLhxWBG X-Received: by 2002:a17:902:7e4a:: with SMTP id a10-v6mr21266947pln.276.1524580127315; Tue, 24 Apr 2018 07:28:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524580127; cv=none; d=google.com; s=arc-20160816; b=AxC4Bk9LI9aRtuR1MRj4f80GVNLLE8PA++wifIAPbSEsqGrsRD+0dGdy3cSo9CxABC TVo9lBIUu2AjKYdqNfJbtSR3e8b7xKj711VumQhxHBPLVt1RlVyDOLc6S29KKmfgI8es D7TXnkOMr2qDcMgrTrk+KGzSKQM3gKNrSXU2WBFgwKR/H37dZytfsUVNtvpnIV7yj7PT CbnMbzX2qKs9MViHMbwOqWls9BqZkkVWQrDSvuTb3ygjTWEwPPRI/MJww5G3Mi35gMgp I6sICfsTYZDUyNAyut2L6N7gYWQ23XxHJqJvcnyFwz+enoweBYzbjfW4+FD2PNR4wI2U 2QyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dmarc-filter :arc-authentication-results; bh=vtut0kIz7f8MYFQW2zrvgmOldCfS/Z399mstkUP+LEc=; b=fO0Af7X3f+hRn+xFCTwlhJMnrRDD5bAUXoEVO8J3xxo35EMKB9vbN9+hMiOfDY8GSM iMgoog41u30RGpMPEeXfj4SQ3ERxn6Q7xppWiSGJIgLGd77vZDvQqmr07tFPGaIcHtUR OvFQ3tS6O+B85L0U6OeRwwMlHltXjm7cHsypwDUDae1H5AJ5s+moaGA6QhAhV68XJ7ld vSvX4BU0Uus7+EbyikvHTEoKAXZ8dX/kaXtP3qbTFmqulvNH3Ct7fTBq1ZzqwSsR2Pl+ 0nb9YYQncBkEgKCLX+VCHSqaQFKczVz407+A+wMZWOMrgpqZ8h/+zrFX/VB+y/aLSvM/ r/kw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i192si12072053pgc.380.2018.04.24.07.28.33; Tue, 24 Apr 2018 07:28:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932268AbeDXJtS (ORCPT + 99 others); Tue, 24 Apr 2018 05:49:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:47812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756519AbeDXJrm (ORCPT ); Tue, 24 Apr 2018 05:47:42 -0400 Received: from ziggy.de (144.pool85-56-49.dynamic.orange.es [85.56.49.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C1F8217BA; Tue, 24 Apr 2018 09:47:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C1F8217BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=matthias.bgg@kernel.org From: matthias.bgg@kernel.org To: ulrich.hecht+renesas@gmail.com, laurent.pinchart@ideasonboard.com, ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, sboyd@codeaurora.org, lee.jones@linaro.org Cc: davem@davemloft.net, gregkh@linuxfoundation.org, mchehab@kernel.org, rdunlap@infradead.org, pi-cheng.chen@linaro.org, sean.wang@mediatek.com, linux-clk@vger.kernel.org, linux@armlinux.org.uk, matthias.bgg@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger Subject: [v2 resend 04/10] drm/mediatek: mt2701: switch to mfd probing. Date: Tue, 24 Apr 2018 11:47:01 +0200 Message-Id: X-Mailer: git-send-email 2.16.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthias Brugger With the mtk-mmsys MFD device in place, we switch the probing for mt2701 from device-tree to mfd. Signed-off-by: Matthias Brugger --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index a48e28adad09..88ee35907744 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -386,7 +386,7 @@ static int mtk_drm_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct mtk_drm_private *private; - struct device_node *node; + struct device_node *node, *parent_node, *mmsys_node; struct component_match *match = NULL; int ret; int i; @@ -399,12 +399,23 @@ static int mtk_drm_probe(struct platform_device *pdev) INIT_WORK(&private->commit.work, mtk_atomic_work); private->data = of_device_get_match_data(dev); - private->config_regs = syscon_node_to_regmap(dev->of_node); - if (IS_ERR(private->config_regs)) - return PTR_ERR(private->config_regs); + /* Check if called from mfd */ + if (!dev->of_node) { + mmsys_node = pdev->dev.parent->of_node; + private->data = (struct mtk_mmsys_driver_data *) + platform_get_device_id(pdev)->driver_data; + private->config_regs = + syscon_node_to_regmap(mmsys_node); + parent_node = mmsys_node->parent; + } else { + private->config_regs = syscon_node_to_regmap(dev->of_node); + if (IS_ERR(private->config_regs)) + return PTR_ERR(private->config_regs); + parent_node = dev->of_node->parent; + } /* Iterate over sibling DISP function blocks */ - for_each_child_of_node(dev->of_node->parent, node) { + for_each_child_of_node(parent_node, node) { const struct of_device_id *of_id; enum mtk_ddp_comp_type comp_type; int comp_id; @@ -545,13 +556,17 @@ static SIMPLE_DEV_PM_OPS(mtk_drm_pm_ops, mtk_drm_sys_suspend, mtk_drm_sys_resume); static const struct of_device_id mtk_drm_of_ids[] = { - { .compatible = "mediatek,mt2701-mmsys", - .data = &mt2701_mmsys_driver_data}, { .compatible = "mediatek,mt8173-mmsys", .data = &mt8173_mmsys_driver_data}, { } }; +static const struct platform_device_id mtk_drm_ids[] = { + { "drm-mt2701-mm", (kernel_ulong_t)&mt2701_mmsys_driver_data }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(platform, mtk_drm_ids); + static struct platform_driver mtk_drm_platform_driver = { .probe = mtk_drm_probe, .remove = mtk_drm_remove, @@ -560,6 +575,7 @@ static struct platform_driver mtk_drm_platform_driver = { .of_match_table = mtk_drm_of_ids, .pm = &mtk_drm_pm_ops, }, + .id_table = mtk_drm_ids, }; static struct platform_driver * const mtk_drm_drivers[] = { -- 2.16.3