Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263170AbTHVMns (ORCPT ); Fri, 22 Aug 2003 08:43:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263167AbTHVMkm (ORCPT ); Fri, 22 Aug 2003 08:40:42 -0400 Received: from hq.pm.waw.pl ([195.116.170.10]:14745 "EHLO hq.pm.waw.pl") by vger.kernel.org with ESMTP id S263170AbTHVL4B (ORCPT ); Fri, 22 Aug 2003 07:56:01 -0400 To: "David S. Miller" Cc: Alan Cox , jes@wildopensource.com, zaitcev@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] RFC: kills consistent_dma_mask References: <20030818111522.A12835@devserv.devel.redhat.com> <1061298438.30566.29.camel@dhcp23.swansea.linux.org.uk> <20030819095547.2bf549e3.davem@redhat.com> From: Krzysztof Halasa Date: 22 Aug 2003 13:54:11 +0200 In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1159 Lines: 26 I think we should do it the following way: - adding pci_alloc_consistent_mask(..., u64 mask), pci_map_*_mask(..., mask) and DMA API friends - adding a routine checking if a mask is valid on given system - renaming existing routines to *_nomask and aliasing old names to them. then: - migrating drivers from old ones to _mask (the non-trivial part) then: - dropping support for _nomasks and then probably renaming _masks to old names. alternative, probably a cleaner one - using "int bits" instead of "u64 mask". Devices tend to be X-bit (32-bit, 64-bit, 28-bit etc) rather than to have 0xFFFFFFFFFFFFFFFFFFFFF masks anyway. And the dma_mask has to be continuous, right? The "bits" value is much more readable, too. Of course, moving from bits to mask and vice versa is easy, it could even be a macro. Unless there are objections I'm going to start with *_bits. -- Krzysztof Halasa Network Administrator - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/