Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Greg KH' <gregkh@linuxfoundation.org>,
        "richard.gong@linux.intel.com" <richard.gong@linux.intel.com>
CC:     "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will.deacon@arm.com" <will.deacon@arm.com>,
        "dinguyen@kernel.org" <dinguyen@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "atull@kernel.org" <atull@kernel.org>,
        "mdf@kernel.org" <mdf@kernel.org>, "arnd@arndb.de" <arnd@arndb.de>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "yves.vandervennet@linux.intel.com" 
        <yves.vandervennet@linux.intel.com>,
        "richard.gong@intel.com" <richard.gong@intel.com>
Subject: RE: [PATCHv3 3/7] driver, misc: add Intel Stratix10 service layer
 driver
Thread-Topic: [PATCHv3 3/7] driver, misc: add Intel Stratix10 service layer
 driver
Thread-Index: AQHT2vs1AB82BfsnT0OWFRPGgC8BI6QPx4Og
Date:   Tue, 24 Apr 2018 11:24:52 +0000
Message-ID: <9498165854b84321801d8186d3040b1e@AcuMS.aculab.com>
References: <1522182014-7338-1-git-send-email-richard.gong@linux.intel.com>
 <1522182014-7338-4-git-send-email-richard.gong@linux.intel.com>
 <20180423120300.GC7951@kroah.com>
In-Reply-To: <20180423120300.GC7951@kroah.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-Authenticated_ID: 
X-PolicySMART: 3396946, 3397078
X-Virus-Status: Scanned by VirusSMART (c)
X-Virus-Status: Scanned by VirusSMART (s)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Greg KH
> Sent: 23 April 2018 13:03
> On Tue, Mar 27, 2018 at 03:20:10PM -0500, richard.gong@linux.intel.com wrote:
> > +config INTEL_SERVICE
> 
> Naming is hard, but this is a _very_ generic name, don't you agree?
> 
> > +	tristate "Intel Service Layer"
> 
> As is this.  Can you make this a bit more specific to what hardware is
> being controlled here?
> 
> > +++ b/drivers/misc/intel-service.c
> 
> Same for the file name, why not stratix10.c?
> 
> or intel_svc.c?  That makes it a _bit_ more generic.  Well, not really,
> but it does hide the "genericness" a bit more, right?

It'll all be even worse if (when) Intel decide to sell Altera to
someone else.

	David