Received: by 10.192.165.148 with SMTP id m20csp4734836imm; Tue, 24 Apr 2018 07:36:49 -0700 (PDT) X-Google-Smtp-Source: AIpwx49uGuAZxax4tf9eDfMGH3ENMNiZOIMauIAesiEzO16mdWS5hqkobDucNmXBUC8F0LhVt/fI X-Received: by 10.99.123.93 with SMTP id k29mr20512467pgn.249.1524580609923; Tue, 24 Apr 2018 07:36:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524580609; cv=none; d=google.com; s=arc-20160816; b=UlPvZfVHOBTYleS2tCTd2UZAgHYuGpm/CVgfj18ik+FISYDgULTXTvSfTDEU/7YAtD RlrQy7hulz7kOn9U0xoscD89YoNBHPDTmg0xLYtlGs2SHuYgxyzJuSibf6pnhAhkVB5J R3gWND7CyxRc+V047ZTMQulgRwhQzRZ6QBMDl1havggI9OL5D/nGNxrya643MrjHksqQ 6QT2yKALbwIQrPVxd0gPEbw6FPgVkEhSDbF1pLlCtG+Ug5pQeKUu6HeyX8EA0jcmnXVX 1rEw0i8UGce6S4SATFbJcIPs6ayKSj/yZ9vz4rUrEcWoVdKjoVyaO/8/SEWB6ralw9Bd sLXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=tAAoHQRmCJ/joHSBw0HYBODJ1GxX/Zz1rb7qwTtBHNs=; b=nozadXJYGo6j2FRNE6SyCJKKSa4nRfE/UXl5kbq2HTCk5ot8c1oP67ohO/Zxfupr9m TcGQvR35mQH3Y5fkWMRnSpjuUl3EIqbvLFSqLHu04awlB0DmaUwbFxBIujgDxChCdDvq KrmzUPchNIspMM4hAvRU0Va2joFivVt4SFvuvg0yOCIw2Y9Nx94BRxVpL3ABz0fb5AAs HBecojKredLBgfgp9xXtarmkbdcebR+5e5310IqfP9KODQ7ik7oCNReKJLgcZArrAtmU qDkkUHCPH2UUPJ7fcWpyMtwvHTk0FwODBsKNSfxuByO/819VttNkPXtFAmsnoD1OuegL Ibuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=c5x9iYLZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m9si5660170pgn.665.2018.04.24.07.36.35; Tue, 24 Apr 2018 07:36:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=c5x9iYLZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933474AbeDXNPM (ORCPT + 99 others); Tue, 24 Apr 2018 09:15:12 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:55836 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933415AbeDXNPH (ORCPT ); Tue, 24 Apr 2018 09:15:07 -0400 Received: by mail-wm0-f67.google.com with SMTP id a8so892760wmg.5 for ; Tue, 24 Apr 2018 06:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=tAAoHQRmCJ/joHSBw0HYBODJ1GxX/Zz1rb7qwTtBHNs=; b=c5x9iYLZcolPB0RC0mY2yeTolJrf9P4hV+U9Lc+DPd40ZGGKxMy7zjTMQ6y2n4SRiK 0g5C+cNgWMS5vUQc5gySotUSHOrfqbijKAS2UvMV/pukvNwOtc8Jh40PPBdN3wUMK7hv xjBHD0OB5Ak9OZterwkW82cqSR1AXRytfjwJiaLS+JZ3XnFRG6urP8Tg+6bXWp0krye+ M+TKyAxLjZh27hxmzhFCey9gl0YRPCUzUhE7ECKZbopciwB0knAqmUeJ2yAh5/WckLUu cZbPz9ERBEm4HHGG3vey/82lnpeAYpp5UDWajCfy9hchf/3TxAcs2P5fYhJ/ds59yRox pVhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tAAoHQRmCJ/joHSBw0HYBODJ1GxX/Zz1rb7qwTtBHNs=; b=rrBIZkiPKXH1iPWFOisZmOJ/rUsZ1L1m+o+CNX5kDCWbG5f7L6q6yay7Kun+IBEPjA mMxk/5hZUaUdTF2cTH+W4HsJ8zbOxfJWfc5MnvCsYS8MZx7NFNoCSupR6JKnO5jkHo7w Nu9UAW40tq/r99GePSWUJ7a9Weu8mb2qCZUObyfWnI1LQN78SOwvKZ6y+N0gytJdsRv7 5+yprbwqE5s11V6vQZ1k2htvskgQ/vrZyuCFZ7DaSS01ByZZyXl7LR13Deqi76aOslEO bqEcCwDAMS7iP2zS+kda+rfLFFx3FeVNbLx1VLKe66QkNHRVqHhnFyaG6zBQJhJtx7RI ToVg== X-Gm-Message-State: ALQs6tDxxZASMbQPPB1aJrjmRauQO5vLtQMEyghgnZlWF8xA1k6fPHBz 0PH+UF41QGtPX7wOqtzwJj7sI+5mNac= X-Received: by 10.80.157.202 with SMTP id l10mr33438134edk.192.1524575705928; Tue, 24 Apr 2018 06:15:05 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id p21sm88813edq.33.2018.04.24.06.15.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:15:05 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , Xinliang Liu , Rongrong Zou , Xinwei Kong , Chen Feng , David Airlie , Shawn Guo , Neil Armstrong , Maarten Lankhorst , Daniel Vetter , Archit Taneja , Keith Packard , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/hisilicon: fix mode_valid's return type Date: Tue, 24 Apr 2018 15:15:02 +0200 Message-Id: <20180424131504.2159-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method struct drm_connector_helper_funcs::mode_valid is defined as returning an 'enum drm_mode_status' but the driver implementation for this method uses an 'int' for it. Fix this by using 'enum drm_mode_status' in the driver too. Signed-off-by: Luc Van Oostenryck --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c index f4eba87c9..d2f4749eb 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c @@ -27,7 +27,7 @@ static int hibmc_connector_get_modes(struct drm_connector *connector) return drm_add_modes_noedid(connector, 800, 600); } -static int hibmc_connector_mode_valid(struct drm_connector *connector, +static enum drm_mode_status hibmc_connector_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { return MODE_OK; -- 2.17.0