Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [regression, bisected] rockchip rk3399 video output breakage
To:     JeffyChen <jeffy.chen@rock-chips.com>,
        linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>,
        linux-rockchip@lists.infradead.org
References: <3beabd18-0c39-be65-cfe7-8498dc7c296b@theobroma-systems.com>
 <5ADF24F3.6070106@rock-chips.com>
Cc:     klaus.goger@theobroma-systems.com
From:   Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
Message-ID: <fdd0fe29-2117-c67b-5dba-5d1ab0b19dd1@theobroma-systems.com>
Date:   Tue, 24 Apr 2018 15:11:26 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <5ADF24F3.6070106@rock-chips.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 24.04.18 14:37, JeffyChen wrote:
> 
> right, i think it's a known issue, as the iommu failed to get clks:
> [    1.525153] rk_iommu ff8f3f00.iommu: Failed to get clk 'iface': -2
> [    1.525316] rk_iommu: probe of ff8f3f00.iommu failed with error -2
> [    1.525484] rk_iommu ff903f00.iommu: Failed to get clk 'iface': -2
> [    1.525643] rk_iommu: probe of ff903f00.iommu failed with error -2
> 
> 
> there's a followed patch to add those clks to the dtsi, and also a fix 
> patch to make those clks optional(by heiko):
> 
> https://www.spinics.net/lists/arm-kernel/msg645696.html
> 
> http://lists.infradead.org/pipermail/linux-rockchip/2018-April/020349.html

Thanks, I tested both, and both get the screen to display some kernel 
output!

However, I am getting some nasty error messages and the screen seems to 
refresh only once every 30 seconds:

> [   15.586502] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CRTC:30:crtc-0] flip_done timed out
> [   25.826490] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CONNECTOR:37:HDMI-A-1] flip_done timed out
> [   36.066490] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [PLANE:28:plane-0] flip_done timed out
> [   36.066504] [drm:drm_calc_timestamping_constants] crtc 30: hwmode: htotal 2200, vtotal 1125, vdisplay 1080
> [   36.066508] [drm:drm_calc_timestamping_constants] crtc 30: clock 148500 kHz framedur 16666666 linedur 14814
> [   36.076535] rockchip-vop ff8f0000.vop: [drm:vop_crtc_atomic_flush] *ERROR* VOP vblank IRQ stuck for 10 ms
> [   36.076577] WARNING: CPU: 1 PID: 83 at drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1004 vop_crtc_atomic_flush+0x1c0/0x1c8

Full dmesg with patch "arm64: dts: rockchip: add clocks in iommu nodes":
https://gist.github.com/jakob-tsd/3fd49894d52dcd8a409eb9e6136b2d39

Full dmesg with patch "iommu/rockchip: make clock handling optional":
https://gist.github.com/jakob-tsd/da96572a40d11f0f6dff3ee481098138 
(looks the same)

Thanks,
Jakob