Received: by 10.192.165.148 with SMTP id m20csp4735566imm; Tue, 24 Apr 2018 07:37:32 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+EV2VZtG57qX1dxoAAXWFCDPMNdIjOCXY3vyxrFnwnSJcGOOMhiNHVlZL2bYJEK9CEukaD X-Received: by 10.99.54.136 with SMTP id d130mr16131747pga.228.1524580652231; Tue, 24 Apr 2018 07:37:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524580652; cv=none; d=google.com; s=arc-20160816; b=f9MV0DotzMxR1bw8X6y7kZ5AUQgR402gkISAKgWQNDoHqqmOsNpeNFaaH/o8HHv1i0 M42JRnKdPCwc2g6JKDHZ3mX2Z/kUOJ/2kAnwbGGowhp+HDoxnZf5aAiKt/QHAmKTsgwQ E4cL0MhDHfuqzFODzi5jW0S8APgW3iwI0hQMaqCHLwEUni1doYmKzSDWQT7yhHX8pyzk cJ115DdtoQbdG3/P1WiyMvLSM12N8jRgBtSA3oKR65yX4p1x/lLGDQydW7BRnMfokneo 4q1HTLsuHxCugkKAZMBffixsVu4YmcsHsikaFcfm3J0vS5JC41U+V4BLH8ePEw60zINq ZYyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:cc:to :autocrypt:openpgp:subject:from:arc-authentication-results; bh=glhqiW1wdYGQq7dqnwGnY3J9NzCLvF7jPE95iaTl7Zk=; b=bX+3cGhgx54CK7YSFAQpd74Nk702Ymnmp1UxVVcb6OA5sQNEa+M6oVCxJYDLrX+vks UOU80/cn+RgwAeDmQlpKjsbUVa0NbcCwmEzNM58muaihN9h6qZ/8Cgt/PtfsI5R0BX/o WGqoIupBXZeJIBq0lXFhge2w0KTLK4urOgWeoWjb+GD/ZIXPy5jRil5CqStSJ4fV/AEf 6hKvQpU+4lIwtOa6skpy5Ei2PK5qKUPm7eBIEnsq1WtIEtDRHpLHklkKmeP4HKHLRWuk Ksogmn0VEaLDTpHAtrhJGuylUsqCB6XPHqXV5lzzFlPDCDuiKTNgtra+7gWQGJTPNjt9 CO8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g14si6921156pgu.363.2018.04.24.07.37.17; Tue, 24 Apr 2018 07:37:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933382AbeDXNOV (ORCPT + 99 others); Tue, 24 Apr 2018 09:14:21 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:52061 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757375AbeDXNOO (ORCPT ); Tue, 24 Apr 2018 09:14:14 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1fAxli-0000Y3-Rm; Tue, 24 Apr 2018 13:14:02 +0000 From: Colin Ian King Subject: re: media: rcar-vin: add group allocator functions Openpgp: preference=signencrypt Autocrypt: addr=colin.king@canonical.com; prefer-encrypt=mutual; keydata= xsFNBE6TJCgBEACo6nMNvy06zNKj5tiwDsXXS+LhT+LwtEsy9EnraKYXAf2xwazcICSjX06e fanlyhB0figzQO0n/tP7BcfMVNG7n1+DC71mSyRK1ZERcG1523ajvdZOxbBCTvTitYOy3bjs +LXKqeVMhK3mRvdTjjmVpWnWqJ1LL+Hn12ysDVVfkbtuIm2NoaSEC8Ae8LSSyCMecd22d9Pn LR4UeFgrWEkQsqROq6ZDJT9pBLGe1ZS0pVGhkRyBP9GP65oPev39SmfAx9R92SYJygCy0pPv BMWKvEZS/7bpetPNx6l2xu9UvwoeEbpzUvH26PHO3DDAv0ynJugPCoxlGPVf3zcfGQxy3oty dNTWkP6Wh3Q85m+AlifgKZudjZLrO6c+fAw/jFu1UMjNuyhgShtFU7NvEzL3RqzFf9O1qM2m uj83IeFQ1FZ65QAiCdTa3npz1vHc7N4uEQBUxyXgXfCI+A5yDnjHwzU0Y3RYS52TA3nfa08y LGPLTf5wyAREkFYou20vh5vRvPASoXx6auVf1MuxokDShVhxLpryBnlKCobs4voxN54BUO7m zuERXN8kadsxGFzItAyfKYzEiJrpUB1yhm78AecDyiPlMjl99xXk0zs9lcKriaByVUv/NsyJ FQj/kmdxox3XHi9K29kopFszm1tFiDwCFr/xumbZcMY17Yi2bQARAQABzSJDb2xpbiBLaW5n IDxjb2xpbi5raW5nQHVidW50dS5jb20+wsF3BBMBCAAhBQJPCrjvAhsDBQsJCAcDBRUKCQgL BRYCAwEAAh4BAheAAAoJEGjCh9/GqAImjVsP/iA8hDQy7LlMYepND9tKJD2haNLmsBC+yuxX BybYprtSjwvMbx6CtmtiJ4nGfdBzbZv3xOJPr/n6wxrdfGHEFn0W8Au97Xvk087P7alCwBXz y1Hk1aTlhLOGunOLv6SWRYRUAHvWEoVlxPSo2UNJ6D01d9tc7IJU08MlAl+u048S6625G5SG tfOJpFyGqaWGazMpkYdbJuY9acNAQAl1GzZPDCyLrxaBJypqmp3W+rb7m9arNRMlygevFU6e UGrR7QiVuumTGebGF9D63H9LD0E/1EhOA4QWHq1/u7CXLr9qo1YyAUtYAICs0wyRbI6wWPyi 5IyOTiWCVP3qSxV4JR8qq8JhGEwxS5fEB76r+XGxcL7qqiQmVx3bkjlT6FnnanPcD7RsMOAg NcpeftVsqignFPA3XHaDeew4t99ef+wKwiiyU7jqduvSt8amLVip5dxN1TYKqWPauIHL3E2A KIKuqsZ9ftUJ3NXClAfI3EHPMYbok6b04nZSWmBttKHr8YkVF5b4jrabMLlVoCg+DGYffyDS YDwy9FPvJWkt6nffUXciearieSlHEt3f12CPp6OOR8yFZWlISYKdD9PDzXP9kJYTEWnr7dD3 feEZK+J9N5wpCU7HvfrA5HCOMJgf8Dcfscrj9H2Qp8vbErMP7jZ6OYapCOV5MZS6W57wlG2k zsFNBE6TJCgBEADF+hz+c0qF0R58DwiM8M/PopzFu5ietBpl0jUzglaKhMZKKW7lAr4pzeE4 PgJ4ZwQd0dSkx63hRqM963Fe35iXrreglpwZxgbbGluRJpoeoGWzuUpXE6Ze0A2nICFLk79a YHsFRwnKyol9M0AyZHCvBXi1HAdj17iXerCYN/ZILD5SO0dDiQl570/1Rp3d1z0l16DuCnK+ X3I7GT8Z9B3WAr6KCRiP0Grvopjxwkj4Z191mP/auf1qpWPXEAPLVAvu5oM7dlTIxX7dYa6f wlcm1uobZvmtXeDEuHJ3TkbFgRHrZwuh50GMLguG1QjhIPXlzE7/PBQszh5zGxPj8cR81txs 6K/0GGRnIrPhCIlOoTU8L+BenxZF31uutdScHw1EAgB6AsRdwdd8a9AR+XdhHGzQel8kGyBp 4MA7508ih0L9+MBPuCrSsccjwV9+mfsTszrbZosIhVpBaeHNrUMphwFe9HbGUwQeS6tOr+py bOtNUHeiJ5aU3Npo3eZkWVGePP2O4vr8rjVQ1xZMIWA18xUaLTvVSarV7/IqjLb0uMTz6Ng7 SceqjsgxO4J35pPOCG8gy85Tmd5NKe46K1xGsNG2zzfXQ6cNkofUyQFGVbLCtdfQyWV7+dgU nOnPhrTKpFfJ5lnWpLpze0LfyW03CpWx9x4yMlwcvIFw2hLaOQARAQABwsFfBBgBCAAJBQJO kyQoAhsMAAoJEGjCh9/GqAImeJYP/jdppMeb7AZnLGVXd8rN7CLBtfMOkXCWaOUhjMRAY7dV IMiF1iPZc6SgiiMSsdG7JJhMjMuLTxA0kX2Z6P0+6dZlO4bDOKMIv4nNGhgSj9NuSKJPRiyi XKKD/wNnPXVFdBZsoHnEXGyAFGnidu4KLUJIiSm4tHJdoMk0ZaJSmwt0dtytuC1IWH8eIaVo /Ah6FxCaznRzvGNFx+9Ofcc7+aMZ15dkg9XagOuiDZ1/r6VuEw9ovnkDT4H5BAsysxo/qykX 4XQ2RQSY/P3td9WNLeXLvt1aJNRcwcIEKgZ5AO3YQbEJt1dEfCU7TAKiRpsjnC/iQiQHGt2I vNci8oZmM3EQEi7yZqD07A6dpGTnRq9OQ7fGhj0SS99yZvooH3fBIHA2LRuvhfDAgTrpbU0w LvkAIo0T2b9SoRCV8FEpHvR2b86NbTU5WN4eqZQbAbnxC7tJp6kLx2Zn2uQMvfXRfnS9R1ja etvpk3h7F+r/RAAh+EvgsPUNaiRJRRLvf9bxTQZhmNrw79eIFNsRIktniLyomJf2+WPOUECz h1lfLqe9yiuUKv+m5uAalXdayhiPbp/JHs1EDRgSq3tiirOsKrh/KMpwz/22qGMRBjFwYBhf 6ozgujmPlO5DVFtzfwOydzNlXTky7t4VU8yTGXZTJprIO+Gs72Q1e+XVIoKl3MIx To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Laurent Pinchart , Hans Verkuil , Mauro Carvalho Chehab Cc: "linux-kernel@vger.kernel.org" Message-ID: <12ca5ca8-a582-5899-6dd5-c064e4b54e2b@canonical.com> Date: Tue, 24 Apr 2018 14:14:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi there, While running static analysis on linux-next today a null pointer dereference issue was detected by CoverityScan. The following commit introduced the issue: commit 3bb4c3bc85bf77a76c921671800bde2e1bf82a88 Author: Niklas Söderlund Date: Sat Apr 14 07:57:18 2018 -0400 media: rcar-vin: add group allocator functions The analysis is as follows: 339 static void rvin_group_put(struct rvin_dev *vin) 340 { 341 mutex_lock(&vin->group->lock); 342 1. assign_zero: Assigning: vin->group = NULL. 343 vin->group = NULL; 344 vin->v4l2_dev.mdev = NULL; 345 CID 1468359 (#1 of 1): Explicit null dereferenced (FORWARD_NULL) 2. var_deref_op: Dereferencing null pointer vin->group. 346 if (WARN_ON(vin->group->vin[vin->id] != vin)) 347 goto out; 348 vin->group is NULL however the WARN_ON is dereferencing it, causing an OOPS. I don't know how this should be fixed, hence I am sending this bug report. Regards, Colin