Received: by 10.192.165.148 with SMTP id m20csp4735872imm; Tue, 24 Apr 2018 07:37:48 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+SW00oH4k6Bhx3Guskj8soeu3tIjKznaGn1af2cTQO0dsyVSpbBS11nRQML/18MnRWWsbf X-Received: by 10.98.70.155 with SMTP id o27mr24030241pfi.124.1524580668555; Tue, 24 Apr 2018 07:37:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524580668; cv=none; d=google.com; s=arc-20160816; b=h6XI/hh7rgQUmnub4LBP1h5xzGdueF/ovmnvs38WEujq3xxGmBeZI4uoCx3SmCmikt nUOF6ndigr+8thYFOiIOG3I/jtbVTqm76RH96xgJNfg7y4GQDOpeTrG6tSCJki5aMcLJ I0SeeUmHsXrU94f5l2u2vqPXNmntuIrbZV+M5PFoFY/lxCv5SvTA3nnlo3oxarmuBula rRTdHDMTCCGi8kAnbb6XljKtaalOSgj4GOudICZvuxjlkT8nuKE+YVtW8ChyqsgW3Qw1 OhLTn5fJht7FEW36qXG0yeikZajvKUyAFeKzW9RuSi+GBwT0YcBb3DZGQ8hWleM3N1ny 5ITg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=mTpDh0WuPFgVgUWxezhkJ+aejR3skuKrG6ec0EIJ68M=; b=JUN5gX+1juSd2VzxIHUZS7mzsAqIOQmNTdpQrj60EzuJszMEvsf5w5jviLbSTQbqRn Fkrxw4/mjKrCxRFAUx0hZb97bZMdIwXw0pVj0ZibhSaVW6ly43sTXm16U2os6TdVQcI/ iGp7Gu5s5lyFqP6O+QGXHq/iN+k7Cb4JBVBimUlxxTREV82zxJh9iOQ+DLOJS9hGRluV YzTiWndVgrPDCj47o6M59UB6zdf0bU/zStF1Hw2NzJwSOQUgWQS6PB9drKTNbGa1yuYO q+iQb3n3Qh8z3DHlJGq/tT+WVvi8xwcBYi/1as0YGVGHRrSEWE7roTfffeI+BgWQ0/qz pzIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EheQWSn5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m9si5664446pgn.665.2018.04.24.07.37.33; Tue, 24 Apr 2018 07:37:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EheQWSn5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934077AbeDXNSl (ORCPT + 99 others); Tue, 24 Apr 2018 09:18:41 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35293 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933911AbeDXNSg (ORCPT ); Tue, 24 Apr 2018 09:18:36 -0400 Received: by mail-wm0-f67.google.com with SMTP id o78so811903wmg.0 for ; Tue, 24 Apr 2018 06:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=mTpDh0WuPFgVgUWxezhkJ+aejR3skuKrG6ec0EIJ68M=; b=EheQWSn5Ap0qZK5tBIVd6mGf2D66oLTnMGV3sfrd0J1coXpS5/Gvdi12x1EKZelCrZ eFfm4NRw/d5hVjN51u1Q5Bj3EamCL/kiN11rRQpj08VGEspEYWD/CIytFW3N8t/qeT/F w+xJ07ekBdVPYFrdPiM19V99wrxbKn2S2etvOHp8trb3UXYTt3McPsqH4IU0NplVqwyO 1n1HFIMWAlzlgV6GNuUgB2YpllBTe441LlzuWZ6klmalMWKB+TCJAmvH0tmZ439grDdM wB+8IyGVsQ0FEMDaZSCpglImOix2wvZOtvZiPvdkn3hoDgV9zDvbd2WQy2yTrTnD1/0g dI/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=mTpDh0WuPFgVgUWxezhkJ+aejR3skuKrG6ec0EIJ68M=; b=rRIHkNH/tKvY/Nxqmj22ftoQFbvujrwO7xC+54K6xHd2zxPIVDsbVD3fCYjLQ9G7IQ 9PVIsQiJ1ghWf/ol92XmMYnxIeU45OBS2zu3jIjjPrEGQbG7aX2v7g2ESLBY+0Z8Rzkf MH1T/lSJT4YQ6rPh9nZahSKUmrPGub3FLBLjTTwXXuPMvP91ttbJiSNjKXRMofbWe4rB QvxiJzugRC3cuKYSWUj3db3q1I7FE7AUAMdNe1OF3vBU4Kjho5JHnjT/ac0tdjc4ZxU7 WcPZqcBWeN9OIXDMXzPxy7RJ3hYeOAc3MLfSqfiz206sCxzv52RN7LxIlLsL/5rHlf4s uy6Q== X-Gm-Message-State: ALQs6tAWvqqUFjH9D87CJ1TcGNLLj11WZCnTmTNRS4jAe9jIT/HPHJ78 o6TeZ5qQHmp3NSTYdYR30RUsalOivO4= X-Received: by 10.80.204.8 with SMTP id m8mr33352073edi.116.1524575914764; Tue, 24 Apr 2018 06:18:34 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id p21sm93283edq.33.2018.04.24.06.18.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:18:34 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , David Kershner , Greg Kroah-Hartman , Tim Sell , Sameer Wadgaonkar , David Binder , Charles Daniels , sparmaintainer@unisys.com, devel@driverdev.osuosl.org Subject: [PATCH] staging: visornic: fix visornic_xmit()'s return type Date: Tue, 24 Apr 2018 15:18:31 +0200 Message-Id: <20180424131833.5266-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/staging/unisys/visornic/visornic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c index 92dceb557..f734e835b 100644 --- a/drivers/staging/unisys/visornic/visornic_main.c +++ b/drivers/staging/unisys/visornic/visornic_main.c @@ -849,7 +849,7 @@ static bool vnic_hit_low_watermark(struct visornic_devdata *devdata, * * Return: NETDEV_TX_OK. */ -static int visornic_xmit(struct sk_buff *skb, struct net_device *netdev) +static netdev_tx_t visornic_xmit(struct sk_buff *skb, struct net_device *netdev) { struct visornic_devdata *devdata; int len, firstfraglen, padlen; -- 2.17.0