Received: by 10.192.165.148 with SMTP id m20csp4736122imm; Tue, 24 Apr 2018 07:38:03 -0700 (PDT) X-Google-Smtp-Source: AIpwx48X20YGAHGt038+yl3Eos0kk+gTMnQvWo6TXyqMZvin2pdrir3MVZLJTBt3oEbvkBWxCKWU X-Received: by 10.101.72.140 with SMTP id n12mr20717632pgs.155.1524580683827; Tue, 24 Apr 2018 07:38:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524580683; cv=none; d=google.com; s=arc-20160816; b=tJP0lWv32XgaY9jtkGBx8FpljrZtq7nYhQWTAB685YlCJ5ts1bB2ivmaLrQoNzYWgS SEk0SoYh5wQpfRD1oFC0V5Fp538ozBxWZNPUivRKbPonlssArOYxvDU8ZeHGTc+1j36o /f//2YyO5A5/P0SpbhLeTdC5MUXSwGUEbbn68o031VxpYxWeSogr97dZn1kj8wgo2hBn qIh1D70JEjLZD25xuBpJyI0myUlyZmUxdyOeqeLpy99sn4drsmngFkY/g+HpQ6gyf5R3 jujpuhe/614cHH75uSTYYv8UzneY6gSC9BF4lYZFj3Ct91b29BNDsD0NpzeI/qmA9Ka5 gquw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=IkL8CXFZq80mNwMt3PPQNp15Dj7Mz1kPVBEFquMT1cg=; b=ACfLtnLIWOYEDPViL3vh6VToC2gag4t8m3BdCptiuMYudgv0hK1tumTQfuEt3j4pP8 bXQNvVHuOvvcyeZWey5f3PrnPjASzCaloN4Zo24FNEhwlRKTf5g2seaiXdMZiaZkgNRH BgKvSSpP5qXhhoDIQntoQxFChw8xNq5MT0Qj+vPI7PyLmrKmiF6fbh5jOKziEulbWb6o ESpHBsNOY1VDc5s0jhD1c9EqTjg4SpsVqnLL/TduO2BeYv4krznPWSTzNU/pAho1PxFt VIH65SEvichYaDrkAWCkl4NhMJCmHCDhVxDAFOYrhZMZUb5Z2i+xvPhLJhX816GWU+cS Ue2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HcuKoJWp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6si11611166pgq.321.2018.04.24.07.37.49; Tue, 24 Apr 2018 07:38:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HcuKoJWp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758033AbeDXNYi (ORCPT + 99 others); Tue, 24 Apr 2018 09:24:38 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:51680 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934122AbeDXNTA (ORCPT ); Tue, 24 Apr 2018 09:19:00 -0400 Received: by mail-wm0-f67.google.com with SMTP id j4so921735wme.1; Tue, 24 Apr 2018 06:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=IkL8CXFZq80mNwMt3PPQNp15Dj7Mz1kPVBEFquMT1cg=; b=HcuKoJWprSQhUgLLMkJq351fPrxpR/dKfEc0gOMmOIDC9e2JlWPieNYHdQnrwcY091 xC68fIXamaYClEIZUXptQ1w5u+7zdevpLsEJeWhSnRUxZ95YQnZJmDGuweWxgFjhotYm bZnFOaVzUQ8smLZOZWrrrj7Da7u4cQdsX4PmqxFGDEdbWAJ0K/nAc7EDTZP7WOgSQYHK BqZDn9Smes2Q25sM5s3dqvdlZQlXbr4Gaxi4ZkEOuomrHpFryh+pAjPURKmJRxomxds7 pjZlHkvm9WoarUc4XZTld6SipRRn/5SDXnCtp160S2tQiuO2sqAEl6i9SbiMwRp/V9gK MNJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IkL8CXFZq80mNwMt3PPQNp15Dj7Mz1kPVBEFquMT1cg=; b=S6JtNBs/n5wR8MEA16nUIHmK9fmbklgkkqsddtHFCHQYU9LQC7AXqK8z1ioDfCRPLn w8iUlGQqJzEHX8P/qPmK0hXlZxQT9weWvdzjzX/jTWdSLIDNWhKcqHdZwJKiEqZviaTT mswyCNJYjqJis50P0m45R4pTeu8lFqZE9YuUeVDDkZ/rOLCB3VQkl3Xx1KBYuR7Ew6lJ 3CTh4SrAS4CCAAwxYyH11ZxQ/e+lrOy6RM6uVuVWBsuVuOgm7jJ1VKRyPiiS7LXWFaah Q4IKRRJzE2+SaingM/zMN9dzeC3DcR9Bopg2BZ0yoSUCtjr5R2gHbHMrv8xzb7Yz3mQ0 GeWA== X-Gm-Message-State: ALQs6tDWtQNIAhOF9u/X2+BwrvNxTCZtJla0iJzb4DNQqcbQgCRw5Nhh AAlHjT1jZ7SGew/MxMPVLa7hMYi1CbQ= X-Received: by 10.80.241.93 with SMTP id z29mr33260751edl.62.1524575939021; Tue, 24 Apr 2018 06:18:59 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id x29sm9376934edm.26.2018.04.24.06.18.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:18:58 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , Aditya Shankar , Ganesh Krishna , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org Subject: [PATCH] staging/wilc1000: fix wilc_mac_xmit()'s return type Date: Tue, 24 Apr 2018 15:18:57 +0200 Message-Id: <20180424131857.5668-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 38a83bd31..e06aaed5e 100644 --- a/drivers/staging/wilc1000/linux_wlan.c +++ b/drivers/staging/wilc1000/linux_wlan.c @@ -941,7 +941,7 @@ static void linux_wlan_tx_complete(void *priv, int status) kfree(pv_data); } -int wilc_mac_xmit(struct sk_buff *skb, struct net_device *ndev) +netdev_tx_t wilc_mac_xmit(struct sk_buff *skb, struct net_device *ndev) { struct wilc_vif *vif; struct tx_complete_data *tx_data = NULL; diff --git a/drivers/staging/wilc1000/wilc_wlan.h b/drivers/staging/wilc1000/wilc_wlan.h index fa157a67b..d3b5a6b38 100644 --- a/drivers/staging/wilc1000/wilc_wlan.h +++ b/drivers/staging/wilc1000/wilc_wlan.h @@ -298,7 +298,7 @@ void wilc_chip_sleep_manually(struct wilc *wilc); void wilc_enable_tcp_ack_filter(bool value); int wilc_wlan_get_num_conn_ifcs(struct wilc *wilc); -int wilc_mac_xmit(struct sk_buff *skb, struct net_device *dev); +netdev_tx_t wilc_mac_xmit(struct sk_buff *skb, struct net_device *dev); void WILC_WFI_p2p_rx(struct net_device *dev, u8 *buff, u32 size); void host_wakeup_notify(struct wilc *wilc); -- 2.17.0