Received: by 10.192.165.148 with SMTP id m20csp4736597imm; Tue, 24 Apr 2018 07:38:28 -0700 (PDT) X-Google-Smtp-Source: AIpwx49EyfFuD3leP7rlq1gshHG8e3IDAvs8OEByxK7L/ca1k2zBSKUUqQ413NXIRtNWTuTDWPNR X-Received: by 10.98.83.199 with SMTP id h190mr24148952pfb.146.1524580708096; Tue, 24 Apr 2018 07:38:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524580708; cv=none; d=google.com; s=arc-20160816; b=AcheuLtoovA+sSa6HEPAKhCgwspSxNFJCYDfXyavTNtXmygnb6OW/QfDCN5p0X7VzY VanNGG3wZqiy8ulYDV4c5JFH1H6lSWXJDIL0r0plvCL08iwQFZc38AqCVTW8K4htJDYJ 8v76Q0s3+GI4YxQdoox+YdfcuZZlMw7KXQNdKQjWusvWE5dSesU3B+T0Z7ua7Og1HxsA 0qgevDwBVlq7B5/L4x+owXD5gqBueNATBNNfNduRABZwUDBGrZ6prl26olTZlvXqcX9i Mkw7vT0yjqjntgt4bX6RpnlmDikmoMedPJOGcCM7QcuJ5SxCOfGlbB5ELlUfq2k5lRXY e27g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=fL52aOmUVQ5qo6+k633d5mKZiejYkN6w8hWuNCNNFtY=; b=SYlSrbMXHTs/uk1PYR1csJ4C9CObKXxCrfv1AyVjP1GeCKBnusY218kZgtkXAb4YD4 qXdPBYHNMVUFK2sEyv/caV6zOZ/osutj3GTeX9acI/DrzJliKY07GF7DPqp3ep+qT08r 7mkVrsSunIv1WQiY/U7Ptf+brZJ6rq/qKJCqTAi6Mp0+408C1uJ8C8spsjlsKbMB1bGz uSSziA0Ju7LS9OzjimzYgyo1RE4+d75bPOV8WzIIeRc+KIu7wXd1aF5b/gxGT6cE/e/A arGNAyUZ3/IMsMPAR1FhyFQD/YkpaJlaCvFvmPGB/SJA/KWYo6xx5AZm4zoYJsWXTO1j DBLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vYK141wK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h10si11625243pgq.514.2018.04.24.07.38.13; Tue, 24 Apr 2018 07:38:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vYK141wK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934063AbeDXNSd (ORCPT + 99 others); Tue, 24 Apr 2018 09:18:33 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:54963 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934011AbeDXNS1 (ORCPT ); Tue, 24 Apr 2018 09:18:27 -0400 Received: by mail-wm0-f65.google.com with SMTP id f6so910113wmc.4 for ; Tue, 24 Apr 2018 06:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=fL52aOmUVQ5qo6+k633d5mKZiejYkN6w8hWuNCNNFtY=; b=vYK141wKm4SJJJV1Q+0wRCDcAMCO6XApkmES2ut8uekRnFwsm+367/FnCQRuoh1Qhg PmBxEDUize9WSwABohHKLUzTsH68FwE7K8jmVXZK8Urg2sZmaSjM0b2e+B29pfbcg/Vz OsfRwKYQu3fOx2YFuBCtG1pJT9jVBRj8KCLHk70GKpbrC98yMBhRrO1pqXOz/N5Nz/93 ghgP4s9curNRtFeA2ork/tngo4uaNwKm9RXNFBfeuWk7r/TINGq7KpfTcujlD9QmozC/ OfIM+hFvUuURGLMAwis9ziH+gfMKRJSIiVMME7GMgWR0nutmaEuwpQoPKiXvUs6FQYk8 fI1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fL52aOmUVQ5qo6+k633d5mKZiejYkN6w8hWuNCNNFtY=; b=hS7DpvDXVqXNDvt3IrDn1xM8SrGwEacz9mSs5Pn0vGD1o9UZUW7exBaAhSdAuKpE+s NGSww65qgvj/TpWOjW2USUNs9v86cdZUi+YlSioFYsMz0xtD5N+P/spcjiLztu2RYxro BQjd+TDrjncMCtDWo+ikgbeOe1KV9GKOOmqxg44CybYFst1sX5UW+EB5oJ3+ZyaJrYAE qMCJAmxR9UYqqnJ1ip3B5yR33OVy0UQFYSO9Jd7n3xn0VBYSlkpoCcbisr7COcdOc9Dd d0t9j6L5t9pXLvjq4dOClu43uoAmFDIaeloOcYDM2EpeG5Dhc7bPuN20p/mm+TRZ9Zew YeOg== X-Gm-Message-State: ALQs6tAhKOtM7PLyq01obC+4MEEG+iZv9LHmpKs0Ut24LpW7B6IgW4OS OkHQq2YED58iRr41eY7huOOfVRpwyTg= X-Received: by 10.80.183.65 with SMTP id g59mr33467465ede.129.1524575905691; Tue, 24 Apr 2018 06:18:25 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id 4sm9485201edt.95.2018.04.24.06.18.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:18:25 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , Greg Kroah-Hartman , "Tobin C. Harding" , Quytelda Kahja , Sergio Paracuellos , Janusz Lisiecki , SUNIL KALLUR RAMEGOWDA , "Gustavo A. R. Silva" , devel@driverdev.osuosl.org Subject: [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type Date: Tue, 24 Apr 2018 15:18:21 +0200 Message-Id: <20180424131824.5164-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/staging/ks7010/ks_wlan_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c index 9078e13b0..57412caac 100644 --- a/drivers/staging/ks7010/ks_wlan_net.c +++ b/drivers/staging/ks7010/ks_wlan_net.c @@ -71,7 +71,7 @@ static const struct iw_handler_def ks_wlan_handler_def; */ static int ks_wlan_open(struct net_device *dev); static void ks_wlan_tx_timeout(struct net_device *dev); -static int ks_wlan_start_xmit(struct sk_buff *skb, struct net_device *dev); +static netdev_tx_t ks_wlan_start_xmit(struct sk_buff *skb, struct net_device *dev); static int ks_wlan_close(struct net_device *dev); static void ks_wlan_set_multicast_list(struct net_device *dev); static struct net_device_stats *ks_wlan_get_stats(struct net_device *dev); @@ -2772,7 +2772,7 @@ void ks_wlan_tx_timeout(struct net_device *dev) } static -int ks_wlan_start_xmit(struct sk_buff *skb, struct net_device *dev) +netdev_tx_t ks_wlan_start_xmit(struct sk_buff *skb, struct net_device *dev) { struct ks_wlan_private *priv = netdev_priv(dev); int ret; -- 2.17.0