Received: by 10.192.165.148 with SMTP id m20csp4736740imm; Tue, 24 Apr 2018 07:38:36 -0700 (PDT) X-Google-Smtp-Source: AIpwx499X7tA6EW6luKM3dgQpZxXrsc+A/MS/Ui21q4bdC0CTQSHWiLWMG9M+a6zKRxZmgJsw6/H X-Received: by 10.101.77.199 with SMTP id q7mr20903576pgt.305.1524580716511; Tue, 24 Apr 2018 07:38:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524580716; cv=none; d=google.com; s=arc-20160816; b=Vpu6kFq+5oo6/VlLbJHomQD6IXVKjMNYXNbRYMwnWbn9QTkZ2ZZXM4k/G/s4QeKq+G bLa31z1De2+KzKZvw7jyTEMZcCvvbFGAKm6Se2RKhcKvv1/iS20gqR9PlEPP7UNRcFYf i29ne2TxL68HWexv3TY0tqZv8wSA/MJKDrP55/+b+fm6dJf1Mfwsukl28iX+z52vc0DB 85rxpaJYh8yP+uyN0G0xxiL4ideOgm2KbmQ1o9zthIsjQwrPzU4XrqZL+yv07H6fTnEw r5XMJfGbplNOC+I7FzSjHfwvzGq1IqkIsIcMlhHdYKG0vYpYTajiZM550uBU4FvQlxlz +lFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=7hLA6x0ogCg6V6wGw7pmt7Z41KRMtkthxE4kYGFOF5E=; b=JrNjnH7CMqx/ErA8NbHx+VzW/s5AqxLy/JlHUgLCpXmy4v4l7Hqp+zkB9fSItFCZYS RyHDr2PG+E9lkAGMFvIOUylzuQSS80A1PZw7n/clvvsLeADXY3Hw9PvRqDVGIQgjUukb 7cOS78AkovIec8m6f233oHHGkBydXVcIL7b3dzq97m/xmLJ/F0FaMcb0Q/RCvMIwFXiE hjrhHd72WSV19x4OoNYwPbo/u5cOEyxPRzFFVzOWLFFyVtkbZ2cIdDxN8XUzoSFhGjrZ fhagS1NJDgTwFZiY0dIcCtnZrJzbgMUDWwEaMkM8JDf4nEuh3l8CXCKy0/pGthBe7z86 xVwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PDJzudPw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k62si7223527pgc.170.2018.04.24.07.38.21; Tue, 24 Apr 2018 07:38:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PDJzudPw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757971AbeDXNTK (ORCPT + 99 others); Tue, 24 Apr 2018 09:19:10 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:53857 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757945AbeDXNTD (ORCPT ); Tue, 24 Apr 2018 09:19:03 -0400 Received: by mail-wm0-f65.google.com with SMTP id 66so912519wmd.3; Tue, 24 Apr 2018 06:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=7hLA6x0ogCg6V6wGw7pmt7Z41KRMtkthxE4kYGFOF5E=; b=PDJzudPwYHKeFA7rSZN1b0Lds00QKjhwdfMTPeZiaMEZmO5BlNZHS/9cwTFYcsZi2K 2pZ+jpZmBwOq5ZfAP62jHQ3ThJ88LUhBvghfn3IYIoHsswzHr9x4cKdcrAtMRo3CNQjK oWahEgzVA7H7Ei1GFVGagK7iqZ+E00KHxr3pkfXTqPc+J2/G+3T9GnmMc0neVQLCkZ5C UTXrcS4NFXVjL28pt+ICu/UZEZo8RT+5qQ8EleKUBlTJA9ZdBD1zQSiPO8JfRZMRpc4I Vi9h5gYeJHCHdWbPli2SGD+unxxvgTyqpMcOT247/z/X00pQZJCOdp6R9N2FTeWH5JVD 6hJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7hLA6x0ogCg6V6wGw7pmt7Z41KRMtkthxE4kYGFOF5E=; b=SlKidvMqSSHwSUkxenbC7SXcCkaFXwytjYuQRPhgIb/I2dW4vj7MxPX7mg2oEQgHWp 2WHXGLi94zuZNAIGsk7H1KlzINehMNKOXaX3K6DQ2m3LnfPz96R5TwNb6gr+XqbjLeVz p2anYu+ODhJpis5fhgCS2GbBz1ZvyeqjF+Y7+jZbd4L7gi0kdQc271augjgrNdzjG/xA bRlf4mZ7yqfnBUCmjICRPYE3TkSVfSf8ghigIjUMbDr8CL+BqziuL4FPuxO5Aqim8EEE VteJ9W6n8CD2X44eVwhF14INEMc4x37rt8ZXBnNThmEXi4NwgE5l9e5QwnyBvyeSdjTE Y+uw== X-Gm-Message-State: ALQs6tCb6DyvglmEuvOGT5lyDBYI4Edqcj0ewFuKUt7UJ8c9LRA6FhrR J8w6FSnPQJUTNleq6fpsAitYWRmR/p0= X-Received: by 10.80.190.68 with SMTP id b4mr32756493edi.164.1524575941348; Tue, 24 Apr 2018 06:19:01 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id w1sm9233105edf.57.2018.04.24.06.19.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:19:00 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] ath6kl: fix ath6kl_data_tx()'s return type Date: Tue, 24 Apr 2018 15:18:59 +0200 Message-Id: <20180424131900.5718-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/wireless/ath/ath6kl/core.h | 2 +- drivers/net/wireless/ath/ath6kl/txrx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/core.h b/drivers/net/wireless/ath/ath6kl/core.h index e23d450ba..0d30e762c 100644 --- a/drivers/net/wireless/ath/ath6kl/core.h +++ b/drivers/net/wireless/ath/ath6kl/core.h @@ -914,7 +914,7 @@ void ath6kl_tx_data_cleanup(struct ath6kl *ar); struct ath6kl_cookie *ath6kl_alloc_cookie(struct ath6kl *ar); void ath6kl_free_cookie(struct ath6kl *ar, struct ath6kl_cookie *cookie); -int ath6kl_data_tx(struct sk_buff *skb, struct net_device *dev); +netdev_tx_t ath6kl_data_tx(struct sk_buff *skb, struct net_device *dev); struct aggr_info *aggr_init(struct ath6kl_vif *vif); void aggr_conn_init(struct ath6kl_vif *vif, struct aggr_info *aggr_info, diff --git a/drivers/net/wireless/ath/ath6kl/txrx.c b/drivers/net/wireless/ath/ath6kl/txrx.c index 8da9506f8..618d12ed4 100644 --- a/drivers/net/wireless/ath/ath6kl/txrx.c +++ b/drivers/net/wireless/ath/ath6kl/txrx.c @@ -353,7 +353,7 @@ int ath6kl_control_tx(void *devt, struct sk_buff *skb, return status; } -int ath6kl_data_tx(struct sk_buff *skb, struct net_device *dev) +netdev_tx_t ath6kl_data_tx(struct sk_buff *skb, struct net_device *dev) { struct ath6kl *ar = ath6kl_priv(dev); struct ath6kl_cookie *cookie = NULL; -- 2.17.0