Received: by 10.192.165.148 with SMTP id m20csp4737554imm; Tue, 24 Apr 2018 07:39:20 -0700 (PDT) X-Google-Smtp-Source: AIpwx49jE/p8zRszkJ+/noDtG+BcFLdUpZ/7k8FC7uypgAUwKC9Jl7u06y7Hy7n4eUglg0rn1Ysn X-Received: by 10.98.247.17 with SMTP id h17mr23763029pfi.165.1524580760763; Tue, 24 Apr 2018 07:39:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524580760; cv=none; d=google.com; s=arc-20160816; b=C45OgYsTbs6CYx1xNDRX1Gf/cmGvdxelQfFxj+PD0jRT9BNeWdpTxPnSh8a7zVdrMt myiC9Im4P/avKjusaWajPvNyAxpEmeTDlbcAw9g2p6RX0QLAIMHM7oUoRylddJEuIYnB JXRNBnKuLReQbLLJg53lqBQtoDQKtycJ0p25mOqLHjg+zKSUUkoSdCyl8ZgDuAXXxxrx dZlPi832WcyTqTrxpx+Mugf6Q14+NoenfuLVnjsDsZhaLCVayLe9EVJPsWPJQ1Zg9ISS GRIJvr1ESNdE1IG+/LLzEiQ4+CHPpR2qOBprm4dl9rsdZnnUAQGS6vaEuMp3iUbNjue/ kyRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=avoQZPUUfvfQSprShcRRbMKntb3WoSmtnmMWC6exNUI=; b=CUcIbxGzXZ2wPSe/H8gEKFrc6ttEv+SLO3G2pmXnnBcD8/qtn9o3/GIVbLSRSbakKc 6Ep2fO6DvGiz7gGCqyjOShywamCcTCXkGAW5J3f/vOBdmy1pj9ER4ehqFfn5aKowbSKJ Y4mpSClFCam+eO2+6NtOxWa6XdndxBrp+QQYWYUCg6gYSG9z8Pmwrwt6ZPLTUJzS+MqS Oj2ChqBIozGnzvu8dKzsJpZF6qpietmg9dDrd+3TC0bhr73rbDCLBlvBDs+t2EI5kaAs cmZAVi4nxOsgRWz5If2/CU9FwuyF+gHlgXqxh2kJGCoMP/8RWW20p20xy1zDyqZfjeaV c/TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Jezx+liT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g19si8047292pfb.280.2018.04.24.07.39.06; Tue, 24 Apr 2018 07:39:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Jezx+liT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934334AbeDXNoL (ORCPT + 99 others); Tue, 24 Apr 2018 09:44:11 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:51013 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933683AbeDXNQg (ORCPT ); Tue, 24 Apr 2018 09:16:36 -0400 Received: by mail-wm0-f68.google.com with SMTP id t67so903923wmt.0; Tue, 24 Apr 2018 06:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=avoQZPUUfvfQSprShcRRbMKntb3WoSmtnmMWC6exNUI=; b=Jezx+liTmjrsBckMgan1+gWzghcrzlPJl2SPXTfv8xCzWSMtqVMbHmgwoSwjkwFiLS uvxNoEeYdANUgFy9bawo1StMPhuCbD26zbJZBQj7yBbrK7WXRhVXo/3LkVBt+Knz45Eu f15Xmj/FJkDHRNFoWIXY7UDoNqCr2ku7byYrQGa1B8Ve7vJPMwhegJhalRaslhW9xLzf tCdoy+9pflbLybj7RIJ3WSDJEt8rT29LfW/HY6vFKRAGFpZCMnJBAbfLCPuip6QrfNbk 2spE3YRozIgcvvX1nXB4GtqCwjxPFqUd/6NcrcrxysodTpgpKCtrSEuiqxrmrNhbMxE/ j7uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=avoQZPUUfvfQSprShcRRbMKntb3WoSmtnmMWC6exNUI=; b=mrgU9L8rV+NBxwLvLUmovYO38RFSQGSnoHlyJ/rK0Unp32BFjJCbUZ+QBhqFDb/X6h c26glKm38/K+otOnRseri4nsnMUbPFnqMUTMZFEQZ1CaaYG8tAhJyiiQbmQIVh+m/ifJ OqMvDEnWMZCwBORCrywV7OsvO4w7qc6YB5BAO/BnEaJ5OhXD8CclJD8mmOM7MpZOmpb7 j7WO/Sfd6Kl6W8MDCfQo3sUqESV/JpCZH4e82a5ftH5tkah4sgauILuCCjQ5j7zZI7SO opstYzYmqH7fMQwCXIGccAc4q3FBudziINjoJhlITUaTBUH0yqFNXONZhrOB9aoBy08Q +Gtw== X-Gm-Message-State: ALQs6tDJVvWTtSiidaZCoYZpQUpATLUCxgsZenTRQ4Sf5lf1Hw7fkSuH eJpfcKxg8BTED/ZXnoJGmlbcyBhUpy4= X-Received: by 10.167.199.2 with SMTP id i2mr5896207edq.144.1524575794129; Tue, 24 Apr 2018 06:16:34 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id z4sm9483933edm.44.2018.04.24.06.16.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:16:33 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , "David S. Miller" , Johannes Berg , Marc Gonzalez , Stephen Hemminger , netdev@vger.kernel.org Subject: [PATCH] net: nb8800: fix nb8800_xmit()'s return type Date: Tue, 24 Apr 2018 15:16:30 +0200 Message-Id: <20180424131632.3607-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/aurora/nb8800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c index e94159507..e4331168f 100644 --- a/drivers/net/ethernet/aurora/nb8800.c +++ b/drivers/net/ethernet/aurora/nb8800.c @@ -396,7 +396,7 @@ static void nb8800_tx_dma_start_irq(struct net_device *dev) spin_unlock(&priv->tx_lock); } -static int nb8800_xmit(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t nb8800_xmit(struct sk_buff *skb, struct net_device *dev) { struct nb8800_priv *priv = netdev_priv(dev); struct nb8800_tx_desc *txd; -- 2.17.0