Received: by 10.192.165.148 with SMTP id m20csp4737820imm; Tue, 24 Apr 2018 07:39:34 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+ZCPYn2Vk4hWTNYIpE2PWkIi4TnGgOXUwz+f1WxkWfFFJ8VRWP2GJN/CEUpR7JhqBlqGLk X-Received: by 10.101.68.129 with SMTP id l1mr20645043pgq.239.1524580774564; Tue, 24 Apr 2018 07:39:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524580774; cv=none; d=google.com; s=arc-20160816; b=G13iWlkN8d9LEy4nm9M4AWQirejzIv5rGZLLGTiuxy+vIhOqFEs8q7IGa5MfKfnu8i Jby8vAAoQBArIOJq5qix8sNz7P86aVWj1sP4WlCESJa8pJX8gbIwfU++xSkaVZMwBBrg avBkUyk4QMNbpLSbEHkHurJNQGiy9vgJssZvHWhuQLXHOd3DNw04iI/hiQzQMxesHICT bYgT4a8tPpLk3IbHMJqLi9NP5jW/NlVNWoyXLzQ1GWc3JtcBiiPLWYa9O047z4gdnIdf r5dMDU1082r0Z875TGgyRF3Ofr1FFoAdIlf8o6opP7e4TNFlmeZbeMGl/BK3jW5XXJTC 2sdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=N5+rYU+F3jZfHXa1+CZKdoTjpf/ooNBEGQPYh4SU7T0=; b=XCf/ZCfWehO074AkNh/4IyzEgYTm0EC56Q39RRgh9paE+lkt9YJ05lnrGdhTCJHq5z VOAnkaDrmn4XM8+dZcScEXQ/fuFoeREa4KWBlphKJUVAp4ovb/OHeDxgJa+qEkJcls3b GtE9MpYj16Jy21XxLIqBm97cESSve6n2VVMwUyfryWQPKUjVcw9rrNujIJ2S2H11IbZp VFMMD1jyOOgs3KazBdVWJSLV6F88lAAOxc+NKmN8P7BAUxdFiOfmDuyV84EYw5Gh/22f Ze4aXUkh3/GeipKqXH63AknxNIRnMbmK6goFxeyXFXQqzDP/gwxwU/zOHXGdksWKCp5x sA9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MJouu30O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y23si1991164pff.177.2018.04.24.07.39.19; Tue, 24 Apr 2018 07:39:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MJouu30O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758279AbeDXN6U (ORCPT + 99 others); Tue, 24 Apr 2018 09:58:20 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37688 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933395AbeDXNPA (ORCPT ); Tue, 24 Apr 2018 09:15:00 -0400 Received: by mail-wm0-f67.google.com with SMTP id l16so793375wmh.2 for ; Tue, 24 Apr 2018 06:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=N5+rYU+F3jZfHXa1+CZKdoTjpf/ooNBEGQPYh4SU7T0=; b=MJouu30ONaH53zHMXEz5RvWjUfN5PvcS/4cFOglJzryMStAhLXmoxldB/sUgGqr+PK zA7tGVCb207wy5wGSVyTQpb6P7N/5SQ2m8UlKsEGozzIA9t6qN4l44Qlvc44tray7jJe HLOirBSt1g0RkDD5HoyauM83I6r3QMcjSGBsGINGsvCcZzKoec2VJaSjxWgZDac7jZqp kYF9Q6UVm+439Lw0TKHSgHbXKDCNsCZ7ufLFKvAK78mgCTPZW39+GAS/477bA7+mp/0/ q+/93HDjT+n2uzgbICf2Lw+e8WDuCJZnByQ+ecLKp0H4/AymY8aFy8g12PTItoLgSRDW wl3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=N5+rYU+F3jZfHXa1+CZKdoTjpf/ooNBEGQPYh4SU7T0=; b=ZUHoXtsnSxELkZ+K6vKMlylwaEPdiNtS3CZ2DMm3JTqk/caunFphEStwNPpvgQV2dZ 8zHhWobL9yvG4+OS/5cki70wRuaak43gibvdqmbeK1wOLNRBHfdIYIRrVaUnXW/704PP t/t+rSUBArXI1hozPDJrt8JIpyM98h/3tOgsXnr/AqyrfsDZq0tGDU47nNiGNvMd3vE+ dqqmy2qAQKLlKnHkTjYpOMQvOWoL/8/TwNJRtHyLcChQIreMEeVmZoZbjZVCbi7RvRLa EKOg01dt1CPBjpoovt/pgYbLF6PCf9esYWfHUO4yYbFd5LWVFQQCLwzZUUlvxma7mxLL wWcg== X-Gm-Message-State: ALQs6tDwM3mMduadZU1ylfSP0s0DYhklzc6o53zd6o7kFLIFSNuH2tht a/GMBR796JETHG2rRQvNHHvIoroj X-Received: by 10.80.190.68 with SMTP id b4mr32739237edi.164.1524575699195; Tue, 24 Apr 2018 06:14:59 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id s9sm9201886edc.85.2018.04.24.06.14.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:14:58 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , Patrik Jakobsson , David Airlie , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/gma500: fix psb_intel_lvds_mode_valid()'s return type Date: Tue, 24 Apr 2018 15:14:57 +0200 Message-Id: <20180424131458.2060-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method struct drm_connector_helper_funcs::mode_valid is defined as returning an 'enum drm_mode_status' but the driver implementation for this method, psb_intel_lvds_mode_valid(), uses an 'int' for it. Fix this by using 'enum drm_mode_status' for psb_intel_lvds_mode_valid(). Signed-off-by: Luc Van Oostenryck --- drivers/gpu/drm/gma500/psb_intel_drv.h | 2 +- drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_drv.h b/drivers/gpu/drm/gma500/psb_intel_drv.h index e8e4ea14b..e05e5399a 100644 --- a/drivers/gpu/drm/gma500/psb_intel_drv.h +++ b/drivers/gpu/drm/gma500/psb_intel_drv.h @@ -255,7 +255,7 @@ extern int intelfb_remove(struct drm_device *dev, extern bool psb_intel_lvds_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode); -extern int psb_intel_lvds_mode_valid(struct drm_connector *connector, +extern enum drm_mode_status psb_intel_lvds_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode); extern int psb_intel_lvds_set_property(struct drm_connector *connector, struct drm_property *property, diff --git a/drivers/gpu/drm/gma500/psb_intel_lvds.c b/drivers/gpu/drm/gma500/psb_intel_lvds.c index be3eefec5..8baf6325c 100644 --- a/drivers/gpu/drm/gma500/psb_intel_lvds.c +++ b/drivers/gpu/drm/gma500/psb_intel_lvds.c @@ -343,7 +343,7 @@ static void psb_intel_lvds_restore(struct drm_connector *connector) } } -int psb_intel_lvds_mode_valid(struct drm_connector *connector, +enum drm_mode_status psb_intel_lvds_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { struct drm_psb_private *dev_priv = connector->dev->dev_private; -- 2.17.0