Received: by 10.192.165.148 with SMTP id m20csp4737889imm; Tue, 24 Apr 2018 07:39:39 -0700 (PDT) X-Google-Smtp-Source: AIpwx48tLe0rB884C+zN+cHSeCpac+rBf7RUNjcjNmP9MH6J/5i1mCp8BP/z4gpMNZSJvAloQKFH X-Received: by 2002:a17:902:6f16:: with SMTP id w22-v6mr24883310plk.216.1524580778962; Tue, 24 Apr 2018 07:39:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524580778; cv=none; d=google.com; s=arc-20160816; b=ElWLlTMOMIZ9SzSQFziw9bZnZN2Ng+GI1z6/+sjTEFfXpfZyD1IvsfuEycVt/Npm/u +fCQbb6Z92k0BzmJJT0bAQRKE1XgaXvn1ThJ0YMsOwz5QcxKdb9L8PjhJTi9QdVimgHt Lgo2J0L1sMjxC9RpToNVRgQ2eSHPWaKWvppCQU2sbBhsaxrgJga/OxQ643sZD1FcCn7H P2sfoQSx+hCCfjZq+EmQorJDwHQl6uSDsy5PVWuO0BmWlqy3sPUj8Fb3RVUAbS/R55CG NaE+4JnnOy8oSkfNJFyTT35ZQQ/QThrcGjYrQ66Ai2QMAgr23HjH9mTMTkwE4l8DR/Lw /0lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=g6HX4kN7tMdo3NHQwrtJNiiUP2sBfoqS2yE8qLX9bqk=; b=mt0Pq76Pa/ecDMelIic59Yh0eDRIdsUHlCv9eTh498cAwJ6NXm1wHK/XII8cJtgq+k 9FHJd4GnULVEdnKxkKSZIQRhwzbjLB2vQuJUckIHDRcT1nPlWWpiii2KaY9FBnJqAecK gkpLQriKQ4VU+XDiW0n9TKkh7XSJBfefy/om2Uvo5TBLR/82j4A5dCCtND7DIX3xa7M4 jCo8S9vhAATRL2SK2GJ1K5D/KcAp9spxDIhudMwm86I/tXtWfGj0mHxgY0lU7LNMyxCv hAX5bMswGcnDYwqw3qn9oMtn+v8TaL8BJQnDTR/NPZw+p4FJDxSYopRTL8j2o8awoz2N ENvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Msh6ulRV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l81si11490025pfj.127.2018.04.24.07.39.24; Tue, 24 Apr 2018 07:39:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Msh6ulRV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934057AbeDXNa3 (ORCPT + 99 others); Tue, 24 Apr 2018 09:30:29 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:55592 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933910AbeDXNRy (ORCPT ); Tue, 24 Apr 2018 09:17:54 -0400 Received: by mail-wm0-f66.google.com with SMTP id a8so912555wmg.5; Tue, 24 Apr 2018 06:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=g6HX4kN7tMdo3NHQwrtJNiiUP2sBfoqS2yE8qLX9bqk=; b=Msh6ulRVLG7P1D6ioXDBhhG4XxgZiVtVCHripBYxdK3io8r6ol6bi58iP3Jj3uU59C HMcIUnwOXNTg1QUg7EUN61602bBl0uFNGIwDPeqNgLeoxrATrVJI/N05RASHn6F3zE9K mJsQSwKMs6+rDwrUpQC1f8pB9ZbzJhTHG+kguzQbuZxED5i/83USVDvMLmNvLxYGw0MS 9yfVwGbBdhtEKigaQsg8PtD5rCP6VJSeHh4rKKDmCZPKe5RucKUqCmGlZZPfQQV8+Ezp xt4k0gQsQ4qATCAds/q9hU7wczRwLsVhPM2gNfb5ODi7Jbe53WvFiAR3A1p7f01e8wrp BhJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=g6HX4kN7tMdo3NHQwrtJNiiUP2sBfoqS2yE8qLX9bqk=; b=CpLKveZO6jTWkO084IynYPu4oKjv9HSX8rfxTK+xARvHIUdwPnN60jaBi5y5pSIkCW 2D5T6zDv0hbGJTqC92no76CmVKGfqv/PepxWWfuL1WAuLEzbbRq9UUV8yC/xtvrcpeYV y6TU6Kl/X9G4ggQxovHZGsTurR/9IuSP0sb7lBvRezoncSbAYO8EGHhxVqaT+bFrUxDa 0+77O7QW/zLoH4zC9s8qWc47V5SE/bBWgJ/bWfLPD55hxu8s66dsJMJydWee0Am5WZcs XzrsrT4znlUyd4PjRfXtlBA6ftl4bZvtuc6vUCj8ZB7zO5V+kVCSdSvUAuH/umSNPe4C NZFw== X-Gm-Message-State: ALQs6tAqV8eSJzquci0i4KnjYNXVs6qMoQtyxe1ixmqp/KKcqEVIO/8M bbvjEZJQwBOjqohRI5Oq4cQ+LTPyb3A= X-Received: by 10.80.250.129 with SMTP id w1mr18630021edr.41.1524575872782; Tue, 24 Apr 2018 06:17:52 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id e29sm9557403edd.45.2018.04.24.06.17.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:17:52 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , "David S. Miller" , "Gustavo A. R. Silva" , netdev@vger.kernel.org Subject: [PATCH] net: plip: fix plip_tx_packet()'s return type Date: Tue, 24 Apr 2018 15:17:49 +0200 Message-Id: <20180424131751.4761-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/plip/plip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c index feb92ecd1..0b354e65f 100644 --- a/drivers/net/plip/plip.c +++ b/drivers/net/plip/plip.c @@ -146,7 +146,7 @@ static void plip_timer_bh(struct work_struct *work); static void plip_interrupt(void *dev_id); /* Functions for DEV methods */ -static int plip_tx_packet(struct sk_buff *skb, struct net_device *dev); +static netdev_tx_t plip_tx_packet(struct sk_buff *skb, struct net_device *dev); static int plip_hard_header(struct sk_buff *skb, struct net_device *dev, unsigned short type, const void *daddr, const void *saddr, unsigned len); @@ -962,7 +962,7 @@ plip_interrupt(void *dev_id) spin_unlock_irqrestore(&nl->lock, flags); } -static int +static netdev_tx_t plip_tx_packet(struct sk_buff *skb, struct net_device *dev) { struct net_local *nl = netdev_priv(dev); -- 2.17.0