Received: by 10.192.165.148 with SMTP id m20csp4742559imm; Tue, 24 Apr 2018 07:44:20 -0700 (PDT) X-Google-Smtp-Source: AB8JxZry82Yfm2xmk10kWd5YAEZguGIYGh6nN49v46mbHzSK3hiLlGKY+ejgX2jicZMfr9Q0TWb9 X-Received: by 2002:a17:902:b2c8:: with SMTP id x8-v6mr2057737plw.3.1524581060148; Tue, 24 Apr 2018 07:44:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524581060; cv=none; d=google.com; s=arc-20160816; b=qn31Lha6FcFuNT2IwZ4hohpWn1lPchrotxkIG45UN6vCwkSs71DWkmGmJO3aTA92PF CCTQFnq+cud8mLYfRHILySS2IQzIzC5wgNWLwjF6Dgsm5dLWVlD8jrkG9mQdkkOl9Mhg A6az624FnnU8OAT4oAu7AJjRJjpPZyHUek2OlmcmJemxk+kAr8uScKrTWWUxhoibKBun duLgVdNN4qoW7u/UJFA634lgPat0QH9GbROya3oIXJqPTqDTg75ju1XwFEYMFPVbufg5 s8lqluWj7CZj/6ab3eUZ/7vcqeGb/mRkpF0bUw9n1CfDxVE3m5cTqcHiRuFFbFWKLHAE Okcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=iTApdZ1c7RusF0ZA4pbsxsBllwvZVuC6IKbwuGMRojE=; b=yV5O9Qsi6Da9MDxH8R3ciwV+BSDpkcDszxezSl/j3aaxYbOdBl/AbTvEi7nqb8IheG Ip9eaUwBic3X91s6lGwhvyZm72S+fMwR2fj4ZhNoBU3EfhcI72EvknmQsMlkNLfgJCHA Sm/Xc5ZfSABdpIQdNfj3z9X+J8LykFjbcdWD6saS8wD+8EMKQnuPeQjGSoD49B/7hgeU tXSz2pHTZMi318rT+ekp+hqz/ytwktMPyycJNwgOAYrcsV48rih1tCrAAJ7gUpDTMQ/A f4+Gt+lrh6rjjXzEA5ihdgxkBNyiLNTr4d/dC7hlhxFMtYY8GaRe1LaMLn0r24xrwEEc NbxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q8si11107995pgn.692.2018.04.24.07.44.05; Tue, 24 Apr 2018 07:44:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461AbeDXOmx (ORCPT + 99 others); Tue, 24 Apr 2018 10:42:53 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35160 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbeDXOmw (ORCPT ); Tue, 24 Apr 2018 10:42:52 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6DD3A143436D3; Tue, 24 Apr 2018 07:42:51 -0700 (PDT) Date: Tue, 24 Apr 2018 10:42:50 -0400 (EDT) Message-Id: <20180424.104250.1411072442966778574.davem@davemloft.net> To: luc.vanoostenryck@gmail.com Cc: linux-kernel@vger.kernel.org, igor.russkikh@aquantia.com, netdev@vger.kernel.org Subject: Re: [PATCH] net: aquantia: fix aq_ndev_start_xmit()'s return type From: David Miller In-Reply-To: <20180424131623.3505-1-luc.vanoostenryck@gmail.com> References: <20180424131623.3505-1-luc.vanoostenryck@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Apr 2018 07:42:51 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Luc please don't submit such a huge number of patches all at one time. Also, please fix the indentation of the functions whose arguments span multiple lines as has been pointed out to you in patch feedback. Finally, make this a true patch series. It is so much easier for maintainers to work with a set of changes all doing the same thing if you make them a proper patch series with an appropriate "[PATCH 0/N] ..." header posting. Thank you.