Received: by 10.192.165.148 with SMTP id m20csp4754531imm; Tue, 24 Apr 2018 07:56:38 -0700 (PDT) X-Google-Smtp-Source: AIpwx49pQbusxYUesuzVYMukW2MTv0pDTfCMsoMLYTiwdN+wE3iFi8Os8r1z5L6uH5mhCa2umdkZ X-Received: by 10.101.77.13 with SMTP id i13mr20676431pgt.70.1524581798812; Tue, 24 Apr 2018 07:56:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524581798; cv=none; d=google.com; s=arc-20160816; b=SvI+YAD8wZoiAp18xNBjjTB4+CeIgk5doT30eSJN83/OTaEa8BBKKGmA0g6i5qKWJR h++btrA5YhlCF+aP0mkUV00dFggcTGUH5GG7/PPjzmkl5StSGyzNar1Pm6c7ow+3tESm pbYgPM5A8/UCLLUyg0mF9HsNxFn7kQHmhMF4WWGrPfJdnQ5tKqFxyERvxwkcnOWtI7ar vaGAnM9lcqEW5LTR3KMf7H9VIGyHs2luZ4J2cROPBKoXvvJ6cQG7ZIo0XfpOhX0TdlqE 97zNA0ObQI3I8qkhFhzO7i+00VNwbCPxPF1nCts5ROBw3O7jM23GQLBPS1FzMUAVzqO4 V1Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=DoNxhQksJmeNtFsRKrF1dtA/duO+rEPyvtLf8yo8czM=; b=PYLkLWYJKD+IKK7MmGc4WK0so5aPBVtf4E9jWLTXnIb0OvbX6l7J94R7lst3BWzzVU UyzgVMRLHeJOFzKV01t4mmng4sKDnAreISR/iLjTD7KMt3dmKjjigsqKxw6mQ3iebGHC utkGFd9eujinoqkoKeV/rwYDT2Y2kOUbGp8yFvkTDsZm58Jpv+u7M4yR0jmiVgXzbgdF rSWEQDbhWNmBq+yrjnvKumoc0Jokcu+EBl5nv7FpIWtn+YFlE1dDrNYvR15u8jup7Ry+ gdXNQl5HVzCeWXrG3apZj/wnFvH0h0/v99sFKqH1ysY12VQJeP3aHGuZVBg3g45ax3Ns R3GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lsyFlRr4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o33-v6si13470446plb.432.2018.04.24.07.56.24; Tue, 24 Apr 2018 07:56:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lsyFlRr4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933506AbeDXNPZ (ORCPT + 99 others); Tue, 24 Apr 2018 09:15:25 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36477 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933484AbeDXNPS (ORCPT ); Tue, 24 Apr 2018 09:15:18 -0400 Received: by mail-wm0-f66.google.com with SMTP id n10so788810wmc.1 for ; Tue, 24 Apr 2018 06:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=DoNxhQksJmeNtFsRKrF1dtA/duO+rEPyvtLf8yo8czM=; b=lsyFlRr4VzFRJgi9KYn+oiHfzxKhejOO0pqgRkweYHBV62w5yq81aJe9kEwWP8xpZD fuHOeAFXx6+q0TO8Z1OSC5TOWSMdX6kkgFclKqjRFY1MTc1DuXPE0o+6d4evcweRGj9E vBq7vW11EsajJo98egJ1f4wi7+1Kcc+XW4f7X0bI6gWvNCSVGSyMOPJ/IsaxEtj4lGf5 Zgrl29eSl7PwzfynZyzLNcUCjl0a23q+febjyoXNWRzo6QEgNsIF2tlb+61MlpelvsnV KtGVD6e6ClekINoA4EJHS14PRt8y1uRVBWQh/N75gitCohIOMhvwEpzlmyj6WxIUtQjD umUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=DoNxhQksJmeNtFsRKrF1dtA/duO+rEPyvtLf8yo8czM=; b=UucmBpCbY81ESdFnZyjqPCdYSePicYr5fZzhbwqmHvpBVCZdYUpidwlKzNNhKR1hn2 awJKrb9n1yZMJmTYUpoWOsFrxJIETwatlWXuUN08FkVEomE5BRn+Brs9KLNovowoFHeV k0IpfJW2dXTW2/kEPmtJjXh3C+GosApuG14sATfUkTCjgJsdGHtBW/I5wtMDv65vJIIb dprnyOal7Lqi1F5x9LZZ+FEzeimyr269l2nIUuhqOMx429SqvEG2XpOZf4W445ShnKZ8 nmCQ7lLdRHd4N0a8XWsnhVtCG05yKeSKx/4LHrZjf7BGXb6UhFqhZ3vASJ9S/CtFJbdi cKcg== X-Gm-Message-State: ALQs6tBMjl5SWQbwwAN937EWoFpOkW+mJn46MS9+4JvXc4pJWIE6YZiC yTg3PFCK+SLrcQKYCyWnKBMlXqCpXus= X-Received: by 10.80.169.117 with SMTP id m50mr33255893edc.242.1524575716842; Tue, 24 Apr 2018 06:15:16 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id y56sm1189225edd.42.2018.04.24.06.15.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:15:16 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , Dave Airlie , Gerd Hoffmann , David Airlie , virtualization@lists.linux-foundation.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/qxl: fix mode_valid's return type Date: Tue, 24 Apr 2018 15:15:15 +0200 Message-Id: <20180424131515.2360-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method struct drm_connector_helper_funcs::mode_valid is defined as returning an 'enum drm_mode_status' but the driver implementation for this method uses an 'int' for it. Fix this by using 'enum drm_mode_status' in the driver too. Signed-off-by: Luc Van Oostenryck --- drivers/gpu/drm/qxl/qxl_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index ecb35ed0e..820cbca3b 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -1037,7 +1037,7 @@ static int qxl_conn_get_modes(struct drm_connector *connector) return ret; } -static int qxl_conn_mode_valid(struct drm_connector *connector, +static enum drm_mode_status qxl_conn_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { struct drm_device *ddev = connector->dev; -- 2.17.0