Received: by 10.192.165.148 with SMTP id m20csp4758095imm; Tue, 24 Apr 2018 08:00:20 -0700 (PDT) X-Google-Smtp-Source: AIpwx48LOBAtlCFItkOA7rFl9iiMSD9iCkg2wEtDuHwsz/i502E/vdVu4lDszejNpCcfb4LW0Jcr X-Received: by 10.98.211.143 with SMTP id z15mr24276771pfk.100.1524582020403; Tue, 24 Apr 2018 08:00:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524582020; cv=none; d=google.com; s=arc-20160816; b=0sGQih4BWKzWNG6Qq6qnIWE2RVn+Rt5U06AnJghMpVL/qEObf6vh4lH1mNyUUwoMy3 3lgvre38WfUmZRg1oP083P4mDE+MU24RNb/x0C8/u/mxoIpbm+2fACxymSENlf5dh5I/ RcHLM2nTjCRfWlLPS6npYVkv4SULlOStiKYDC9IKpWxBm2aY6ESe5CRTg2j53rqqOo57 SpBOzYONOPetaWTX7CrVFH5mJXr9Ggb6eCT7owQ4DkCzZYHhjnF5GQ/N7xo/Oi2keqAT q9iahgQq7giVx7ryzhFIpu+ipE84oR5d2EnOLh5MJ4JxTQgsyHadPayltjb13+XVKSLZ yv3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=BsDvCrDpykzQk3fC7g2+suZ3NCVUM0lO9McdNHK6mZA=; b=SYeLvHNmYvVC8XS3MFOsSeEQfxnsyPOwGLnhNMkjZqxY80OhwjSXIFejNMaxLTpP+t mqI39tBw8FwlILoEa354w1wsBsbFSi9Q3ZWg6nSmabxIn4gN9yJF8D09nsdeWlSgy5Fc gss5LDWVeEd03VtBf4KrJ7qokkYsWsIyDy7mURGZmbPY5ph2VmwPvsSfOmBz1MvBefZW h5aGt3VC6rzYHiPrVTo3NcmdpHa+2b+hPCieAX1z95NFmzCe1Y8j2u4HA/8j4BXNGhby xeFgwN1lYggxQZwOjh7VEKgXK+lgG5WFag/ElMBB/JRczn8Mzkay7XOrWI06W6Sra4Be +vYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ACilZqsn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3-v6si923493plq.547.2018.04.24.08.00.05; Tue, 24 Apr 2018 08:00:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ACilZqsn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758112AbeDXN1Y (ORCPT + 99 others); Tue, 24 Apr 2018 09:27:24 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:55727 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934041AbeDXNSW (ORCPT ); Tue, 24 Apr 2018 09:18:22 -0400 Received: by mail-wm0-f68.google.com with SMTP id a8so915815wmg.5 for ; Tue, 24 Apr 2018 06:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=BsDvCrDpykzQk3fC7g2+suZ3NCVUM0lO9McdNHK6mZA=; b=ACilZqsnJoEE2waFv1CLD3Fd2HVvlOW2CyBJEI2/KjAGlSjUp6OAr72QRNY1iY1/Zg AYI8nBtzIthqJQRBKkwuU25LsRjkflw9m6hVK/5efzaSiL87x7cHw1DkW5b+vSV5sOfr QIw3MyKaVwN2yoVu60tYPNML9cquwiuTecrn/VmE7Kjge91PJwx8VYgay1l9RtQKEvxd 722IzSnjhglTZIQO7hqwuVYO7ATCFnt9MTxyvu1j0vdA+TYCpLl9B3Ob30oiJEJRCwGT gOEl6gvlTXPMiQJh4L1s8+14kCEKQ5+a3zEhsl/MfLnWh30OUvpQUB9d9kjJri6RAn17 JlxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=BsDvCrDpykzQk3fC7g2+suZ3NCVUM0lO9McdNHK6mZA=; b=ifEumNg7zFHGhjYYkHMtQTq+GLNMinglaSJr3AXV0+kCiEMcghEjU3qX7S66ER998v oa1dTRWM4dAOJz/sU7PoQM5t/AVWeoZ/LAfG7DJl8yrSW7QWi11zLfY0ZUpGEKKr5s6r V4WjL2Cpn9TRK6IKqnvpuLJ2gN4de/bgpHKcR3rl1rJQoFHfo4dIgEvM1bbZtVQnXulr qeK+cIfO0dt4yuzDzkicMTTcOI7aWW7EAN/9+J9Jea9qjDXF7vI+gi6A1xQzYCdg87hT GJRH5YjQPkak96zCniohWgqcw6ZuY8b27Y79AUMjdkXqPcubbUwGmUgDiAY9cZVryuci BbHg== X-Gm-Message-State: ALQs6tBkw4sf+sjBBZNd6ZXgYasS1IY2U/FqrmnWnzCmp9mAVaD6jN2f 0UInXxa52TYqfuMxmxIOnmt3/vzf9dc= X-Received: by 10.80.151.7 with SMTP id c7mr33383246edb.267.1524575901178; Tue, 24 Apr 2018 06:18:21 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id d9sm9073833edm.74.2018.04.24.06.18.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:18:20 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , Greg Kroah-Hartman , Quytelda Kahja , Andrii Vladyka , Stephen Hemminger , Johannes Berg , devel@driverdev.osuosl.org Subject: [PATCH] staging: gdm724x: fix gdm_lte_tx()'s return type Date: Tue, 24 Apr 2018 15:18:17 +0200 Message-Id: <20180424131819.5113-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/staging/gdm724x/gdm_lte.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c index 4f3c51830..1f8a33f04 100644 --- a/drivers/staging/gdm724x/gdm_lte.c +++ b/drivers/staging/gdm724x/gdm_lte.c @@ -408,7 +408,7 @@ static s32 gdm_lte_tx_nic_type(struct net_device *dev, struct sk_buff *skb) return nic_type; } -static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t gdm_lte_tx(struct sk_buff *skb, struct net_device *dev) { struct nic *nic = netdev_priv(dev); u32 nic_type; -- 2.17.0