Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Panariti, David" <David.Panariti@amd.com>
To:     "Grodzovsky, Andrey" <Andrey.Grodzovsky@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
CC:     "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        "oleg@redhat.com" <oleg@redhat.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "ebiederm@xmission.com" <ebiederm@xmission.com>
Subject: Re: [PATCH 3/3] drm/amdgpu: Switch to interrupted wait to recover
 from ring hang.
Thread-Topic: [PATCH 3/3] drm/amdgpu: Switch to interrupted wait to recover
 from ring hang.
Thread-Index: AQHT2+GBbg9vSzZK6E2CBnt82gNLC6QQD8FQgAACnICAAALF7Q==
Date:   Tue, 24 Apr 2018 16:20:16 +0000
Message-ID: <DM5PR12MB24408FF7C780D95307FB2BAD95880@DM5PR12MB2440.namprd12.prod.outlook.com>
References: <1524583836-12130-1-git-send-email-andrey.grodzovsky@amd.com>
 <1524583836-12130-4-git-send-email-andrey.grodzovsky@amd.com>
 <DM5PR12MB244017F98FC732EB5DD86E0395880@DM5PR12MB2440.namprd12.prod.outlook.com>,<b4309ea4-c1a0-5811-040b-4390ce6f297f@amd.com>
In-Reply-To: <b4309ea4-c1a0-5811-040b-4390ce6f297f@amd.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b22c993-1709-453f-bcc2-08d5a9ff4431
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2018 16:20:16.7251
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1324
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Kind of dma_fence_wait_killable, except that we don't have such API
> (maybe worth adding ?)
Depends on how many places it would be called, or think it might be called.=
  Can always factor on the 2nd time it's needed.
Factoring, IMO, rarely hurts.  The factored function can easily be visited =
using `M-.' ;->

Also, if the wait could be very long, would a log message, something like "=
xxx has run for Y seconds."  help?
I personally hate hanging w/no info.

regards,
davep

________________________________________
From: Grodzovsky, Andrey
Sent: Tuesday, April 24, 2018 11:58:19 AM
To: Panariti, David; linux-kernel@vger.kernel.org; amd-gfx@lists.freedeskto=
p.org
Cc: Deucher, Alexander; Koenig, Christian; oleg@redhat.com; akpm@linux-foun=
dation.org; ebiederm@xmission.com
Subject: Re: [PATCH 3/3] drm/amdgpu: Switch to interrupted wait to recover =
from ring hang.


On 04/24/2018 11:52 AM, Panariti, David wrote:
> Hi,
>
> It looks like there can be an infinite loop if neither of the if()'s beco=
me true.
> Is that an impossible condition?

That intended, we want to wait until either the fence signals or fatal
signal received, we don't want to terminate the wait if fence is not
signaled  even  when interrupted by non fatal signal.
Kind of dma_fence_wait_killable, except that we don't have such API
(maybe worth adding ?)

Andrey

>
> -----Original Message-----
> From: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> Sent: Tuesday, April 24, 2018 11:31 AM
> To: linux-kernel@vger.kernel.org; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Ch=
ristian.Koenig@amd.com>; Panariti, David <David.Panariti@amd.com>; oleg@red=
hat.com; akpm@linux-foundation.org; ebiederm@xmission.com; Grodzovsky, Andr=
ey <Andrey.Grodzovsky@amd.com>
> Subject: [PATCH 3/3] drm/amdgpu: Switch to interrupted wait to recover fr=
om ring hang.
>
> If the ring is hanging for some reason allow to recover the waiting by se=
nding fatal signal.
>
> Originally-by: David Panariti <David.Panariti@amd.com>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 14 ++++++++++----
>   1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/am=
d/amdgpu/amdgpu_ctx.c
> index eb80edf..37a36af 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> @@ -421,10 +421,16 @@ int amdgpu_ctx_wait_prev_fence(struct amdgpu_ctx *c=
tx, unsigned ring_id)
>
>       if (other) {
>               signed long r;
> -             r =3D dma_fence_wait_timeout(other, false, MAX_SCHEDULE_TIM=
EOUT);
> -             if (r < 0) {
> -                     DRM_ERROR("Error (%ld) waiting for fence!\n", r);
> -                     return r;
> +
> +             while (true) {
> +                     if ((r =3D dma_fence_wait_timeout(other, true,
> +                                     MAX_SCHEDULE_TIMEOUT)) >=3D 0)
> +                             return 0;
> +
> +                     if (fatal_signal_pending(current)) {
> +                             DRM_ERROR("Error (%ld) waiting for fence!\n=
", r);
> +                             return r;
> +                     }
>               }
>       }
>
> --
> 2.7.4
>