Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 24 Apr 2018 11:09:21 -0700
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Simon Horman <simon.horman@netronome.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
        Pablo =?UTF-8?B?Q2FzY8Ozbg==?= <pablo.cascon@netronome.com>,
        oss-drivers@netronome.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: nfp: fix nfp_net_tx()'s return type
Message-ID: <20180424110921.24c3699b@cakuba.netronome.com>
In-Reply-To: <20180424131710.4206-1-luc.vanoostenryck@gmail.com>
References: <20180424131710.4206-1-luc.vanoostenryck@gmail.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 24 Apr 2018 15:17:07 +0200, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
> 
> Fix this by returning 'netdev_tx_t' in this driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>