Received: by 10.192.165.148 with SMTP id m20csp4983472imm; Tue, 24 Apr 2018 11:37:13 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+bs9z5ygRwCGFCv4hywqlX9ZeFPuICV/ERsnxs80B0/NVIZNdZO/z97mC8GB0D8xZwPPKc X-Received: by 2002:a17:902:7c02:: with SMTP id x2-v6mr26492059pll.186.1524595033232; Tue, 24 Apr 2018 11:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524595033; cv=none; d=google.com; s=arc-20160816; b=aSJh+yHA4U+vi3SDNDmzlB+zcwSK3X/iSb6/Zij/6bpZxacpfXK50mJ+3fXV+6mcEb 7DRoVge+zbfH4WroGA7dDjNjBur5bWc3+/EC36pcSFExSbkO6WxOJ/q8F2Z4qgUPl3RC mw/gLYIRVYkY7FB4fzDrFXiu9Kfyp8GYvvLU4vDP1+pCSbq6YmWKnhANEy+z5fYHrRYN XJB+eOv/RJJrvDT9YjYiG/Xqx+FE+mKJES0aCOUx0J7bMBqcszpsiuWV0lHbPl8B1Jnb 6bGHqMrQ2zAFx0NlhkTCOpi0hzF8IYChWI4mk7LaJTOABFcZhY+oQzXwkdh6Au/1uvE6 WozQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=blOThcFsIEzu9mpCg2gpURvzMWoh5DXz+RQr7XwMG7o=; b=Jd3c24uGXAvQNWxkl1E8RJVQPAMM8Qh9YvrJpvBvwRfzbSzuflTtCG0rX963avM2WJ IkWM6Q6KDsvK+FKhVthkFHLZ3+D3gO8QiX/VFyPVEFAcfnRXoKe2sCUuXwbdkRziC2XU bR9L3os9CuGqlMZJn44iilPoJNOatbkFxDGbWRCdipeZNUoGLY8d7wyiKLrX0G3zqida OFbNN9rvq4lh9qOpOBJ1V4NvKLrDNjyNHPL544WBdp1OmzE9rn7S/aDZEQDTy4+8fcsn E/IBz6hWcB/1ALZKAIsx66O85K93o5vVWsTFw9/JM5IdzHjg8dUnXxzAOAphoXi+owK8 fHXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GYTbgO7Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x124si12298704pgb.651.2018.04.24.11.36.58; Tue, 24 Apr 2018 11:37:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GYTbgO7Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751165AbeDXSfp (ORCPT + 99 others); Tue, 24 Apr 2018 14:35:45 -0400 Received: from mail-qk0-f179.google.com ([209.85.220.179]:42621 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbeDXSfm (ORCPT ); Tue, 24 Apr 2018 14:35:42 -0400 Received: by mail-qk0-f179.google.com with SMTP id j10so20436237qke.9 for ; Tue, 24 Apr 2018 11:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=blOThcFsIEzu9mpCg2gpURvzMWoh5DXz+RQr7XwMG7o=; b=GYTbgO7Qhy+D6xSfZp3qiIBMsbI9ZrCeigFQ5f9cMl9NmMhZ64K94h12rq1ZgjmnG6 U2zAZqFELE57sdFIv3KIYjl9B0scLPbm1M/Tv2jg3eKsxNc2pifh2SCol5U6WpiIdHl8 XMTEYJUJYC0ku4Rk/gxWaPOtf06bSXXTPaVi76NG/2ddQiWHSkii++nz6mhPvlUwhgPw V3+rbvQZCjWIgFwHr2Cj+X7RtHGUd8GVztmXtU2g5sS+kGi4crGDyBT4K8SIvasAOD7M o7NGGsg+rjc0JKmkVXG4fDA5CeduzxOpfFRcWQqG7Nm3qp0lrbH19mhInSCeGTWW/UGH RCRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=blOThcFsIEzu9mpCg2gpURvzMWoh5DXz+RQr7XwMG7o=; b=kpNdmTBDQ608Yh3xO+XF/pQa7jky7vG/NGBWmlevFAERDGTVRqK2iQaeQGq34K23ca 2eElMvad0GTxdaEkTJnn7xQRzJGxd9d2r3mqrKcGQqwNfa9p8Tc5eAZKSBQRxyyp8cr7 SdYbjQKUirGAcX+o1GnPVmzxgR2qw1KWRn49S8Qi46i5MSDOy+yqwnI1DLO35dmyw67O kGkE4/aErGhM07PVST4EOFpSU8+jp1obpPW2Vf5BxlW4ms2FtKLbvAt5quFCFyMA1921 vNDb0nnlu7aDzDGpYSQrlkXfFBf+x+5vd/0997ET2geC793mhlzSilD2969pwOd/en5i nNYw== X-Gm-Message-State: ALQs6tCj6asiHUqcaR+y8EwZX1If/RO/Hh1T8U/Armd7JJt894XkKAXj sN6TIbbaVr3x1nJ2LAPqpv9BSzQSZnaAJt0j7eA= X-Received: by 10.55.209.211 with SMTP id o80mr27481738qkl.3.1524594941325; Tue, 24 Apr 2018 11:35:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.144.102 with HTTP; Tue, 24 Apr 2018 11:35:40 -0700 (PDT) In-Reply-To: <9e4fc4a0-370b-9101-2809-4040de58553c@gmail.com> References: <20180424071618.GB17825@kroah.com> <20180424074459.7215-1-k.marinushkin@gmail.com> <9e4fc4a0-370b-9101-2809-4040de58553c@gmail.com> From: Andy Shevchenko Date: Tue, 24 Apr 2018 21:35:40 +0300 Message-ID: Subject: Re: [RESEND PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit() To: Kirill Marinushkin Cc: Greg Kroah-Hartman , Eric Anholt , Stefan Wahren , Florian Fainelli , Ray Jui , Scott Branden , Dan Carpenter , bcm-kernel-feedback-list , linux-rpi-kernel@lists.infradead.org, linux-arm Mailing List , devel@driverdev.osuosl.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 24, 2018 at 9:27 PM, Kirill Marinushkin wrote: > @Andy > >> AFAIR I gave you a tag and you again missed it. >> Before sending anything just check twice if all prerequisites are fulfilled. > > I think you mix it up. This is a new patch, you didn't review it before. Ah, okay, send new version as a separate thread and if I have time I would review it. -- With Best Regards, Andy Shevchenko