Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF37D21774
Date:   Tue, 24 Apr 2018 14:50:56 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Wei Wang <wvw@google.com>
Cc:     gregkh@linuxfoundation.org, wei.vince.wang@gmail.com,
        Ingo Molnar <mingo@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Crt Mori <cmo@melexis.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] do not call trace_printk on non-debug build
Message-ID: <20180424145056.7c29ea18@gandalf.local.home>
In-Reply-To: <20180424180812.215900-1-wvw@google.com>
References: <20180424180812.215900-1-wvw@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 24 Apr 2018 11:08:10 -0700
Wei Wang <wvw@google.com> wrote:

> From: Wei Wang <wvw@google.com>
> 
> trace_printk will cause trace_printk_init_buffers executed in kernel
> start, which will increase memory and also show bad warnings in
> production kernel.
> 

NAK!

Where is trace_printk() being used to trigger this?

trace_printk() is to be added while debugging, but one should not need
to enable DEBUG to use it. But it should be removed when finished.

-- Steve

> Signed-off-by: Wei Wang <wvw@google.com>