Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C40D21774
Date:   Tue, 24 Apr 2018 15:26:07 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Wei Wang <wvw@google.com>
Cc:     gregkh@linuxfoundation.org, Wei Wang <wei.vince.wang@gmail.com>,
        Ingo Molnar <mingo@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Crt Mori <cmo@melexis.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH] do not call trace_printk on non-debug build
Message-ID: <20180424152607.71fbee34@gandalf.local.home>
In-Reply-To: <CAGXk5yriz2CtCN-vkL0q7gdpV+f8+9GJH-FT+v3KBLb-fWoCZA@mail.gmail.com>
References: <20180424180812.215900-1-wvw@google.com>
        <20180424145056.7c29ea18@gandalf.local.home>
        <CAGXk5yo44kAku+ZYx=8HzOgkEVC7ARNSER4MvWTCz-i51up=ew@mail.gmail.com>
        <20180424151416.397fbbde@gandalf.local.home>
        <CAGXk5yriz2CtCN-vkL0q7gdpV+f8+9GJH-FT+v3KBLb-fWoCZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 24 Apr 2018 19:20:03 +0000
Wei Wang <wvw@google.com> wrote:

> checkpatch.pl sounds good. One thing to add is we have many off tree
> patches with abuse trace_printk. Also as you mentioned, given this is
> really not for use in production and we have been cleaning this our on our
> side for years, could we consider to enforce this in kernel?

That nasty warning was suppose to be the enforcement. I would expect
nobody would ship a kernel where it produced such a message on boot (or
loading of a module). If they don't notice, then they are not testing
their code.

A lot of kernel developers use trace_printk() and I want to make it as
easy to use as possible. I don't want to add a config to enable it,
because that would be something that could be rather annoying.

Let's add it to checkpatch and see if that can draining the swamp of
abusers.

-- Steve