Received: by 10.192.165.148 with SMTP id m20csp5044233imm; Tue, 24 Apr 2018 12:41:50 -0700 (PDT) X-Google-Smtp-Source: AIpwx48pldAYq7BctLDfk/9AiNnVKOx4hcDcZ04zl+YxyeFr9jNSFxR5Uj9a9+V0/vPzIad6WC3j X-Received: by 2002:a17:902:758a:: with SMTP id j10-v6mr26465689pll.334.1524598910811; Tue, 24 Apr 2018 12:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524598910; cv=none; d=google.com; s=arc-20160816; b=E2CKEZrYwvUmeFPYkkwDp65L6NFf/8KxCeCiG+38/S9k4vPELg+ev+u00d6bqzSLux zXK6/8PzdYQVPhZMDIOWGQ7fqeov2RB3z74vE0dZMpE4aYXo/x5S0VCEYUENfmJPI+VU GiIcMh9d7eNKJ51vnsnCMZ+r6soUU02IiP7k+BdNZu+K8yWQkN4vhDckZX42wkfew69L r3xpzT7rdqicidKynNnx5ciV2TLGfqqBZLtd4SfEkXiEZyX+kCezY51B2Yx13BtUuPeN bfp1J9A9xsDZN3nW/PQO5ii3pVWf/ri5FQb2YuOGuWUyuVorNpg/EZt29WX/boVlpj0N 9gbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=lzSARTkMpICu5wsFtcd/uUR+MfNlKvYMf60OU2r0wHQ=; b=jFUQb//v3/km+pChIkHVR/QVRyBnKOkd0VmNZw+jzbSrP440DLt4GlEUYZWx+YUDD0 J3w1q7mS3xSYU+6xyhmRbEjkRkCWQLEr5Sj3H7W4gdo2bfte3pXAY3UUlwMMuDGwocRP cDuOBn6SKxXjpQ9vxYIBevzAgfQ3yYjk2k/DUUs1eV+KHwUzxts4lv9+Oo+PTjZBUoKL HptKEjsfgufJ2M8E5APBUB04Wy05HLyUxKAmp6wJwu0X0LRvdRgKtr59TOr7b/Q6yWvx 8wXFdv17WiFvtLGBudsPWCXCTqF0033t0qXZvxN6qiUjP7GeNK2cI4ktTkz1ZQYUuvL7 trXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o14si6855091pgf.174.2018.04.24.12.41.36; Tue, 24 Apr 2018 12:41:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751003AbeDXTje (ORCPT + 99 others); Tue, 24 Apr 2018 15:39:34 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:39372 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226AbeDXTj3 (ORCPT ); Tue, 24 Apr 2018 15:39:29 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 99EC61444D20F; Tue, 24 Apr 2018 12:39:28 -0700 (PDT) Date: Tue, 24 Apr 2018 15:39:25 -0400 (EDT) Message-Id: <20180424.153925.2063217911734444324.davem@davemloft.net> To: christian.brauner@ubuntu.com Cc: ebiederm@xmission.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, avagin@virtuozzo.com, ktkhai@virtuozzo.com, serge@hallyn.com, gregkh@linuxfoundation.org Subject: Re: [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks From: David Miller In-Reply-To: <20180423102443.16627-3-christian.brauner@ubuntu.com> References: <20180423102443.16627-1-christian.brauner@ubuntu.com> <20180423102443.16627-3-christian.brauner@ubuntu.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Apr 2018 12:39:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christian Brauner Date: Mon, 23 Apr 2018 12:24:43 +0200 > + #ifdef CONFIG_NET > + seqnum = get_ns_uevent_seqnum_by_vpid(); > + #else > + seqnum = uevent_seqnum; > + #endif Please don't indend the code like this. By indenting the CPP directives, which should be at column zero, the actual code became double indented. Thank you.