Received: by 10.192.165.148 with SMTP id m20csp5071174imm; Tue, 24 Apr 2018 13:11:02 -0700 (PDT) X-Google-Smtp-Source: AB8JxZplEWFtwNHl+ZPolYqCWha5OmkhocGnYQUPpJbRU0DWWsKFNKgqp9lhiOdRnCAo8QjFNKY6 X-Received: by 2002:a17:902:b906:: with SMTP id bf6-v6mr2726567plb.16.1524600662557; Tue, 24 Apr 2018 13:11:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524600662; cv=none; d=google.com; s=arc-20160816; b=SXcngnxI1GVCeVosOeRywgx8ocRYImW3wJzBzJVl46ILhBpjzJj8GRNm9NWAvx/Sco i5RdBwCsBmQA2KU7+dJ2sKYFwHgPQHQbIs2KWuk9MHTcnPQj24J5iaMsH8AWEqh1DoPI kOFEus0eOgn9x2FVhWciqoUQZ71Uy8cVk3wTl9LaE3i1lkANp1wJlwO4XC+yv84bDZW8 0khhe5aRu/DDxoPB/kDjEV7MrIAgAZa80xZzYSEWejORiaNnybrsM6m3MjrsErcBci9B QahXDCMExZr/dNWhcrobm6lvGSqliSuU3vMdeEMxCCzdxrxUQHOARnwDdqM0O1ci+DDM fngw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=0J8BVyusMeqDyNjhNAbUPxgSvpQ+UOU9AihSCoIaX8U=; b=oRQrFyYyyTfeILrsD2yx1gmMKAAdZPw4RkFNHJLyLm7oHPVASzl0EiJ64x0hC89UBU EXD2EBn+g+bcKOb5HKCyGEJ2LDUVdH27Up8PD4cGjiHLYUW+Sb1cCYFftTdLU1m4oNQx Op7OQ9j8NSdPCB1X6IJ3bnzHCs8LnwEuEmwgRbW3GxIsJpZyuMNyoral0DrdFiQQF9S0 1xs/mxgqvUNSk04uW/+oiIapeFxn3TnG0+0qvk6eoPOEYZrP7JZvYacPX6mMvBGUBMai yeFPlvo4nV1b2qCPxA8fm454ygpux9kmdwdCFGLYWLUQ/nsSuhCzwjfHNqzalGBzAA0C izkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bj11-v6si14761436plb.480.2018.04.24.13.10.46; Tue, 24 Apr 2018 13:11:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751216AbeDXUJf (ORCPT + 99 others); Tue, 24 Apr 2018 16:09:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:56152 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbeDXUJb (ORCPT ); Tue, 24 Apr 2018 16:09:31 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id F3583ABE7; Tue, 24 Apr 2018 20:09:29 +0000 (UTC) Date: Tue, 24 Apr 2018 14:09:27 -0600 From: Michal Hocko To: Steven Whitehouse Cc: LKML , Artem Bityutskiy , Richard Weinberger , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Cyrille Pitchen , Theodore Ts'o , Andreas Dilger , Bob Peterson , Trond Myklebust , Anna Schumaker , Adrian Hunter , Philippe Ombredanne , Kate Stewart , Mikulas Patocka , linux-mtd@lists.infradead.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: vmalloc with GFP_NOFS Message-ID: <20180424200927.GU17484@dhcp22.suse.cz> References: <20180424162712.GL17484@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 24-04-18 20:26:23, Steven Whitehouse wrote: [...] > It would be good to fix this, and it has been known as an issue for a long > time. We might well be able to make use of the new API though. It might be > as simple as adding the calls when we get & release glocks, but I'd have to > check the code to be sure, Yeah, starting with annotating those locking contexts and how document how their are used in the reclaim is the great first step. This has to be done per-fs obviously. -- Michal Hocko SUSE Labs