Received: by 10.192.165.148 with SMTP id m20csp5200426imm; Tue, 24 Apr 2018 15:49:49 -0700 (PDT) X-Google-Smtp-Source: AIpwx48UH24W6++sShZQw8SQ8w83WG0CwB5WQcHoZZJgc1Eo3i3QKZ8ciDzObQ+I7YLJHafXn33O X-Received: by 10.99.124.4 with SMTP id x4mr20905841pgc.67.1524610189725; Tue, 24 Apr 2018 15:49:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524610189; cv=none; d=google.com; s=arc-20160816; b=LdrQvckMpmTrEj8/DUB6WLs9x+6j5U4QuDTc7gmH936k4Xn0T3kPL3FZLBNGcnrlZG OwZJXLAhZNut+9oNAVnfWWrmpcKcl2pxtu9iEIwj19G1wi/e+jKb1gY8YB5/1uELRwTu a3fWL0VkQfpYt6a0e/MKCvIVoWC5RF9Ak89p/5McEYzGdHJi+bx9tcoRqoqy8FPlNAwi nrCks7sffZ13vvJd1hyZ4PP58flaoVYFBQCZGWmpVWgO8G+NazB628EMKVT+rxSgKrh2 D2fPAjINCAcJF9FhavewTtvO6h0KIVQzb4Zy02oTbz1IecAbFpGwaDWpBwfupAXYO9Qj GeUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=2umE+4rAEgxHfgOsOdTL4SsJs6bcxFkhVtT4sh1B8WQ=; b=AwAwvi3Y0VUENdeekq88+v+uTflqkJkl7/fem/nNj5KdYZrVEmkT/yJrTYrYzo0O7C hkHW3gufupJE6ncC0LsyNsd41S3IAF54YcvTJrdUlbbLoRnrs7diti5bJxPZl2GFOnbl rPEHJFZhuBz2qDJ1I05QHzEH9q40hY6M5JB9fQssn80dj0FOhhCrlYO7IPelSnGkuPSQ 3iEAYTKnJ3I5zM5frpz0WNpK8r175R5K2xFAEgtzd3zrSqvaKAEzdqlUUI4ExFsGYlE0 XGIlppGIcHu8vZH/06jFgbQ1r8Ekr4pkhz4D6M0SYisULiIGUGLoERC9kpAFnlmHgSQG t+tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=P5U7VULg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g34-v6si14649936pld.411.2018.04.24.15.49.27; Tue, 24 Apr 2018 15:49:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=P5U7VULg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751245AbeDXWqV (ORCPT + 99 others); Tue, 24 Apr 2018 18:46:21 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:34008 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbeDXWqS (ORCPT ); Tue, 24 Apr 2018 18:46:18 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3OMjjwO070109; Tue, 24 Apr 2018 22:45:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=2umE+4rAEgxHfgOsOdTL4SsJs6bcxFkhVtT4sh1B8WQ=; b=P5U7VULgs2ZRasczoh1RFDIrcQxxi0hqGW0OHTMOgWMzLLik4NfmUk+jawhPQlsGSQvD GyoCQureXwAZIuNpQtqnZYUGgVHIdXbRkxtaEHAiUvTUMbD17iCVdjXBVfujDUwn7vZX OHwIdM13g9l24cpFAHilFCWRqab0GAOVClgzzGkh2yCV6loaS/QMu2dixTynEd0Sw/sn +/G5s+dd/1N30mS/ZCaoXST6vE9mgNKxIrRii7vtjhwG5bqm1N+jsTnrfYBucKyUBszA ULaVFzcLR+cPbF58dCV2x37SWoWJ+zoab1ylSotniQK9/0dCMDArqQ7ST/CN3Bye2zol aw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2120.oracle.com with ESMTP id 2hfw9ac8dw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Apr 2018 22:45:45 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w3OMjhNq017252 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Apr 2018 22:45:44 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w3OMjhVI014411; Tue, 24 Apr 2018 22:45:43 GMT Received: from [10.132.91.87] (/10.132.91.87) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 24 Apr 2018 15:45:43 -0700 Subject: Re: [PATCH 3/3] sched: limit cpu search and rotate search window for scalability To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, daniel.lezcano@linaro.org, steven.sistare@oracle.com, dhaval.giani@oracle.com, rohit.k.jain@oracle.com References: <20180424004116.28151-1-subhra.mazumdar@oracle.com> <20180424004116.28151-4-subhra.mazumdar@oracle.com> <20180424124855.GT4082@hirez.programming.kicks-ass.net> From: Subhra Mazumdar Message-ID: Date: Tue, 24 Apr 2018 15:48:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180424124855.GT4082@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8873 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=625 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804240214 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/24/2018 05:48 AM, Peter Zijlstra wrote: > On Mon, Apr 23, 2018 at 05:41:16PM -0700, subhra mazumdar wrote: >> Lower the lower limit of idle cpu search in select_idle_cpu() and also put >> an upper limit. This helps in scalability of the search by restricting the >> search window. Also rotating the search window with help of next_cpu >> ensures any idle cpu is eventually found in case of high load. > So this patch does 2 (possibly 3) things, that's not good. During testing I did try with first only restricting the search window. That alone wasn't enough to give the full benefit, rotating search window was essential to get best results. I will break this up in next version.