Received: by 10.192.165.148 with SMTP id m20csp382280imm; Wed, 25 Apr 2018 00:41:36 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/Hn9uE4ggNJUbuQwgNrnrEd5DSPkM4tQnAYvZ9TqXD7k522/KRhxfJQWCVMawPYExnYrAW X-Received: by 10.101.64.70 with SMTP id h6mr23136551pgp.135.1524642096215; Wed, 25 Apr 2018 00:41:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524642096; cv=none; d=google.com; s=arc-20160816; b=sQFT6mGPIv8rfOYr2NOYiYxm1fsGOXRAhotjLmsZ6Dcjna9FPCVR6V48uDvo8Ze7JP uTes4ghRc7ch1iZQof3txVFramZq9ZiO90jaPrPuMWJ4FrqHWpuAoi9sQVb1bpsFj9MW 5D0/EuIb++S07ayvZv5Pq4/omKKAggYMRftCptLEj9nsbEsdTGOomWDkvnfJT1z5BkOD CiR2sIKfXLa8mwakxIKYqmXt4WM4wFJVKGxr5Jsdo0ftVKm/wL76CuBSONwD5DbPxraw pRv6kZNeJYl15+qTpVN+iSF1P7HS702m9QRxLX6VSvx77/ANX8FHOykAqqqGpuDCC0Y4 /Paw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=Pa+soTHg1Njy2Qs6K/vXco+l4P5nE3pMpHmnjt5T0jk=; b=zj1Fq9WJ7LsBPkU+DB15G4t3QC1itOCu3ks8NUBqKYDpDIRXzQuUWDxiNBc6S9Tsr8 bk+9JEKsrn3Alz2XDTYeBbGoZzqZos/Pnh61tT2D0DZ87fTcRbFAtmIy0rxR/IZ4zjrY DZPd8lWzmKaz6sco0BGEhtMCMJ6rkQjlrJbdxdAEayb06SuXESJ99VacHq3x8Hy/UYrG T/XHKvxYfC10CET9e+Jlx7JgVNyCKphdypHvdcwxiRRtnLeO+LU8NS93Ny6azoFo7DlD ycVqJNKCDkjwosHY+PNgXTBimuW1gTuAZJOKB0gH40O8/gSME/U6CQTUtnn7/rr1N7rL AaHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=ef+MZFsY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k19si14582887pff.41.2018.04.25.00.41.20; Wed, 25 Apr 2018 00:41:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=ef+MZFsY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751255AbeDYHkH (ORCPT + 99 others); Wed, 25 Apr 2018 03:40:07 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:39820 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbeDYHkG (ORCPT ); Wed, 25 Apr 2018 03:40:06 -0400 Received: by mail-wm0-f67.google.com with SMTP id b21so5017657wme.4 for ; Wed, 25 Apr 2018 00:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Pa+soTHg1Njy2Qs6K/vXco+l4P5nE3pMpHmnjt5T0jk=; b=ef+MZFsYnlkCm/OMohF09KEcVnlcOBRluyxJlEv8MkSgaDLRb3IXXr05SwwTGyleh2 kvBItv5qByhF/ND6MXmoA5yNlIn9UowDh24GNp2TnQUO/4z/tBn4Qs4dsWt1fQUiYSNW kqpPKZ+5H+C4aGBuZU5XVYWwwv0KnbaOHpP5A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=Pa+soTHg1Njy2Qs6K/vXco+l4P5nE3pMpHmnjt5T0jk=; b=edPo2Bx9lRO4dnNjAWkMJ7aFiUJIDwY6c5rZZ4YObu2+dWB9/b2evHh6btG22yjwii m53nYq4QmrkgMvj0H8HXhPcweyZZkLB6EVbQNka02D2MJvfYqUl0vCnjupxfDUqZwTXR cULqvLq4oVXvhcm5b4WEciCa7RAVIp0u1zpkmDupeWUPJnyeTfHMwys78s9579h1UCAG ZjohSd7b5FdHB/wZidD8DE7A9pxXvhhdxFB0VzbDjhCoN3Up2QgxASGCUUJo+4PyoT1J Z9NPFn3wZJI8RJIZ3RGMBRA/Ay+U/qROiACb1tF+RUgPamvjc6n/tSJeZkAbNcXPkSvT SdQw== X-Gm-Message-State: ALQs6tC6UYkAzUikPVIbgeAzjCYmKwCPCnFs5afaw50W3AdtosxDR8rV L8wSess2yuVlOFiMRXlCcuc8Iw== X-Received: by 10.80.166.152 with SMTP id e24mr31080525edc.2.1524642005243; Wed, 25 Apr 2018 00:40:05 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5635:0:39d2:f87e:2033:9f6]) by smtp.gmail.com with ESMTPSA id 60sm8695161edy.10.2018.04.25.00.40.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Apr 2018 00:40:04 -0700 (PDT) Date: Wed, 25 Apr 2018 09:40:02 +0200 From: Daniel Vetter To: Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Gerd Hoffmann , virtualization@lists.linux-foundation.org Subject: Re: [PATCH] drm/virtio: fix mode_valid's return type Message-ID: <20180425074002.GP25142@phenom.ffwll.local> Mail-Followup-To: Luc Van Oostenryck , linux-kernel@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Gerd Hoffmann , virtualization@lists.linux-foundation.org References: <20180424131524.2510-1-luc.vanoostenryck@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180424131524.2510-1-luc.vanoostenryck@gmail.com> X-Operating-System: Linux phenom 4.15.0-1-amd64 User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 24, 2018 at 03:15:24PM +0200, Luc Van Oostenryck wrote: > The method struct drm_connector_helper_funcs::mode_valid is defined > as returning an 'enum drm_mode_status' but the driver implementation > for this method uses an 'int' for it. > > Fix this by using 'enum drm_mode_status' in the driver too. > > Signed-off-by: Luc Van Oostenryck Ok, applied all the others that have been stuck in moderation or something, except for any patch touching nouveau/radeon/amdgpu. Those need ot go in through other trees. All merged into drm-misc-next. Thanks, Daniel > --- > drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c > index 8cc8c34d6..a5edd8660 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > @@ -208,7 +208,7 @@ static int virtio_gpu_conn_get_modes(struct drm_connector *connector) > return count; > } > > -static int virtio_gpu_conn_mode_valid(struct drm_connector *connector, > +static enum drm_mode_status virtio_gpu_conn_mode_valid(struct drm_connector *connector, > struct drm_display_mode *mode) > { > struct virtio_gpu_output *output = > -- > 2.17.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch