Received: by 10.192.165.148 with SMTP id m20csp417973imm; Wed, 25 Apr 2018 01:27:49 -0700 (PDT) X-Google-Smtp-Source: AIpwx48pig7a8t8IHJ3GfBlo7eg2XfL1LsWpP8iltq8BeYgkk/CCa5+kRBzBDeBx0Pd1QHq0uRHx X-Received: by 10.167.130.151 with SMTP id s23mr27022228pfm.106.1524644869060; Wed, 25 Apr 2018 01:27:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524644869; cv=none; d=google.com; s=arc-20160816; b=xdetP/LbtCY6w064hn7GxUQXgFvdirC+JJ5haBOxy1Q1yLghuHhpwhvm93hckisiIp aVOufydoLqbAtIQU4RYgIpkuvQqj3SNSbj+6MjcRviSCy0ZrZLuJ2RPwwSTaC1Ho5J7E NiZJo3Xh0TTwS8nNcy6RggKp4UBChAXAUR/A5mLv1a/Z1KQmQ8eeOLTM+/Zyo6MmaWlM nxSChew3Q9Oit+S9TbKUYrINFyergT6BhsQBSV9fREEtEbH4KkGAyXhYNHOBslC2Y3oc zdZ3CHGOG9VGiYrUh8L6ByoZIgDekOnX0ZRtNzAsSrc8SiESHcrOuWSKYZprEycnxMNl +jeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=DJ3JMgfQVnRWsGkOA1r1BDA8S4RyLQhOCl98D/d9ruo=; b=PfpGfsRzKR8bOahHihMMDXxYZgMaikoLzGsVUlBsoMlm2XC5TsqDhwd+02t+XQxLv9 MLzBMbFII6ykAEY7MPoc1LtzlYaGNcgRhpud2N3CEwr3ZowY9cRI7u79ut/B/2Bab2YA ly437SDJ1rmXjUCoTQTwO2zRBBcdiRxKDqJ3bP+/0Dd2/yPVnX2Xi2k8fwLUykxdAeJT oDfC3IfgKQABC3/2ZFffx7PM0hovSNNW1FgXob6h+K4mshEQVNRFT2Vs6WHEe6lXfcYj vQsGnoiPtjkjuLN4+CGOym+0Z17JaK7kVzflP41YE4XWh9QXVy1UF/jGygYXJezN62/f vcKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=X0GckrTh; dkim=pass header.i=@codeaurora.org header.s=default header.b=BuzttWpR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r5-v6si16024177plo.414.2018.04.25.01.27.34; Wed, 25 Apr 2018 01:27:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=X0GckrTh; dkim=pass header.i=@codeaurora.org header.s=default header.b=BuzttWpR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbeDYI0b (ORCPT + 99 others); Wed, 25 Apr 2018 04:26:31 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51270 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbeDYI02 (ORCPT ); Wed, 25 Apr 2018 04:26:28 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 498886070B; Wed, 25 Apr 2018 08:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524644788; bh=tuD9VdStr1FcjHNrJNdDo/7XxV2Wc1OjZq9L7k3JBhk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=X0GckrThNuO5YZZy7V+dMH05EvJWIctS67PbjHn80/zf3pMdBZ7UsY5TQrhzHXUop kXizqTNs27gWIaCu6C6AuV527W9u4LsPqJnoJlgMTvRQVFYH6I8rBXpW03JAL1fgi/ 6vHMv+2l8KX1TDOfKCbiBu6SZPe8AY/RdKjiyx+o= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2384C60392; Wed, 25 Apr 2018 08:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524644787; bh=tuD9VdStr1FcjHNrJNdDo/7XxV2Wc1OjZq9L7k3JBhk=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=BuzttWpR7DyfEcNVxKc4RtE1Y3RiIOMoFZ81Rm06ll08QcmPrcuUHmo0ldPIMHlJM hmYEuEKXLA/RsIstQOSGyMLlh4Yygnm0F1wdmOJDE+a2lGM0bZrbtkkGm3kYguEwNf TxZZGFV9a25ouEwd6VHXMvK3arZu4AwUIcGxNY2A= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2384C60392 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler From: Kalle Valo In-Reply-To: <20180405154949.GA32223@embeddedor.com> References: <20180405154949.GA32223@embeddedor.com> To: "Gustavo A. R. Silva" Cc: Igor Mitsyanko , Avinash Patil , Sergey Matyukevich , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180425082628.498886070B@smtp.codeaurora.org> Date: Wed, 25 Apr 2018 08:26:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Gustavo A. R. Silva" wrote: > In case memory resources for fw were succesfully allocated, release > them before jumping to fw_load_fail. > > Addresses-Coverity-ID: 1466092 ("Resource leak") > Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") > Signed-off-by: Gustavo A. R. Silva > Reviewed-by: Sergey Matyukevich Patch applied to wireless-drivers-next.git, thanks. 376377004464 qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler -- https://patchwork.kernel.org/patch/10324855/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches