Received: by 10.192.165.148 with SMTP id m20csp441311imm; Wed, 25 Apr 2018 01:59:58 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/SjkicZ2aP30IHA0nWBpN7OS2j6EQBjTKh3JT5qdJt6CIuzm37ZxWW9wnGwkltOSwkG6zB X-Received: by 2002:a17:902:c24:: with SMTP id 33-v6mr27822962pls.88.1524646798877; Wed, 25 Apr 2018 01:59:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524646798; cv=none; d=google.com; s=arc-20160816; b=OeNGhy95BwCv4ji0EcI+DIn4Cn72nkY210LYbBlClFYurSA7auvjtLEORQyp3w5LAP 0y22PXo0/iFhMYgDvtk5nJLJ6NEynnHZu0a7CwAW3jsi36Pg5d+sIl24Tfl3yZ4VR/CD +ats6cbPOCHNelU/hYAGPDIgf0pit9maIm1fAVdNpXndBzTbndfhottgUK157uEzVkBF FIkd7Rhl5HakSf6iwpHGj4SoRZ1lHGX0VW2jIvYT9jky4k0xqLUqvL364g415lwlOrW0 GqnHKfCIas2s5RIU/mjEt4lodtAJAQv4T+ursLBAIO56zkoTtE0x/i3T2WLtWNEWdj1/ UdMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=PdPXDULNfDjhhFk5U8vRkUxYFerdAR0Q6Y2+ADwBRXg=; b=iI3Q/TIYgvluZqGsk9j0iXS1BRhTdk/d4n+Sakqps13JzYlxhTVwcz0UmOvYMXdgw4 igsnxjIvrOgp0JbD/fueWHd3vNDqONEcV6BVkCxtMlLAycVWU3Kbbvm5mh/tQKWvkeQz /mwG+nUo0km2FJM7/dbHRKep/wqd8Na5ih/MEfkiEf5ACISxTBCsVY08dNFY9Q0NhNqI NVRE7uFbKHv31e+8t7nSIRf++5gmzul4GFudhLWCVia2eGvS2moiG5jdmzYwZUxfLd2q 6J8rqSkmrpVZYMk/GLVS3vJYQDXUOXBUn8910PGZa8pNZUi5AqLO0vodtZGVNKaiw3LV Mpbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o4si12806437pgd.125.2018.04.25.01.59.44; Wed, 25 Apr 2018 01:59:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbeDYI56 (ORCPT + 99 others); Wed, 25 Apr 2018 04:57:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40916 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbeDYI54 (ORCPT ); Wed, 25 Apr 2018 04:57:56 -0400 Received: from localhost (unknown [37.168.186.153]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 5D3782C; Wed, 25 Apr 2018 08:57:55 +0000 (UTC) Date: Wed, 25 Apr 2018 10:57:49 +0200 From: Greg Kroah-Hartman To: Johan Hovold Cc: Rob Herring , Mark Rutland , Andreas Kemnade , Arnd Bergmann , "H . Nikolaus Schaller" , Pavel Machek , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/7] gnss: add generic serial driver Message-ID: <20180425085749.GC13295@kroah.com> References: <20180424163458.11947-1-johan@kernel.org> <20180424163458.11947-4-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180424163458.11947-4-johan@kernel.org> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 24, 2018 at 06:34:54PM +0200, Johan Hovold wrote: > Add a generic serial GNSS driver (library) which provides a common > implementation for the gnss interface and power management (runtime and > system suspend). This allows GNSS drivers for specific chip to be > implemented by simply providing a set_power() callback to handle three > states: ACTIVE, STANDBY and OFF. > > Signed-off-by: Johan Hovold > --- > drivers/gnss/Kconfig | 7 + > drivers/gnss/Makefile | 3 + > drivers/gnss/serial.c | 288 ++++++++++++++++++++++++++++++++++++++++++ > drivers/gnss/serial.h | 47 +++++++ > 4 files changed, 345 insertions(+) > create mode 100644 drivers/gnss/serial.c > create mode 100644 drivers/gnss/serial.h > > diff --git a/drivers/gnss/Kconfig b/drivers/gnss/Kconfig > index 103fcc70992e..f8ee54f99a8d 100644 > --- a/drivers/gnss/Kconfig > +++ b/drivers/gnss/Kconfig > @@ -9,3 +9,10 @@ menuconfig GNSS > > To compile this driver as a module, choose M here: the module will > be called gnss. > + > +if GNSS > + > +config GNSS_SERIAL > + tristate > + Maybe a real help entry? Or is this only selected from child drivers? I haven't gotten that far in the series, sorry...