Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263377AbTHVSdG (ORCPT ); Fri, 22 Aug 2003 14:33:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263443AbTHVSdF (ORCPT ); Fri, 22 Aug 2003 14:33:05 -0400 Received: from bay-bridge.veritas.com ([143.127.3.10]:13404 "EHLO mtvmime01.veritas.com") by vger.kernel.org with ESMTP id S263377AbTHVSdB (ORCPT ); Fri, 22 Aug 2003 14:33:01 -0400 Date: Fri, 22 Aug 2003 19:34:41 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@localhost.localdomain To: "David S. Miller" cc: willy@debian.org, , , , Subject: Re: [parisc-linux] Re: Problems with kernel mmap (failing tst-mmap-eofsync in glibc on parisc) In-Reply-To: <20030822110144.5f7b83c5.davem@redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 22 On Fri, 22 Aug 2003, David S. Miller wrote: > > So the proposed patch looks bogus to me. And to me. If VM_SHARED is set, then __vma_link_file puts the vma on on i_mmap_shared. If VM_SHARED is not set, it puts the vma on i_mmap. flush_dcache_page treats i_mmap_shared and i_mmap lists equally. Might the problem be in parisc's __flush_dcache_page, which only examines i_mmap_shared? Though it's odd, I'm not keen on changing do_mmap_pgoff's usage of VM_SHARED in a hurry: it's worked like that for years, and other things (I forget) depend on it. Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/