Received: by 10.192.165.148 with SMTP id m20csp471994imm; Wed, 25 Apr 2018 02:37:03 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/JHBZ39XbjHC17y24ljO2dnmd+r9i9WdCuCgAYzn+A27lUwH6sAKOfZPoJjgXNdSIuSyba X-Received: by 10.101.97.72 with SMTP id o8mr23509184pgv.120.1524649022991; Wed, 25 Apr 2018 02:37:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524649022; cv=none; d=google.com; s=arc-20160816; b=tdbFBzHC8/64pj+Mi4jnaRCczvzeHL0JousOcMGsNLJ0OE3U2vrlTrb4WmQvC11W3G ebtYlaK3Noz/bbn/+h9HidPoiWE+kr3TVglH8qtpvxaaA+w9MRrGgPDM/bMaoPAcbnZv 3uAvHuRX6ajCTLPQXzDbu0mOY+hIPjBnctik7Yvw+0WCkXJjPJbMchpfL+JXYkCvA0Gv lnpBdJkg69rONtn3ue09SqX0MmGxc8WdqiXFa0tSMwWkvJ4PY3vldXrrMtZMETIKDqrt CRW5rgcxIp6Q4txCQb3zC40bBvTaRQ7D1njY/UsUpcx//InHSm2tdYJZM9wWKpOnO7VI HJqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=78fP4KAX9ys0bdTMoBZ0QKm64lRBqrLtITKHNtcOIZw=; b=I3v7stsA7pPoS5yiSwnx/S3RL10rsYW0QSWLu6ZHPq/CB0sII+c38oxitjE8MU4bDt 8RziiPUyO4OKwb8diyRzs2FX2io96NSgGpXRAMqYWRoB0Zd1YwrhjjYeKn1cWYzfLU9F BD2Bj3QmZXv4z8WU4KQtVYcoh6IIof7/DncObPUJHlGqV2tDY+SGSIa8jhhELJXZco5C Kl0Ui9kqmvP2X1/yqOqIB4bKc8FKkc9n8R89F7JMYpCZLnxd+60OH9ehIYZsCgBYGjAR DYN7kE9htMXPqKs4q6egn5p84gv270a/x167wtVirD30FqqYJBH+KCdzX19Y1mb2tQXM Rnxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d19si13432172pgn.379.2018.04.25.02.36.48; Wed, 25 Apr 2018 02:37:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752349AbeDYJfK (ORCPT + 99 others); Wed, 25 Apr 2018 05:35:10 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:56217 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751573AbeDYJdE (ORCPT ); Wed, 25 Apr 2018 05:33:04 -0400 X-UUID: 71d33eacd3c04aa183b88cd6320d69dc-20180425 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1693998456; Wed, 25 Apr 2018 17:32:51 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 25 Apr 2018 17:32:49 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Wed, 25 Apr 2018 17:32:49 +0800 From: To: , , , , , , , CC: , , , , , , Sean Wang Subject: [PATCH v2 10/17] rtc: mt6397: remove unnecessary irq_dispose_mapping Date: Wed, 25 Apr 2018 17:32:36 +0800 Message-ID: <6354082fb42b560b4f0a7d8ed32e7ae274d624a9.1524646231.git.sean.wang@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Wang With the patch [1], the job irq_create_mapping had been moved from the rtc driver to mfd core, so it should be unnecessary to keep irq_dispose_mapping in all paths of the leaf driver. [1] http://lists.infradead.org/pipermail/linux-mediatek/2017-September/010455.html Signed-off-by: Sean Wang --- drivers/rtc/rtc-mt6397.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index efb9370..398bae5 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include #include @@ -336,7 +335,7 @@ static int mtk_rtc_probe(struct platform_device *pdev) if (ret) { dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", rtc->irq, ret); - goto out_dispose_irq; + return ret; } device_init_wakeup(&pdev->dev, 1); @@ -353,8 +352,7 @@ static int mtk_rtc_probe(struct platform_device *pdev) out_free_irq: free_irq(rtc->irq, rtc->rtc_dev); -out_dispose_irq: - irq_dispose_mapping(rtc->irq); + return ret; } @@ -364,7 +362,6 @@ static int mtk_rtc_remove(struct platform_device *pdev) rtc_device_unregister(rtc->rtc_dev); free_irq(rtc->irq, rtc->rtc_dev); - irq_dispose_mapping(rtc->irq); return 0; } -- 2.7.4