Received: by 10.192.165.148 with SMTP id m20csp519930imm; Wed, 25 Apr 2018 03:33:33 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+9AURrmXJjYZsW3Jo9PtSvGIuZhCVEGhRrSj/ey0lyTvD/MNi5cMJpNRQdWXs8icSwZMNU X-Received: by 2002:a17:902:1681:: with SMTP id h1-v6mr28570911plh.145.1524652413451; Wed, 25 Apr 2018 03:33:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524652413; cv=none; d=google.com; s=arc-20160816; b=kilNNjApV9weE82XqB0UVzR7LwBYRwd451X2rgOe4svY7+qmj191i3vU6dGaGllUAU 8jYh053zRnVsmJxFG1uc/4wE6w2i9CTH9HgVpIGqwfks4nXJRzZwEpBpKJpxaXEn9t8V JuvFEWtuPfVR5rkJolPQcrSauubHZb/vVb8yir1zjbXdUZkWXCoFSpqSlZPPPGmlCxkC vKeLfq+Sqf/wv+OfCYycdDPjDyAPdLLUEtUH8fgyFRrB/EUq5vKpOrls44SrJ5owKL2t eAIhnIy2UlTLEK/5mBG3DBZWrHqI9wTI6mdc4Td3rNTqagL38d0FLZ7rly6j4P0eugg6 xULA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=qNRu6Y2ds6Qvij9vlNKhZPa7jS+fvRHp06vKNP0Cw1U=; b=03oA6OLRmpe/DBPxfJkwKVP0chg8S5H4bO4OjLuYxaZhuOVJ9Ik0R3MeX9sUXLR33w S/8LI7BFXvxs3WVHFBcBgW7iGT3BxlEKLjuTAudSbjq2O3Fsop6jeWiPzHyrzyqZEetc nEjIhcqmFhH10xTSLuGs7Aki6Rx7GJyDxWyzPV0Bzc8hzeBUF2uGDYzdm+wcRcrVD7Qo zdm425Z/hkST5/u+/OCwu9IWhMw5Eil8Tn1pNGE92P4drbuc9SA0ugmZQTUKWpnEvu/g k4WMXtpvZwIPuJhQG/3Ivhx1Ijpol0W4xrgjQgWgCF7he2sqXsDrPkBYwAPozLvMpZZ3 xfyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=YipZ338R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d16-v6si15744865plj.57.2018.04.25.03.33.19; Wed, 25 Apr 2018 03:33:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=YipZ338R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752754AbeDYKbv (ORCPT + 99 others); Wed, 25 Apr 2018 06:31:51 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:36850 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752661AbeDYKbn (ORCPT ); Wed, 25 Apr 2018 06:31:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qNRu6Y2ds6Qvij9vlNKhZPa7jS+fvRHp06vKNP0Cw1U=; b=YipZ338R3ZKS4fWQcH700Pr8r dfahyQjJtuRpRah4eCX5K8Nnhr6xJJfCo0WoZFKRk16BnakVKRgGQOe5teqSYHpaedHBBI8CKHJ7Z qIEEnh1kkvYHcab0AE2LGJdq0cBl6mdymXQy9fPDZYf6hsQ7PAaC/9a/6HiBmZYCN2Wjg=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fBHi5-0001z1-CB; Wed, 25 Apr 2018 10:31:37 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1fBHi4-0007vj-R2; Wed, 25 Apr 2018 11:31:36 +0100 Date: Wed, 25 Apr 2018 11:31:36 +0100 From: Mark Brown To: David Collins Cc: Doug Anderson , Liam Girdwood , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, Linux ARM , devicetree@vger.kernel.org, LKML , Rajendra Nayak , Stephen Boyd , Matthias Kaehlcke Subject: Re: [PATCH v2 2/2] regulator: add QCOM RPMh regulator driver Message-ID: <20180425103136.GB24769@sirena.org.uk> References: <4b45f41996ea3344340e44fab2dc9e487572e209.1523673467.git.collinsd@codeaurora.org> <4e3353fe-ebb5-46bb-aa58-49ad04c4d9db@codeaurora.org> <132ab845-52d6-6192-4d8c-5a9c95410688@codeaurora.org> <20180424174507.GI22073@sirena.org.uk> <20a8f736-2687-f14f-eaa1-2b2c06eed629@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="61jdw2sOBCFtR2d/" Content-Disposition: inline In-Reply-To: <20a8f736-2687-f14f-eaa1-2b2c06eed629@codeaurora.org> X-Cookie: MS-DOS must die! User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --61jdw2sOBCFtR2d/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 24, 2018 at 02:09:47PM -0700, David Collins wrote: > On 04/24/2018 10:45 AM, Mark Brown wrote: > > I think that's probably only OK if we have a specific error code for the > > regulator being limited in this way otherwise our error handling for I/O > > problems involves us trying to reconfigure supplies which seems like it > > would be risky. =20 > Would you be ok with -EAGAIN being used for this purpose? Using -EAGAIN for "I can't ever read the configuration from this regulator" doesn't seem right - it's not like any number of retries will ever manage to read the value back. --61jdw2sOBCFtR2d/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlrgWQgACgkQJNaLcl1U h9CaXgf/Q/MwyAoaIjFMN2PKQ2kvD4bf+TtknHQxwyTJe8DhZ1KG6bDPRPYu4zSD wsjpmoC5UcAnCZ9Zq1GIN1A4ZAUfhqC9UOl5S9Tgru9uH3uyblVYeL55mSaWJQqx Bcx8CYxJvbPMlCSGWtMIPotPEjf1skQE9xk8J7MknVhtD1eTYXSbtbZmGxhkBWwV OIzTqm5GMHzu2gYM+On/PghyGZA+4HyM7zoToa3OUr3pVwJfg2PYuFo80dctWreQ LGfubHGSrzrlmNTAmXfVBESqlwuVCizvqiLMiQQTX3jn1Qx3uyNt7L86qPyCn7sT bTPkBAnji/iVVJ/a+Gfsn/W8ibLXsQ== =E/2W -----END PGP SIGNATURE----- --61jdw2sOBCFtR2d/--