Received: by 10.192.165.148 with SMTP id m20csp550073imm; Wed, 25 Apr 2018 04:06:40 -0700 (PDT) X-Google-Smtp-Source: AIpwx49QyS1+1QJ9ASSukgNZqZevwIuKTqno9aLOCc6lwLrScrywpO1BYbf8Xgmgwn1kbWCTL81H X-Received: by 2002:a17:902:5ac6:: with SMTP id g6-v6mr27658641plm.262.1524654400545; Wed, 25 Apr 2018 04:06:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524654400; cv=none; d=google.com; s=arc-20160816; b=m9BAvHjfk36cgivpxB1pDZTKndiJA+sIn9EQ2TyHJbCxWUTFjJlvbyBTL1rM6YUE+3 XgAr0vnE/jMaD2JuGUAS1sWO9yx83TSWnvvpM8da+g8XUDgd21LM6s7GloDBOCPM0ZRF OfUJZiO+06/t8PdFbgMfOdj+GqtRowC7RQ4X4pBPQXRoocnrmaM9RDKJs8iJtN50DUBv EtAmfm21EAehxyzYqhEKqlyGIMxJE/kGk4gCP6lKdVS2n/Kk9Jr5mE8B23sBSzAe2ViB 71xo9duOZ5oCUDEHVlulph/dxibVYW8eyzrQo7xVquEfrjNfnq1ibIP4v8IodFI3vGlZ fEbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=YOjjDwukirNkiq95A0hYweot+KzU92s1CuPME+3pGok=; b=d1Hcm56U1KJn6gYwGVaTk3bOxgvJFDE9GU+M19PpAzOWppsexQdTCwQL/2t4U8ZU9N g06M8L7xjP972/onFpNHWX7FfwdOLJ1xuMss4eEHpFfh8z+/TtuBSUf3nECN1vW2FV0/ V6M26unCRL+r7SOUgSLCJtf6/NaaqewE+aF0zFgXwn7k7aTdEonsPzz7B2/ICK0RIcUg uMESXCnfO6qyIpDvQWz2YOYymwKSFuyNcIh3ob+0KayWENOaZ83RIzSvXPGMjZ7MqlJJ gfP7vsNgqm20RBcLj1j5H6X2On3JKQrtcywkxxtmSI2VVGUdMzZCN7jERsQENv71yYz3 +CYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=pFzUlvRF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k11-v6si15056217pls.368.2018.04.25.04.06.26; Wed, 25 Apr 2018 04:06:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=pFzUlvRF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754345AbeDYLF1 (ORCPT + 99 others); Wed, 25 Apr 2018 07:05:27 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34205 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754068AbeDYLFV (ORCPT ); Wed, 25 Apr 2018 07:05:21 -0400 Received: by mail-lf0-f68.google.com with SMTP id m13-v6so10632222lfc.1; Wed, 25 Apr 2018 04:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YOjjDwukirNkiq95A0hYweot+KzU92s1CuPME+3pGok=; b=pFzUlvRFwFiQeFt/Eo9OYOPYPtVcDNWP5/jxL3sNcY2QZeCVd1VAxJWJwoDpZTTTf8 CNOKsXU43wuqkvdKHTJDgXyD4lTWR5BkZElqF2UZH2rdNeGRvipBc9KyqOnmrTm5as+V PVdGggmtl9MDDQCD1xSph0BzWLflouQS3NnsoZaPTO65m2meSdpjda7jVpXv/83RVL13 PibQukJQglpq+5s1WLQVXnpbgFSwrMviOd/mefGBO6Prf9woawpQZ/DkdQigoYR1cX8U 46SQv2hGm82t0Fi0dYnPEcnOgpztg0KI4HZTGOCuzEFZb28GxbsH+Xhz3+ERMUnyIeOQ JE8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=YOjjDwukirNkiq95A0hYweot+KzU92s1CuPME+3pGok=; b=EH10TPQZAJwCsW5agIW512jzlAlF6WA0BVyNvJ/SNtr1I3+hhlpv3Axr5sj32Zcb/4 Ry54gDHuMSO3/D50EPCC+OaiC3xNpAajpUY6bib+1c4aPwZmw7gIO+Fag+OE/RJyx6cc 9rrNVzpNsrNlJLotv5h8cE0+qulmf7t56NNpiIrvYEMuuxI3xb9rvaUxFB+tVPO4TmsR ZbkVwQ9yXYG/jP8WghF2OF/8co1zAuf2n22ibJz0YSaHBNMNT6wSykoDtnh3Wx2I14er treuptiNBsRvGfUPhIj3nyavMLbkQRO2sPU+Qx813tNUyCVvI1pcV/IuFmFvijsUXK5q 6aIA== X-Gm-Message-State: ALQs6tBNuYRYCs0AMphhRIKd0zexS4a8oAm5Ap4t3nB/k792hpxR0Hd2 Dik9MIe65HUriwm4c7psqc6SEsGr X-Received: by 2002:a19:c457:: with SMTP id u84-v6mr14595655lff.109.1524654319884; Wed, 25 Apr 2018 04:05:19 -0700 (PDT) Received: from xi.terra (c-8bb2e655.07-184-6d6c6d4.cust.bredbandsbolaget.se. [85.230.178.139]) by smtp.gmail.com with ESMTPSA id y24sm2997976ljh.88.2018.04.25.04.05.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Apr 2018 04:05:19 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.90_1) (envelope-from ) id 1fBIEZ-00009P-MT; Wed, 25 Apr 2018 13:05:11 +0200 Date: Wed, 25 Apr 2018 13:05:11 +0200 From: Johan Hovold To: Greg Kroah-Hartman Cc: Johan Hovold , Rob Herring , Mark Rutland , Andreas Kemnade , Arnd Bergmann , "H . Nikolaus Schaller" , Pavel Machek , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/7] gnss: add generic serial driver Message-ID: <20180425110511.GR4615@localhost> References: <20180424163458.11947-1-johan@kernel.org> <20180424163458.11947-4-johan@kernel.org> <20180425090031.GD13295@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180425090031.GD13295@kroah.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 25, 2018 at 11:00:31AM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 24, 2018 at 06:34:54PM +0200, Johan Hovold wrote: > > +static inline void *gnss_serial_get_drvdata(struct gnss_serial *gserial) > > +{ > > + return &gserial[1]; > > +} > > Oh that's the best hack I have seen in a long time. I need to remember > that one for next time. > > Anyway, in reading this driver, I don't think the module reference > counting is being handled here, so you might want to add that to the > gnss core to keep things from going south if modules are unloaded. As I just mentioned in my reply to your comment about module references in core, I think I got this covered through the hotplug support. Devices can go away at anytime, including through a module unload. Thanks, Johan