Received: by 10.192.165.148 with SMTP id m20csp562831imm; Wed, 25 Apr 2018 04:19:13 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+EyTe0J06Ks68QCcduQKDyiye2n0/P/S5OauRCCaQAnAVzuOZvznY5+neAtttzH6J7DfT7 X-Received: by 2002:a17:902:708a:: with SMTP id z10-v6mr29469783plk.315.1524655153826; Wed, 25 Apr 2018 04:19:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524655153; cv=none; d=google.com; s=arc-20160816; b=ZL7OYfQ/Zb4F2zwD9AYZRudfsZXXOunEOFlL7JPcvJC9Vka9/imo/uHdmchhd4b1NR WpOSk2E1cPTb2jdPd09THnZrQfbLkwIvQue5yJrmEmatzpvC+y75DnCDkYHo41KN1QbF Vk0vX8skZIzdxczrjvJ777XDvANLPVxFeJJVFHfkH/Ur2PUCZIHqNRby2mf9oNX2+EiT 95agV4oRx855ssGSVi+zlX3kDuCTHCQYjYlocUsZXJktW9H9rOjZYx/UjMJvNdluuPPX 7/oaCXOi+J98lAcuC57C1HVM98NuXy7m/emoeELDDjaHA1tWVixWcG1owBp1uVNnNtCb bV4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=x7sw42kPkshT/Eww6W/6MDf/4o2m4CoCTPqkxjzXHKs=; b=jaZ5GhTN6vbVOCSwvMP6q5EbCDq6ZWqd+uX1rEurlsIZy02x4jVnBXPu5zwce28NNo 1eyeTwV7Crt9lhfRyMkrUVix1G/2X6vHl7AX1Fw3fG2Ps8jNxVDD3othCZaU5+MgX6cA J6a3ElKg/LIBiXYFv12dBDTP1MhMBE+uV4oDvHrooplsWhcgIMtbxARAB2P3RpRjKKws PjLd9uBYH1Yx5bSfTnzCbQNAyogaS2Cp8EyUe6QU5MaJqxf/P19+jTVIriQ/ef/XpH3E V+3xLwEI9BjbXJfAlvxs4ULocBH0MsEvJDbSzJp80jB92r8VqlW/3qwXKN1LB3Y1UMBY eBrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w71si15870545pfd.273.2018.04.25.04.18.59; Wed, 25 Apr 2018 04:19:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753825AbeDYKkd (ORCPT + 99 others); Wed, 25 Apr 2018 06:40:33 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52114 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753223AbeDYKkZ (ORCPT ); Wed, 25 Apr 2018 06:40:25 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 7982F36; Wed, 25 Apr 2018 10:40:23 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jimmy Cheng-Yi Chiang , Jeffy Chen , Brian Norris , Mark Brown , Sasha Levin Subject: [PATCH 4.14 083/183] ASoC: rockchip: Use dummy_dai for rt5514 dsp dailink Date: Wed, 25 Apr 2018 12:35:03 +0200 Message-Id: <20180425103245.836344112@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180425103242.532713678@linuxfoundation.org> References: <20180425103242.532713678@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jeffy Chen [ Upstream commit fde7f9dbc71365230eeb8c8ea97ce9b552c8e5bd ] The rt5514 dsp captures pcm data through spi directly, so we should not use rockchip-i2s as it's cpu dai like other codecs. Use dummy_dai for rt5514 dsp dailink to make voice wakeup work again. Reported-by: Jimmy Cheng-Yi Chiang Fixes: (72cfb0f20c75 ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp) Signed-off-by: Jeffy Chen Tested-by: Brian Norris Signed-off-by: Mark Brown Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- sound/soc/rockchip/rk3399_gru_sound.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) --- a/sound/soc/rockchip/rk3399_gru_sound.c +++ b/sound/soc/rockchip/rk3399_gru_sound.c @@ -387,7 +387,8 @@ static const struct snd_soc_dai_link roc [DAILINK_RT5514_DSP] = { .name = "RT5514 DSP", .stream_name = "Wake on Voice", - .codec_dai_name = "rt5514-dsp-cpu-dai", + .codec_name = "snd-soc-dummy", + .codec_dai_name = "snd-soc-dummy-dai", }, }; @@ -432,7 +433,18 @@ static int rockchip_sound_of_parse_dais( if (index < 0) continue; - np_cpu = (index == DAILINK_CDNDP) ? np_cpu1 : np_cpu0; + switch (index) { + case DAILINK_CDNDP: + np_cpu = np_cpu1; + break; + case DAILINK_RT5514_DSP: + np_cpu = np_codec; + break; + default: + np_cpu = np_cpu0; + break; + } + if (!np_cpu) { dev_err(dev, "Missing 'rockchip,cpu' for %s\n", rockchip_dais[index].name); @@ -442,7 +454,8 @@ static int rockchip_sound_of_parse_dais( dai = &card->dai_link[card->num_links++]; *dai = rockchip_dais[index]; - dai->codec_of_node = np_codec; + if (!dai->codec_name) + dai->codec_of_node = np_codec; dai->platform_of_node = np_cpu; dai->cpu_of_node = np_cpu; }