Received: by 10.192.165.148 with SMTP id m20csp571952imm; Wed, 25 Apr 2018 04:29:07 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+le6YXPxnhC2iYO22P7141BhNU2TiQpo9ACfGJwHcRZUm3xJLyuAibfC1696DX46Jp1FCm X-Received: by 10.101.77.199 with SMTP id q7mr23834333pgt.305.1524655747047; Wed, 25 Apr 2018 04:29:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524655746; cv=none; d=google.com; s=arc-20160816; b=DRW66/tYdQcST60Nrwjy7ubG9scAtMDmp2DM9r3HtBr98b6aUVns4twNItdrlVgXEu ZRRd8gV7zpz53qTtRy19eAxd0qVmeZAYcbq5Eahr7GPI/rtg1JS6TSOW9jJ7Ln0IONxI K+OLKT9hgBr+ilp4RW7wBplmBrYBSmJ199F76ZQOBtPmNLCYv04kYTGx1x0DcfL5Giz1 ZRu8hJKGJ0r1+oM+FDv1EL46ozsq95Qj7gXvjd07jBB4TIg1HBkF8p42DMuTB/l5cKRn 7dl+4N7dCub9CyQBzyuLP/k95m7NVNCLXh6VNkD1/F/vbDwvEErGgC9mcQbpptd2iGVj POKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=b9jm2uvFIMXVjkAILn4HcX3+uB1F3/yQnhpgUHvX5uU=; b=KlBHjDSKxSZFrIHy2fuzq5cBPYH1UKfRHYxZT9vyOLuA+/Z6ENkP1qq2HVRHy93qEY yBRZhASkf8n9JEfo7+TAbpi7JF2wqM5w811F/jNVRQ0IPtAzSpiW10jidLU9e40yYTnh xaeKmHwms7Xb/du4BBywvDvm4IRGI9XtQnY0oouR5d9sMFamxKpp+DzjIIuvzQOLz7om pGU4Jls+ane1sCrRXEKGYh+GX6BD7U/KTUQmEnLw2tcqwLNatlz3uBPRISUwyNtrkf6F zfqnq2Wo7KjxluG6+ZylphZn0OscBufOgj/v1sMKuhsUnaj/5Vbpq3kg8UH5NlTDJT2q +s/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u198si8811241pgc.203.2018.04.25.04.28.52; Wed, 25 Apr 2018 04:29:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753701AbeDYL1v (ORCPT + 99 others); Wed, 25 Apr 2018 07:27:51 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:7630 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752051AbeDYL1e (ORCPT ); Wed, 25 Apr 2018 07:27:34 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 8D5CDF9DD67E; Wed, 25 Apr 2018 19:27:20 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.361.1; Wed, 25 Apr 2018 19:27:13 +0800 From: YueHaibing To: , , , , CC: , , YueHaibing Subject: [PATCH] powerpc/xics: add missing of_node_put() in error path Date: Wed, 25 Apr 2018 19:27:07 +0800 Message-ID: <20180425112707.16392-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The device node obtained with of_find_compatible_node() should be released by calling of_node_put(). But it was not released when of_get_property() failed. Signed-off-by: YueHaibing --- arch/powerpc/sysdev/xics/xics-common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/sysdev/xics/xics-common.c b/arch/powerpc/sysdev/xics/xics-common.c index 77e864d..e54a9e6 100644 --- a/arch/powerpc/sysdev/xics/xics-common.c +++ b/arch/powerpc/sysdev/xics/xics-common.c @@ -448,7 +448,10 @@ static void __init xics_get_server_size(void) return; isize = of_get_property(np, "ibm,interrupt-server#-size", NULL); if (!isize) + { + of_node_put(np); return; + } xics_interrupt_server_size = be32_to_cpu(*isize); of_node_put(np); } -- 2.7.0