Received: by 10.192.165.148 with SMTP id m20csp731216imm; Wed, 25 Apr 2018 06:53:41 -0700 (PDT) X-Google-Smtp-Source: AIpwx49trQMJTbG78PNwnDIbIRGFH8TDBpmEixjaJgbN5mvv1Y4ubup7SToAoLpq7ioLh6lfSwuZ X-Received: by 10.99.135.198 with SMTP id i189mr23262528pge.2.1524664421806; Wed, 25 Apr 2018 06:53:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524664421; cv=none; d=google.com; s=arc-20160816; b=wbAY9qCNMU6YbgDk0S3vn+HkRffOb7h4ykqvIgyalFcR40hR5yF5H4qwOEwoB3nJX7 CbdNyT/SV55uTvfKthVYIpDBc9nBuFtCbzFRl5/K7YiD9HozmOExZz5uZLOSY+ddRhxh R3f4pGbe5Ir/FDaO3YPT/wlh3GEPEdYWCTDSUK6//jh4YJoSmVc3Pz2wBTxWJyuqZjva +USRTI94qFLVsfGU1jquKshnk/gHxzCIz8TSJKkZhU/TVlUk8VS2jqjYf2PMgHjEPOC/ bER5YkcjRMkOGv8EU0q5bKZyKVVVvIeRrBEBL0zdsEYXCyuT3rHsoYAaC8CkqBp8KC9Y IJJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=XQT+UwJATi3GErBIk/d4bRzqrH6Y1n5iDCDby9iFpPQ=; b=O48GAb1p1I9WU6Y8yk01HS9VYoieVWrUyZOWHDb8QjxYtePvN9Qp9xEHCh33i7ohOg 3H2hbHVcBhjzo1ltmTRojSzXe2ay7LR2tZlv6YcBGyZqD5IdvX0ZpnvpK6OyA+Z6y8f2 Q6RLXnqVLjarYrefWIn/RM5PdJq0S4WM5NrdGtH2Z5XPz9bPwPPRCyGUvkZZ19iQBE8q gqGdzBne2GIKX9T2C6/fpsj976C7s3KzHQjCLnYJ4Gcd5dE6RT+lzqd5y3DM/xMaJcUK Xd4+a54NYH29KM/mBrTq7lyt1m2VialeSuhk+kVv1nju4QPEVu2Jlok6vs4Ai6a5xUKp 92Iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9si13123056pgw.592.2018.04.25.06.53.26; Wed, 25 Apr 2018 06:53:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754131AbeDYNux (ORCPT + 99 others); Wed, 25 Apr 2018 09:50:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40066 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040AbeDYNuw (ORCPT ); Wed, 25 Apr 2018 09:50:52 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D7A9D830; Wed, 25 Apr 2018 13:50:51 +0000 (UTC) Date: Wed, 25 Apr 2018 15:50:45 +0200 From: Greg Kroah-Hartman To: Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Janusz Lisiecki , SUNIL KALLUR RAMEGOWDA , Sergio Paracuellos , "Gustavo A. R. Silva" , Quytelda Kahja Subject: Re: [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type Message-ID: <20180425135045.GA28703@kroah.com> References: <20180424131824.5164-1-luc.vanoostenryck@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180424131824.5164-1-luc.vanoostenryck@gmail.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 24, 2018 at 03:18:21PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck > --- > drivers/staging/ks7010/ks_wlan_net.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch does not apply to my tree, please rebase and resend. thanks, greg k-h