Received: by 10.192.165.148 with SMTP id m20csp793331imm; Wed, 25 Apr 2018 07:47:02 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/ags/xXwz9zFac+iiDqs0mi5fmhEQeVkKeorG2Ama3ivIXLUNBIq0xlcsr9WgjlUlAcPGf X-Received: by 10.99.38.71 with SMTP id m68mr18734940pgm.56.1524667621948; Wed, 25 Apr 2018 07:47:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524667621; cv=none; d=google.com; s=arc-20160816; b=bonlM42z7w9548yGlCS8OW9OME/pbySTOYIs2ObgKD9iLhO7BAYfYbziodb+MHzBMf 47Nr5KOaZBNHHkyFpoP+LDWrfq4/N1J3vHhmbgi4MmAz0h+XHV+6ddciWKqMDICoGTXl YCSlJHs1B2y5q3kUDBE6J/6jBjh7f3IASpGoATCPobXsbOxF/mYfLiOElQcXQReV2UB6 zeKStePD0Vg/yZwbARAYbRVbJVa5z01cegBQKSk7zNcigOoQ4YWIYwV+3mVHysjl8JBh rEaaGj3etFHvtpGcXev3jUxVb2bampNrU2/8pKJ1tVSxDRrUa7chp7mZfkcFFs7xPX7I MSFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=LbeVac7vH/beAnrMlolvQwz0vjGhDiLGunHM9HI8nCc=; b=dDpq5tByRUsAU/Abbr3y2nRuk6s4NaNITI8qi5+K7RonEagJtSRRmiFBkm4e7NWUHO XeSJx3pd2OOKKxKmX60ygcBTJzOzwX5QGvW5qBIHIJbq4d9FC+Q5bozV0pcBqCijzKHv NfGbk73mdEye2Pdg+9djIiiLDOztqARUxP4GTzxgSzwgmeowPzmGVgeSXFXHPbk8P7Bd cxtlxis38EelrqtJkzIaosmqapEgNhxBw+lQb+lF7XH6gafClYL83B6wBAnPODsgudH1 7DDAQvBbJddmZPTXhtCpT+sg0GgMeLNy7O68TELwCNTuqWtWgWYa6hMJPBPA+ZhTRCZl a5Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Qee2AhHM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33-v6si17265401plb.19.2018.04.25.07.46.47; Wed, 25 Apr 2018 07:47:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Qee2AhHM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754395AbeDYOo6 (ORCPT + 99 others); Wed, 25 Apr 2018 10:44:58 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36518 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754473AbeDYOoz (ORCPT ); Wed, 25 Apr 2018 10:44:55 -0400 Received: by mail-pf0-f194.google.com with SMTP id g14so15419521pfh.3; Wed, 25 Apr 2018 07:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=LbeVac7vH/beAnrMlolvQwz0vjGhDiLGunHM9HI8nCc=; b=Qee2AhHMrnh7OX9Pk39kq5WqIyUM5CPrMgVDDVnZw1wLCIMJoi01L0elqtT6+cxt8B 8fGXTCxtdwBebtGZkf00p4xiXHkgmlzt0KmjFCHlhigoTSAGgOn84MmOQb2adXLiFPBp CoeR56S3Qt/9X/KWmvajA0vTvNjBGAQgyVqd1iOKa74No35g9XTRPadMp6ri81reY1lq pAwzKYVtIA4jH1HBYq/lbOZMx10k5htTKN9hHzvDsSko7cmNI8ELWsFrKtG93Gu+qUr8 HYmDWOrn1EoC5Q3EPXUWGD7jw+ZgYdUBtWAcXsU781ckqaDKAExBHe5K9Xtl3EFzfmwg 8VbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LbeVac7vH/beAnrMlolvQwz0vjGhDiLGunHM9HI8nCc=; b=p61sJ8k19e9j+7Ubr6c0zQXOcK+yfLMl/xrM5pL2PYN/6ld+1cxLpz6TPcsjzV0a83 MHspygtxzSUjasLkpT3QiWXf+jAaZ2sq1Caukh4HQn2ymSPacQTiBoQKKb3K+Yztw2ZL Nwp/QQ+nXwF6ul1e9o2PNOEBYswkAHIA4lx681LrEe6XKHba18fYbAUjotCNy+sBasdg J0JzHaMV02/5p9vWaAQEfH7kaOWY80+msKGPk4NxpiQp7z5LVGBjRXeoSKQGSOyEsjD2 JeizHG3S/oRC/OqC72U+D+W1PIrkwXoAgkwihAinm3qSVmwPHxvqOZvjIj5ZgzzQhBya Ddzg== X-Gm-Message-State: ALQs6tBO3T72wvZ4kGpTwVp6medB66x9coOlUKEqD0OcUyT0Iv22r42z 0fzq7Lj5tOJm1K6B3oJnw7w= X-Received: by 2002:a17:902:8646:: with SMTP id y6-v6mr28953922plt.86.1524667494676; Wed, 25 Apr 2018 07:44:54 -0700 (PDT) Received: from localhost.localdomain ([106.51.29.61]) by smtp.gmail.com with ESMTPSA id o9sm25047926pgv.74.2018.04.25.07.44.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Apr 2018 07:44:54 -0700 (PDT) From: Arvind Yadav To: tony.luck@intel.com, fenghua.yu@intel.com Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org Subject: [PATCH] IA64: tiocx: use put_device() instead of kfree() Date: Wed, 25 Apr 2018 20:14:45 +0530 Message-Id: <1bcbd268184312155aec041bdd87c775ddb7cd8f.1524667391.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Never directly free @dev after calling device_register(), even if it returned an error. Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- arch/ia64/sn/kernel/tiocx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/sn/kernel/tiocx.c b/arch/ia64/sn/kernel/tiocx.c index 32d0380..fd515bc 100644 --- a/arch/ia64/sn/kernel/tiocx.c +++ b/arch/ia64/sn/kernel/tiocx.c @@ -209,7 +209,7 @@ cx_device_register(nasid_t nasid, int part_num, int mfg_num, dev_set_name(&cx_dev->dev, "%d", cx_dev->cx_id.nasid); r = device_register(&cx_dev->dev); if (r) { - kfree(cx_dev); + put_device(&cx_dev->dev); return r; } get_device(&cx_dev->dev); -- 2.7.4