Received: by 10.192.165.148 with SMTP id m20csp872259imm; Wed, 25 Apr 2018 08:57:33 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+fY5RzSMcDrnsWt0+7NOIe1AOhq63Py/i+dRqVemVs4pnM/GNUZ9NT2Si/fz/AGvZo3uN2 X-Received: by 10.99.104.131 with SMTP id d125mr24503460pgc.9.1524671853301; Wed, 25 Apr 2018 08:57:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524671853; cv=none; d=google.com; s=arc-20160816; b=pL3G1OrJNBsBUmqqg244YEVK4tKaQ5WMFJ2DO6GCK+ghySBi4B6o69+Uw6fSMLmqCT 8tQZbtw5ceOO6pIxB/WcCHIiIfKQOQjIwKHpFi9FpP8MRQuEGhZwmJ7bI1rLhVzECpdj lL6jhgXpkYwQguV8rOPzBJu6UwP+CJnuvSA6xAn5bux/8848EkBp8GqbunBqsOOW0Usk lHGKrHTWYfdCxpFjohKmnEJvgQJHaiSLls5SrLlGw0XXzORpBHnoz2jVn968o/QpWM8S 4P9WyrpWd8ElLXuPEW5Vwp7tAkEDQ7SkdHbhCECvS3vG0QSYifgxE+CMiV2o5jvkqZxF Rhkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=kAPQ944YUTNI+eZCQVdsGSRUKlCiIVERPVLqvIzNw4E=; b=YM2cUWYSfMD+LHZGtCIe1wK1cGQpyLINCJozmiKdHNZzF3rPJiVlpZDv8F1iEIwoSn jcyUhuOeuXfY1CK4PwxgOPT5Xemvvolqfx7ya9yW7o/e/PZ1rypOeSkbzbo3nydzjnbK Cko4FGYo2E0vSnv9Ws0tg+x2ghE8U7q6dyNHGznVWrcXpYC81vvlPksPpNZIxIhkwplK NORjfASkepc7kd8VljSl4cCz1k4yGX+9DjWTegFQFvYz2G5RhmXcC3eQ/fPVdVH/Biyu TJfb0A8Rs5UYNwq6tx0fNPmVZ4Z0eM9EqA1AKhHPXVsZ024sOLo0WPLH+SBdHrc5Phh+ aa0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=JDwcT3LO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h68si11476705pfa.238.2018.04.25.08.57.19; Wed, 25 Apr 2018 08:57:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=JDwcT3LO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755619AbeDYPzw (ORCPT + 99 others); Wed, 25 Apr 2018 11:55:52 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:46814 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755168AbeDYPzt (ORCPT ); Wed, 25 Apr 2018 11:55:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kAPQ944YUTNI+eZCQVdsGSRUKlCiIVERPVLqvIzNw4E=; b=JDwcT3LOngjKU3BNZfjuzGVzB iSItoREibZMPgzFCyUYeckXL6tGvJm9oN/SssPk7YouDoBj++wLIvD+TEb3Gga94jyDNPXoXBz0E/ iaSdNuxAPO+KXARruRZqCoWJ+dDK/IMKsG3cwYGoWGk6Kk59ldzVkCGCpjNRzymv8wbyMF0q1wLDD xmuIc28G9U4j7/JvZ4E/epGODHclOpjAz3bH/3CX/L8YcyNDwCNrfxm/yzge3tUkj8UcqAdNGnu00 Q+l3FmkavpaRK5A12rG6jEBTktuowv+q34ffeJAMGCl/FTnevyE16dFqiy8Ji8NHpqGnXkVO5Vpcz ChMbUpw+g==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fBMlf-0006xq-RT; Wed, 25 Apr 2018 15:55:39 +0000 Date: Wed, 25 Apr 2018 08:55:39 -0700 From: Matthew Wilcox To: vinayak menon Cc: Roman Gushchin , Vlastimil Babka , linux-mm@kvack.org, Andrew Morton , Alexander Viro , Michal Hocko , Johannes Weiner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Linux API Subject: Re: [PATCH 1/3] mm: introduce NR_INDIRECTLY_RECLAIMABLE_BYTES Message-ID: <20180425155539.GB8546@bombadil.infradead.org> References: <20180305133743.12746-1-guro@fb.com> <20180305133743.12746-2-guro@fb.com> <08524819-14ef-81d0-fa90-d7af13c6b9d5@suse.cz> <20180411135624.GA24260@castle.DHCP.thefacebook.com> <46dbe2a5-e65f-8b72-f835-0210bc445e52@suse.cz> <20180412145702.GB30714@castle.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 13, 2018 at 05:43:39PM +0530, vinayak menon wrote: > One such case I have encountered is that of the ION page pool. The page pool > registers a shrinker. When not in any memory pressure page pool can go high > and thus cause an mmap to fail when OVERCOMMIT_GUESS is set. I can send > a patch to account ION page pool pages in NR_INDIRECTLY_RECLAIMABLE_BYTES. Why not just account them as NR_SLAB_RECLAIMABLE? I know it's not slab, but other than that mis-naming, it seems like it'll do the right thing.