Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <1523366506-19832-5-git-send-email-geert+renesas@glider.be>
References: <1523366506-19832-1-git-send-email-geert+renesas@glider.be> <1523366506-19832-5-git-send-email-geert+renesas@glider.be>
From:   Todd Kjos <tkjos@android.com>
Date:   Wed, 25 Apr 2018 08:58:18 -0700
Message-ID: <CAD0t5oNj5Rgj6tiuwVFegyJiOzV8jsV=OwHHa9USrQLjzLPCgQ@mail.gmail.com>
Subject: Re: [PATCH v2 4/4] ARM: amba: Fix wrong indentation in driver_override_store()
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Russell King <linux@armlinux.org.uk>,
        Adrian Salido <salidoa@google.com>,
        Nicolai Stange <nstange@suse.de>,
        Sasha Levin <Alexander.Levin@microsoft.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reviewed-by: Todd Kjos <tkjos@android.com>

On Tue, Apr 10, 2018 at 6:21 AM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Indentation is one TAB and 7 spaces instead of 2 TABs.
>
> Fixes: 3cf385713460eb2b ("ARM: 8256/1: driver coamba: add device binding path 'driver_override'")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/amba/bus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> index 4a3ac31c07d0ee49..842314a439fdd4eb 100644
> --- a/drivers/amba/bus.c
> +++ b/drivers/amba/bus.c
> @@ -101,8 +101,8 @@ static ssize_t driver_override_store(struct device *_dev,
>         if (strlen(driver_override)) {
>                 dev->driver_override = driver_override;
>         } else {
> -              kfree(driver_override);
> -              dev->driver_override = NULL;
> +               kfree(driver_override);
> +               dev->driver_override = NULL;
>         }
>         device_unlock(_dev);
>
> --
> 2.7.4
>