Received: by 10.192.165.148 with SMTP id m20csp880666imm; Wed, 25 Apr 2018 09:03:35 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/3tD0RlLvLGs09Qb0zyB77jz7BsI5xG93Ek/9iQaPGy01lESAHhQvhp5lhlZUVyDrXEAtX X-Received: by 10.98.24.214 with SMTP id 205mr27983914pfy.242.1524672215455; Wed, 25 Apr 2018 09:03:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524672215; cv=none; d=google.com; s=arc-20160816; b=mI0rehmlysLmgF258nZcj3mFU+3Z850RKw/MyUqpa7FAAGBySa4mx8msIsd5QTJhRl TPGXfe/4WngLHokIRAZ5QbSsGzTBrzCZTw7Vf+5+XkksNScSYGf87uMLdGbms3ru3ze6 VoGVbFOQutmiEug8qKCOBBf0np5z08Ag5bVSJ9wCDzP+Zdx6O/G9AkGu8skJQCWW1Cez mN19z0P4SZWXhqV/Lj8sPLBCQ9ieCZDQ8jToubsItKcWyLFqLZ63bjfnGVdnfnlvah8I UWw6LWCbqz0AE8Ve3nFanykS72T//3gI/ifnQP4p60810yv8VRLZV1NOsYhtCD1bk7nY kAxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:arc-authentication-results; bh=AsKzROuUPkvTfuzyDWV8MKWVvBvOu41z0VqxMbyvCKg=; b=EngochZhHYCKtYWVrXQXAmf/9f5fC7nBq//zEZRkHkQjqA645v0qKGvzvjiOPmZmXr O2TSTbrfYcteMeEHVz0jLdrHXgS++DFhn+Tu9W+t2u3JMmQnVS4dfUg7qBVUYXKacL3u Ol9m5YKJ4VCcJ5awal8ejSayMYU82rfUG6Xl9lIrU2fP+hyLmITKz6H6e/Py+WQHCJof 3yjsTU7cNEtX/DsGm+iT2+DXmdtkDzXMqC8XEQ9QZ3cjMPqOL8bt4nNY20h6YBMVVrJC Kb+ab+zwpvVpD4OKc+b1b+cH63pmWWjdoTpLQLDAm/Fr6Frw8WN0T9DW6VyPR8gFZQOO yQPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h68si11498950pfa.238.2018.04.25.09.03.14; Wed, 25 Apr 2018 09:03:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755850AbeDYQAx (ORCPT + 99 others); Wed, 25 Apr 2018 12:00:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:47112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755580AbeDYQAl (ORCPT ); Wed, 25 Apr 2018 12:00:41 -0400 Received: from jouet.infradead.org (unknown [179.97.41.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3EE4A21759; Wed, 25 Apr 2018 16:00:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EE4A21759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Thomas Richter , Heiko Carstens , Hendrik Brueckner , Martin Schwidefsky , Arnaldo Carvalho de Melo Subject: [PATCH 08/12] perf record: Fix s390 undefined record__auxtrace_init() return value Date: Wed, 25 Apr 2018 13:00:04 -0300 Message-Id: <20180425160008.3407-9-acme@kernel.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180425160008.3407-1-acme@kernel.org> References: <20180425160008.3407-1-acme@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Richter Command 'perf record' calls: cmd_report() record__auxtrace_init() auxtrace_record__init() On s390 function auxtrace_record__init() returns random return value due to missing initialization. This sometime causes 'perf record' to exit immediately without error message and creating a perf.data file. Fix this by setting error the return code to zero before returning from platform specific functions which may not set the error code in call cases. Signed-off-by: Thomas Richter Cc: Heiko Carstens Cc: Hendrik Brueckner Cc: Martin Schwidefsky Link: http://lkml.kernel.org/r/20180423142940.21143-1-tmricht@linux.ibm.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/arch/s390/util/auxtrace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/arch/s390/util/auxtrace.c b/tools/perf/arch/s390/util/auxtrace.c index 6cb48e4cffd9..3afe8256eff2 100644 --- a/tools/perf/arch/s390/util/auxtrace.c +++ b/tools/perf/arch/s390/util/auxtrace.c @@ -87,6 +87,7 @@ struct auxtrace_record *auxtrace_record__init(struct perf_evlist *evlist, struct perf_evsel *pos; int diagnose = 0; + *err = 0; if (evlist->nr_entries == 0) return NULL; -- 2.14.3