Received: by 10.192.165.148 with SMTP id m20csp936933imm; Wed, 25 Apr 2018 09:54:53 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/fZh2fr9L5KWNtavTYFRPD1vXNxDlgWnr99XfzFFpubcyL4f9NWVWnqbkUj35x1P7SKFgX X-Received: by 2002:a17:902:1347:: with SMTP id r7-v6mr25173290ple.62.1524675293340; Wed, 25 Apr 2018 09:54:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524675293; cv=none; d=google.com; s=arc-20160816; b=y8X5jYvkrmL2NPVSAeAyNrKrnvjYvkWeOhBYbz366ZaBPSSOFJfloDoCtVB6/fabTu bghCwRqi2wbWsZ6q6GEijM3WTA82l2oz2EoCgmntaHxoguWZnOZjby/qFTfHGbY5Z9YK Nc5Pby6OqO0buNA0ZKZ3/2FO/BGJ8+v1r9QBr/myZgXn8vFkP0JiSiMwNkmH2yeAnkJa VoPzSbx1FxMIuqJcyQz5gZpiCnO563lqcP2VVbzlTpIuqVHPRayUsznCO8C2ArptBi0f aQcR282DZ6n6ju9bisA7B4kPNNQowRlWMIuevJ0InJwfysrQXAyUOHSRY73c3r9SrsAJ jmmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:to:subject:dkim-signature :arc-authentication-results; bh=AkyLM3LHYZ2+/Xr/T26SEGW2QSXtswMm3jssdNFVgYQ=; b=GkINL9twLYf12wCx7uUb2GLnS7qOKwLzRomZViVmYhCeKlyu24IUhiShwgh4Uf0g/5 u45iLzvbmzHkVGvNg9ibZPuof0bst2Si1DFRE7+/v/xxwB5Ubc2+VTRcbziAUBYnioom VWgS5DyguqoLaZQQyzUYOidLPIDGUWHpA8uuVvEHgQE9ByHRF4SltEqXkTZfCwUjPJys L2O9sqGHrFJZXhFEV3KNRBZIUICe05vBsrqtq3qIDCZNZMAuX8LDuQaTmQX5mMx05OBy ai0Biy36g7jQocJIs8RCgpFw242i6BO2F88j7n9jPtqr0Mh0ixjp7yZ8Z/WL8gE4YXqA A1sQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=W1m7DkT1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5-v6si3973797pll.123.2018.04.25.09.54.38; Wed, 25 Apr 2018 09:54:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=W1m7DkT1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755203AbeDYQx1 (ORCPT + 99 others); Wed, 25 Apr 2018 12:53:27 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:51238 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753508AbeDYQxZ (ORCPT ); Wed, 25 Apr 2018 12:53:25 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3PGp3MJ114682; Wed, 25 Apr 2018 16:53:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=AkyLM3LHYZ2+/Xr/T26SEGW2QSXtswMm3jssdNFVgYQ=; b=W1m7DkT1FjUIlGZpaapOQ/6mY7sAjEtHRq4QRQiTX/M1zxDMCi6IqNM5razxOGsniGaH Oy0ycpky2ldO/1EWYhSEp53I+oFiQe1sJfRWRo+2xRpbiN/YU88I6GuCXQzJlPEFzr5k VT+xhiIr2p6qgvi8in4v8/6AWvTRE2JPopaD/wH4lZG+bytmIPPCUU+RdSwdv+TN2j50 cReerTWAJdy2mYVAb1vjqmZVcxUbWYqOQIXG+f0VnGzGVsNppQPx8S14keMl+GkNqhNI 272jLv4Q/fvMRSXXz+Y0HuM6G+bJK0c4aO5ldIef1l68wvcFFITe/i+uMifirpATOmeL AA== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2hfvrbyps2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Apr 2018 16:53:21 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w3PGrKVU026980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Apr 2018 16:53:20 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w3PGrJAV000522; Wed, 25 Apr 2018 16:53:19 GMT Received: from [10.209.243.127] (/10.209.243.127) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 25 Apr 2018 09:53:19 -0700 Subject: Re: [PATCH] rds: ib: Fix missing call to rds_ib_dev_put in rds_ib_setup_qp To: Dag Moxnes , "David S. Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org References: <1524655321-8379-1-git-send-email-dag.moxnes@oracle.com> From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <4ea2c988-fd68-3bc0-2f6b-f12648f6d4e9@oracle.com> Date: Wed, 25 Apr 2018 09:53:17 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1524655321-8379-1-git-send-email-dag.moxnes@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8874 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=855 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804250156 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/25/2018 4:22 AM, Dag Moxnes wrote: > The function rds_ib_setup_qp is calling rds_ib_get_client_data and > should correspondingly call rds_ib_dev_put. This call was lost in > the non-error path with the introduction of error handling done in > commit 3b12f73a5c29 ("rds: ib: add error handle") > > Signed-off-by: Dag Moxnes > --- Thanks Dag for following it up. Acked-by: Santosh Shilimkar