Received: by 10.192.165.148 with SMTP id m20csp1001485imm; Wed, 25 Apr 2018 10:57:26 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+5zLrFjnCyStnhs7q1nstOIukXdrA1pYzzejRRDMMqPDEAjYEZzeKI59Y1kCdJviq/uMJh X-Received: by 10.98.138.210 with SMTP id o79mr25618384pfk.89.1524679046343; Wed, 25 Apr 2018 10:57:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524679046; cv=none; d=google.com; s=arc-20160816; b=V4eGDVBKO2M3I26xXm6r+0E5l4Uh18yOn3qzY6wRS4fDEVltve2PDW/Fm66b9yBJrQ n9+eZig/isddVTxiAUDdCyeIKhKxvVET7QoxEXhLg/MzgyvK909lFQn5dzcbd7pdVjhV anV1q3j5xEq/1Fbf0FC8XrnvobDCWrElhWWDqbLF+aTTEZfm14BPaMpq2FLYWIBAv1NE msgSPf7D7e2O6xGC7g+qukMj809yQF/LNh+k/P06ByDMkmcsQ29mEPYGrOV1u3ZBJzLo zd7KImJcUn+jaFlfXUNera9q31f5m7rwk4ruf+GFA/gwdGew8SqtWcVbD5BBShK2kCp/ 8o/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=zceJqwe7tGauyhkEj77/l+bRREP/Eq8EWvS8qj4mAP8=; b=Zette/ndACyWv74f5CjmWjWdBSz+LZimMO/1m465l8ZzHlkver+nbl1kpZr5+EeY8G BQPWNkcsE1NtnVTRLUYM+g4czbRVJD/ZRgr4JBSEIKpRFwnk0+hDu5o7eHfQKLQov1cj 37lvygHuLRG86SRxZzPU6qT7m4Vui6vTCYVb3vRJvqiM0eARxs05iFuaAxW2T7KJII7B PMMfr0NRt2A+6cucYt7ys1lQ4eG4ZeBx5BY8gqwMIVXcJSZ/9cZbueYhS9fagGI2s5eV spaEML2vyWjUARdtyc29+ktLwZxTADjF9oqjnjldntcAICh4/ubaTpcrD+n7wDUiK9Pi N+mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=bZSc8EbP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w22-v6si16032690plq.115.2018.04.25.10.57.12; Wed, 25 Apr 2018 10:57:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=bZSc8EbP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755964AbeDYRzp (ORCPT + 99 others); Wed, 25 Apr 2018 13:55:45 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:52536 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbeDYRzo (ORCPT ); Wed, 25 Apr 2018 13:55:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zceJqwe7tGauyhkEj77/l+bRREP/Eq8EWvS8qj4mAP8=; b=bZSc8EbPseimImoAmNwbny+AG MhWH7UJOTL7R0FpnsysYxnUNFy7rTS7Rz9RoxunADDBx4cu/00vlZhnDczImpJxojB8uvfIUiXPsc +X02Lh4iFdMBSE15sKljBIDLshEgBAE+WzbGcaTe0CDY/PaFnT5I7uU3vm0qisX4Ah6qkD2NeC+0O PVbb5MaFEEGnazcueQNDdjw8gm65rYQqDiKoj9NWLLb0cWJImLpptSBoHY5hvtW9I+9cwDxGv2PtY zc9LMlFl0Z0yY5EilHTK5sOiNsuPv+4b1QoYx3xBqzC9+i0vhbteQjQw8ZjdWQE2rDJHbQHTZYZeW UI4Ases1Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fBOdl-0007O7-0D; Wed, 25 Apr 2018 17:55:37 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 2C48B2029FD58; Wed, 25 Apr 2018 19:55:35 +0200 (CEST) Date: Wed, 25 Apr 2018 19:55:35 +0200 From: Peter Zijlstra To: Kirill Tkhai Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, Juri Lelli Subject: Re: [PATCH] sched/rt: Rework for_each_process_thread() iterations in tg_has_rt_tasks() Message-ID: <20180425175535.GC4043@hirez.programming.kicks-ass.net> References: <152415882713.2054.8734093066910722403.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152415882713.2054.8734093066910722403.stgit@localhost.localdomain> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2018 at 08:29:01PM +0300, Kirill Tkhai wrote: > tg_rt_schedulable() iterates over all child task groups, > while tg_has_rt_tasks() iterates over all linked tasks. > In case of systems with big number of tasks, this may > take a lot of time. So you're actually using RT cgroups? Some of us recently considered removing that thing entirely because most distro's don't actually use it at all -- and it's broken from a RT POV. That would then clear the slate to try and implement something new. But if you're actually using this stuff, that would complicate matters.