Received: by 10.192.165.148 with SMTP id m20csp1034921imm; Wed, 25 Apr 2018 11:29:45 -0700 (PDT) X-Google-Smtp-Source: AIpwx48VVSm5kwFeWS+ZMOaaB+VVpd4akB/9xF1UUlSKOzd1tz3B4MsMBaIO8bNYBGUZW1aJ0Ngp X-Received: by 10.98.131.69 with SMTP id h66mr19132977pfe.0.1524680985567; Wed, 25 Apr 2018 11:29:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524680985; cv=none; d=google.com; s=arc-20160816; b=vwJiJ1at1x5miHgAWwE0pOYOx+PgHaln5ul+YjCPXESe1A5j95MnnYGwfaqvFbPtji K3bZ7iujIue2tTF6kg5vDCU8d7TkawOorBaoN+udmUcPT8BmLlpt6ZV4+VzD+AZUqOYu 9jv/Q1D9QJHLZoSheqO7qc/r/EXunMkGDT5W2cEyKzOMga0qFNxe9I3Zhwn62l+z91r1 ZB7DWZRM10Ujl7jbMrVjylv5vmh7Ppqw2oQqZHVO77+9lQyGvqgIFz1BdL7A1AmqZuGd zn7al1qwoYnryAW0I45h4NqjHJD603GvRx/UXWP3Q3jIB6PLmdwjfJYq+O83hvjIRhdQ WhkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=vH0MgITDIQ5ihAvVjx3VXvFlAgEHvlBQ/T+OOhiFNcQ=; b=TJEYWQSv4LbvlXbohbiQydjTFvLDzqPtttu2C3WiZENUhqd8F+bYA7BVuBonjGBjj4 0AEI4o1AsqwZXp1iOYygPZO0jtIRlTM45GTD3JAstEoT1qMPfEhsqcM+KeTaNMdz+wnI VHf9ov5dKxn2DI5Y1pKQaOlUv3Ffsd1O5NQYW3hJ0x8aW1fLX1SasRybciwujVcpe98d KDNbpSXhilUATEBAQ3vPHPCqmJgXb7qqdSppFbPzYhJWJbXLFEXnt/OrgqX+mpOSqTa0 fzb6FJN6i+IAYPUIOq6as76T+AzXGSF3xhbE0rxgV3+JFBTA42bXJSkjVzaTjx7STvI6 /wFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZAnTACxy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v1si14045792pgt.407.2018.04.25.11.29.31; Wed, 25 Apr 2018 11:29:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZAnTACxy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755762AbeDYS2Z (ORCPT + 99 others); Wed, 25 Apr 2018 14:28:25 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:45593 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756448AbeDYS2T (ORCPT ); Wed, 25 Apr 2018 14:28:19 -0400 Received: by mail-qk0-f194.google.com with SMTP id x22so5611241qkb.12; Wed, 25 Apr 2018 11:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vH0MgITDIQ5ihAvVjx3VXvFlAgEHvlBQ/T+OOhiFNcQ=; b=ZAnTACxytn1TiEwHTuDzx1sSXTXAyP0O+32xvh7tt7bTQFgroAGKDmlp+s7Izs1lss oX3VN3cv6Hwp3ofnlYzsL1P+fTpC9zD3fqkBvs5klhbn+nry6ZNOV03IFPn72Pty65m0 TbBKlUBfONlzAmftczVFpREKF6yYZka0j0ykBb27UVXSIqbZ/k/Y1TYQmTIiN4NJwrLk 4MYzWDNuCuU/kGowZW+XkP2jHTzWNsuqzAwvyTcjUfcW6l/Jw4WaOpAn3UkJHWxjiK0m 09ZiYT4N8917bj+4mN1AdGQqNzSfrSDWYtgPGz5WtwQias55J0cTSeE/GrlVmWtYduNt jfag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vH0MgITDIQ5ihAvVjx3VXvFlAgEHvlBQ/T+OOhiFNcQ=; b=WAf4LkSDLEee45O0E3sib0oQ5gc3jYz/n0XNjBo+JEXfR63VeFG+CFBovY9tNtyB+E pRHozRwW19Fv9kLFhpbXae6OU3pfZ7h1MuS8W2rafjSLlu+5RoKUrneV0/fs7ncDrRas uKSsyEhfVws9rPStCnxx5HFeE9BElmUBdPzCHh25YdROSI9u8AyRljmTmuhXNkowequH pf78ZZkVXRjAiaSw3iOZrGlABIJ/hUhxxVle3KYE0pirMe98LeLl74E0AtGZeiwx786w HcFPlZG4tGeUwzo4v2u4mL3b+NAZMgomGgQvILj8wZgl7NZ2SCH++eej95oJuTyHLuBb YUXQ== X-Gm-Message-State: ALQs6tCklikrNoqwGBU6LVgQpQBE1ytzg71hUj+LwaR53slR72wRy//0 A0yFY6H3UhWOubwtGqEKCp4= X-Received: by 10.55.203.193 with SMTP id u62mr29849589qkl.83.1524680898432; Wed, 25 Apr 2018 11:28:18 -0700 (PDT) Received: from mail.broadcom.com ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id x28-v6sm1980695qtx.95.2018.04.25.11.28.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Apr 2018 11:28:17 -0700 (PDT) From: Kamal Dasu To: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, jon.mason@broadcom.com, yendapally.reddy@broadcom.com, Kamal Dasu Subject: [PATCH v1 2/2] spi: bcm-qspi: Always change BSPI_MAST_N_BOOT_CTRL state Date: Wed, 25 Apr 2018 14:28:05 -0400 Message-Id: <1524680885-4600-3-git-send-email-kdasu.kdev@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1524680885-4600-1-git-send-email-kdasu.kdev@gmail.com> References: <1524680885-4600-1-git-send-email-kdasu.kdev@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Always confirm the BSPI_MAST_N_BOOT_CTRL bit when enabling or disabling BSPI transfers. Signed-off-by: Kamal Dasu --- drivers/spi/spi-bcm-qspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c index 2946989..6573152 100644 --- a/drivers/spi/spi-bcm-qspi.c +++ b/drivers/spi/spi-bcm-qspi.c @@ -490,7 +490,7 @@ static int bcm_qspi_bspi_set_mode(struct bcm_qspi *qspi, static void bcm_qspi_enable_bspi(struct bcm_qspi *qspi) { - if (!has_bspi(qspi) || (qspi->bspi_enabled)) + if (!has_bspi(qspi)) return; qspi->bspi_enabled = 1; @@ -505,7 +505,7 @@ static void bcm_qspi_enable_bspi(struct bcm_qspi *qspi) static void bcm_qspi_disable_bspi(struct bcm_qspi *qspi) { - if (!has_bspi(qspi) || (!qspi->bspi_enabled)) + if (!has_bspi(qspi)) return; qspi->bspi_enabled = 0; -- 2.7.4