Received: by 10.192.165.148 with SMTP id m20csp1041002imm;
        Wed, 25 Apr 2018 11:36:00 -0700 (PDT)
X-Google-Smtp-Source: AIpwx4/S7j94MHxps+GUacgfwjDNNhwRL7sq42gi+cDO4oQuoQXreXNVgTZnOAjZsRaaw83oo3lk
X-Received: by 2002:a17:902:1007:: with SMTP id b7-v6mr30086853pla.205.1524681360591;
        Wed, 25 Apr 2018 11:36:00 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1524681360; cv=none;
        d=google.com; s=arc-20160816;
        b=Z6L57MbnD2gwm+IhTjXtmAGvKDXZaiHRhuARwBgqtW7fxUaF6C9iwtuI3W60Wv+TzH
         Q9hM0FY9n4Tq9cqOfsvbL7NZ6q2tsR+lIx9rtV0Z7Gbx3PnuvDKnf/QfkuHrH02x9Bgc
         GSJwnOTkidQowRCT0PGOYIK55xQOmAkVUAe6cV/xvEV0znnrJAJbZVHD5IYlXiSql86J
         ZC7LUypiXDq0Rjq1kD3BbqfbXI+K/qzPu1zN8JN5MP5QN2CgatzLwwVlHbfaGW7qgvRZ
         HsWm/NwcZnku7e4fk2dL4eG+QF/nr3q27Oj1AEkT6qnOlt9pKMCPNv2+GLwP8y9o3xhj
         FNNw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date
         :arc-authentication-results;
        bh=pKdgkKSVUD3jJHywPsbDUk85wTF65q5TOrbsXmwaUiA=;
        b=COdy7qeiOrLQ6GJ2wm2QsCQu25UmSeky8SJrJ0fTsLnNNNjYWte4R5z5tLpFaHOQGQ
         rmGSciy2vuQrxy1QpzQif9RY7qP8KiVVrYY3Dou47g9fb3NsyblTNfr+XzDvFJ/KLbo9
         ADJWaAsa7qHKqExb3WfgKmMKqhsfKAyjkyNuHprQRSHwm0Ol8o2x4XanGNvYeU0XDiBm
         +VMEmcxVAygEukgZM9Z6prUr4RdlT8K5Cs0T5n6+Yl4KtRARmdjAxqVDMdUvy1AuEiiI
         n2SRIygSFHPIsjG4tTvHlDAMnsBS/jQ4yKcSDV6z8wW2xtbUF8WeD4huSnIoTqJQEjax
         SKLw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id z187si9405998pgd.646.2018.04.25.11.35.45;
        Wed, 25 Apr 2018 11:36:00 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756072AbeDYSef (ORCPT <rfc822;crosarcplusplustest@gmail.com>
        + 99 others); Wed, 25 Apr 2018 14:34:35 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:53600 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755348AbeDYSec (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Apr 2018 14:34:32 -0400
Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 7C992133F6427;
        Wed, 25 Apr 2018 11:34:31 -0700 (PDT)
Date:   Wed, 25 Apr 2018 14:34:30 -0400 (EDT)
Message-Id: <20180425.143430.191813743469618503.davem@davemloft.net>
To:     dag.moxnes@oracle.com
Cc:     santosh.shilimkar@oracle.com, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rds: ib: Fix missing call to rds_ib_dev_put in
 rds_ib_setup_qp
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1524655321-8379-1-git-send-email-dag.moxnes@oracle.com>
References: <1524655321-8379-1-git-send-email-dag.moxnes@oracle.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Apr 2018 11:34:32 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Dag Moxnes <dag.moxnes@oracle.com>
Date: Wed, 25 Apr 2018 13:22:01 +0200

> The function rds_ib_setup_qp is calling rds_ib_get_client_data and
> should correspondingly call rds_ib_dev_put. This call was lost in
> the non-error path with the introduction of error handling done in
> commit 3b12f73a5c29 ("rds: ib: add error handle")
> 
> Signed-off-by: Dag Moxnes <dag.moxnes@oracle.com>

Applied, thanks.